The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "William A. Kennington III" <william@wkennington.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v5 0/4] i2c: designware: Improve device disable handling
Date: Thu, 28 May 2026 12:11:14 +0200	[thread overview]
Message-ID: <20260528101114.GG3102@black.igk.intel.com> (raw)
In-Reply-To: <20260527-dw-i2c-v5-0-3483057f8d67@wkennington.com>

Hi,

On Wed, May 27, 2026 at 08:09:48PM +0000, William A. Kennington III wrote:
> When the I2C controller attempts a new transaction while the target
> controller is shutting down or restarting, it can lead to bus lockups
> and system bootloops if the hardware enters an inconsistent state.
> 
> This patch series addresses this by ensuring that the internal state
> machines are properly cleared when disabling the controller if target
> activity is detected.
> 
> Additionally, it adds a shutdown hook that gracefully sets the target
> disable bit before disabling the controller. This guarantees that any
> incoming requests from the controller are immediately NACKed during
> shutdown, preventing the bus from hanging.
> 
> Signed-off-by: William A. Kennington III <william@wkennington.com>
> ---
> Changes in v5:
> - Fixed one last inclusive language mistake
> - Link to v4: https://lore.kernel.org/r/20260507-dw-i2c-v4-0-9a447b23bfdf@wkennington.com
> Changes in v4:
> - Updated language to use inclusive terms
> - Refactored some minor comment / code nits
> - Link to v3: https://lore.kernel.org/r/20260504-dw-i2c-v3-0-57e56135d602@wkennington.com
> Changes in v3:
> - Split the monolithic patch into 4 logical patches
> - Reverted stray formatting change in the PCI driver's dw_i2c_driver struct.
> Changes in v2:
> - Fix description footers
> - Fix emails
> 
> ---
> William A. Kennington III (4):
>       i2c: designware: Introduce shutdown exported function
>       i2c: designware: Convert PCI driver to use shutdown hook
>       i2c: designware: Convert platform driver to use shutdown hook
>       i2c: designware: Handle active target cleanly

For the series,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  parent reply	other threads:[~2026-05-28 10:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 20:09 [PATCH RESEND v5 0/4] i2c: designware: Improve device disable handling William A. Kennington III
2026-05-27 20:09 ` [PATCH RESEND v5 1/4] i2c: designware: Introduce shutdown exported function William A. Kennington III
2026-05-27 20:09 ` [PATCH RESEND v5 2/4] i2c: designware: Convert PCI driver to use shutdown hook William A. Kennington III
2026-05-27 20:09 ` [PATCH RESEND v5 3/4] i2c: designware: Convert platform " William A. Kennington III
2026-05-27 20:09 ` [PATCH RESEND v5 4/4] i2c: designware: Handle active target cleanly William A. Kennington III
2026-05-28 10:11 ` Mika Westerberg [this message]
2026-05-28 22:45 ` [PATCH RESEND v5 0/4] i2c: designware: Improve device disable handling Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260528101114.GG3102@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=william@wkennington.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox