From: Thomas Falcon <thomas.falcon@intel.com>
To: linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: [PATCH v3 0/2] perf: Fix missing branch counter information in script and annotate
Date: Thu, 28 May 2026 10:36:35 -0500 [thread overview]
Message-ID: <20260528153637.300213-1-thomas.falcon@intel.com> (raw)
This series fixes two issues related to branch counter display in perf.
The first patch fixes a missing '+' indicator in 'perf script' output.
The '+' suffix is used to signal that event occurrences may have been
lost due to branch counter overflow.
The second patch fixes a regression in 'perf annotate' TUI mode where
the Branch Count column was never displayed. The check for whether to
enable branch counter display was performed before events were processed
and the counter data were populated, so the condition was never satisfied.
Determine whether to display the branch counter column after processing
events and populating counter data.
v3: For patch 1/2, guarded against printing a spurious '+' if the branch
counter width is zero, reported by sashiko
v2: Added a cover letter and expanded commit message for patch 1/2.
Patch 2/2 was missing some conditional checks to enable branch counter
display, which have been added back.
Dapeng Mi (1):
perf script: Fix missing '+' indicator when branch counter reaches
upper limit
Thomas Falcon (1):
perf/annotate: Fix missing branch counter column in TUI mode
tools/perf/builtin-annotate.c | 9 +++++----
tools/perf/builtin-script.c | 8 ++++++--
2 files changed, 11 insertions(+), 6 deletions(-)
--
2.43.0
next reply other threads:[~2026-05-28 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 15:36 Thomas Falcon [this message]
2026-05-28 15:36 ` [PATCH v3 1/2] perf script: Fix missing '+' indicator when branch counter reaches upper limit Thomas Falcon
2026-05-28 15:36 ` [PATCH v3 2/2] perf/annotate: Fix missing branch counter column in TUI mode Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528153637.300213-1-thomas.falcon@intel.com \
--to=thomas.falcon@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox