From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9403B3546DC for ; Thu, 28 May 2026 21:05:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780002309; cv=none; b=AGxp5rFAT0dAIhCT8gPu55N6N2Ipf3opx1/XiTL8mGmq7cTLvN48NLEqxaxKa3xbtXNdUMcLBu+WlyMII96+vXGxbGxlCj3Mb27R2YIL9cI/HE1RJs+y30UeO2A7icGR5MLWFnhX18lk78gIVsY3D8Cmdq1wuCVTJMKeruMBtX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780002309; c=relaxed/simple; bh=tk1c7rnwuBHS2uRZ5SwD0NGJn2M8Eb6GDVhRgrEKGj0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pkdSjzX3yNPT0lrL0BHCq0VRNlO0p3VNHOhJxteAjMtFkYzYKf+zK1x11mts6XdT5oHv4sEd2WyAVCvBGuWZEHX6UAuu66tvYNn+EGsx2XcQVx3pNy9ZIZbet3J/kdvZV/dKo4Dk3ynfI9kqzUk1nGYait/FRYrYuZJty8h3Q20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J/VqoU+R; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J/VqoU+R" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490388fd0dbso75683925e9.0 for ; Thu, 28 May 2026 14:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780002307; x=1780607107; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=K4mg5HNDrZSCCvclWVXl2PaKa8JuKCMeM5HAnfez5H0=; b=J/VqoU+RzIZentEDsQSC0t35GnF9EqBfogi0y7anugMWf0LbAfQFbRd1gJTprc9iqG 6AZWYpjvc6Cafgf2E8BAlkStJsRb5DvVrZKkiPML55E5Ky2VUXU9qt1ud8xsxsb8Lhi1 vFAB3d5a8K+kM5/AJA/qC/UJb2Hpa60+1QTbTtpXqdxT3D8dEJl6lI2SZDBLDA4FWqHo BGwNXmLFftYqj5vVlsPacGvV4xByRCwURvuD/DzEHhVmt22GH4Pgdw2p9ytNS8dVmDUr cp44IJap8Y5kyGPXfT1L6skcl26LYM1X4ff+JKUAdrixPRuqCwSXl+hWGwmKZLJMcI61 yEdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780002307; x=1780607107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=K4mg5HNDrZSCCvclWVXl2PaKa8JuKCMeM5HAnfez5H0=; b=iai3P3DXpQMHam0c6+5TAiUUP/lWHpKZhORdWpcQwfgEGYwXkQUq+tBFiQbpkQq6TT 27h4lOP9AHaFTC19id8mk0RmhnBf1GF8y7xvw81JSD7uFJhZ8JLbTpvFXvaZfMTdDk71 lyxhekjxVIBECOvHNskLSlbOm0QSLPeMhTf8oIBPJWbluPap6JJ+h/UdOFMfp2gqOc5V EchUPiGhmfwAHqwkOUP7Gu8mFMiMxAkPUGWQvSbrhFmfsABKSuKxdgikMEG6OAU4mBhZ zhRzlpaWn0sQVKh3d3cKjIRbTzDIoWoA3Vipv86jr2o1szGxoBeTYb8nQVNXA7tEuQym 5PGQ== X-Forwarded-Encrypted: i=1; AFNElJ++6JdnFI/DJyFGKb9UxkHRMQX+dZSMWb3bpO6FBMFF0qIYOWJwrT44ZNs1Ui3P7n9ghMyOo8JUGPmmDNA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3u3ErTy6l3DTmmb0OwwFVP488W7OPFBtyj0PlzUKsTW0sOi9K vKrXzwnpqRnOlaqV8ePyMwJ/6Q3Bz0dSGrNfq3O2Vjv0s95rCrQfkQCK X-Gm-Gg: Acq92OHoLoVgZrIF9bOcUnCaczNJiKu1fFarXQ+RYM7TbTkuF64e3bcpvOtkXsXnFO+ buP/gJlMIXh2/fSQSRFTiIem42wrfmP/7Y7h8qBhX9wLO/j+RfFdtyLhAdokqk1wuhJRN9qivEe hLBGt+SOwuOvnov5TDnRiue9mhniSkFDN5HoJym8CvqC4wQJsNBvaYkSZ/HokIbbG7rt3Mc/hSg abkock8P7D6DHPjZDEy3ZJJaeTVXDCv/eVd/Jr/DUhdRqbff5g0KI0bcA34CXy7wY7tNNfFXYKm C5tds9KZDhqXCSIN5yw5ctgUiVf+qZHyek41aa7OTG4PwUhtjagJ+lvab9yznCSQ/i3jV44TUmc G41TfOnK+qfCP22PYDtaFzo9fNTaxTMi8zKeE5BcR6HgOSlVJPFy6l8ybxmi/x71hvyURGLpSTe thi9vkUo9QzcLbBXqPqkuhw82URc+jkWdtLzQV5Ho+KpOXoQ4FVBuo/w0VQwjl5eMPbhCGO98= X-Received: by 2002:a05:600c:c059:20b0:490:3d62:f5e1 with SMTP id 5b1f17b1804b1-4909c0e421emr1387775e9.22.1780002306931; Thu, 28 May 2026 14:05:06 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49092654e10sm56452765e9.7.2026.05.28.14.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 14:05:06 -0700 (PDT) Date: Thu, 28 May 2026 22:05:05 +0100 From: David Laight To: Rosen Penev Cc: linux-block@vger.kernel.org, Ilya Dryomov , Dongsheng Yang , Jens Axboe , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , ceph-devel@vger.kernel.org (open list:RADOS BLOCK DEVICE (RBD)), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: Re: [PATCH] rbd: cast snap_count to size_t to avoid tautological comparison warning Message-ID: <20260528220505.73eac71a@pumpkin> In-Reply-To: <20260528202151.136274-1-rosenp@gmail.com> References: <20260528202151.136274-1-rosenp@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 May 2026 13:21:51 -0700 Rosen Penev wrote: > snap_count is u32 but the comparison is against a SIZE_MAX-derived value > (~2^61 on 64-bit), which clang flags as always false with > -Wtautological-constant-out-of-range-compare. Cast to size_t so the > comparison is done in the correct width. If that warning makes any sense then the cast shouldn't make any difference. Why not check against RBD_MAX_SNAP_COUNT - the buffer isn't big enough to hold any more than that. -- David > > Assisted-by: Opencode:Big-pickle > Signed-off-by: Rosen Penev > --- > drivers/block/rbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index 94709466ad19..b4ba51db9a28 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -6079,7 +6079,7 @@ static int rbd_dev_v2_snap_context(struct rbd_device *rbd_dev, > * make sure the computed size of the snapshot context we > * allocate is representable in a size_t. > */ > - if (snap_count > (SIZE_MAX - sizeof (struct ceph_snap_context)) > + if ((size_t)snap_count > (SIZE_MAX - sizeof (struct ceph_snap_context)) > / sizeof (u64)) { > ret = -EINVAL; > goto out;