From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14AF634A3DB for ; Fri, 29 May 2026 01:05:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780016722; cv=none; b=JPQHAhvJ7r7mhTV5rpjRUHaPAi/upBcpapenqdeljWxWzolveBUIRjivv+YUzqoMLAHSlzqSLcYRAOm2IsUV5+I+dJYlFZTx0YKkPYS+zhngP/BnAB7fNthaqXhLqdRVUoxAF8A2ks0JENoxWJF3emzYs9V4BPRPIE6ihWV6ark= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780016722; c=relaxed/simple; bh=1bEqHSCCKRDDQQinQnzVucKwHK7P1jobeJy5PtN3mEo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y0wxNWwgx+i2+ptsjlWtjJxVXZ2JLYkv+WbmvB8pUrUM9HZ7uluFDn3YTyDqJpRQOHHENbY6NoKQvV+SKNC7Aolmv1ucnXWueu5W4bHiUj/F6fhG1xkCxQWimIBDJJkKDVE1HgzKlTQRMR2OQ5xZGhY2LhQvDofu/Q40TRzc9DY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tZJK7yrN; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tZJK7yrN" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2ba180a022dso685ad.1 for ; Thu, 28 May 2026 18:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1780016720; x=1780621520; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+QSaewdY+ty5a2m2tiFLNtjVpl4qPVblZ3Qd1C7Nzpw=; b=tZJK7yrND4pk7cs3Ic3OUtbN418ArFwaX+zqoQU5wl6KO/KXNAiSsNyG5EOu3gmbmg HcR+asW1VJxcng79GRnCnnztNYojQcABaM5Fg099rrYHpk4pBri+MyL24GuOvaHQGhIi kvwY50qFjRBqXj7ivbpF7nXNNNsHQHj4cK2GBHIpCb/vzhcPViV+14wXDNAW8l0x6KK6 PqPgDK+ttDR581p6RKUMi7marzCiI/2Q3ijvWNvHDXvVLWpiJqtGK8XeDfPGtwExDTxD jwCJ/XoLlHGrQRUkPJ8RCNKx1cqQ1kD+rHdUGb2M2pCiJuxKCY1WpbFcV/72Xv5XWyts Jl2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780016720; x=1780621520; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+QSaewdY+ty5a2m2tiFLNtjVpl4qPVblZ3Qd1C7Nzpw=; b=Stx5+wnwjy7RvPSIbaoSRFA/yvJ4hSm+pXgxfsFlD1ZPr8x42NKP/Z4yCIkOZ38vP6 wwc+xvfsqETWJSr71Vt9HIacfxunM8mDoPB3dcBu5Q5oQiCRpS2siuqKM+BOKVQ48TtT tm8iafZ/uHR8YbT1fEK5Lp5eB7IRB+HeWCgnwSl8n6cAFpeKxfB/e3p2WnrmscHy43Xf x/LEQZgmmF047J8AZq+3Xy1iiFd7BWHgmLp3MDJZPuYLLyfXjuBIjRG0dcvhl4/jneo7 hYPFTGl395JtIUz8RFDSORg1BhQYVHlemXKDen12ZSp6Vd/4OfqpZ3tGdrO4RmMnaQ/e SRcA== X-Forwarded-Encrypted: i=1; AFNElJ8+dJsYLAQOHIDPd3qEh2bVLWw2PJF+hBqn/t4JEvX/XySDLE0xHd87D6ZeDSN9cFxKVjcDsZxHtc4oV0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzyZXZc46QXmXV8xIQp87UvQ7qMQ2Mgg2O/bYCRuau58IDUHVhb tFEl1loK2+J+l6FEI6E0T1XcjD2d0p027sgqkzQ2u4xA/WgpXpAhmSMbEz4iJU68Ug== X-Gm-Gg: Acq92OEJDzbaqPIaXowLJWOw8j0kvhUgZknSy7yNCToPQZBIiKzLbPaN77nVqRiYmKU LPQyMBeEp0fRAy88MxGcJNVTqOhP1NwCfeYKJQw0/96LydQbVk9D0w/L7BxOJpDOETkS3hTe7k7 apeAl43a5BY68fGflReXsT8ufOW1CX6TDljx0xg598qUOFCXkhDfhKY9BjP0ek2ItX6rgF/jWUJ 9ukelexO0HdgxuAfolgkdlB4/KECW/V/1RDNkDyHM8sQ0gHYyO9Qv104TwrwhxA/VDpcoo3i2S2 HICUgGFZdkvFQPV3OURbnGhw6Y6yb3YBQuJ0ENVpJpsffp3WNbipiajhzRjaNfgCra+U6Uhj+qm FhhxmiAQbLw5i2XCRCNJi9T3YQkVU+Fj5KbZ4+/jYk2GXzjSDv2EInAxuy3pkhyrkEf15FYCh8A tLklj2S3eCM+9znF3fytrAFhVv8Aj1gwMOBapNEdv8zZzxiG3n1vJt23nhjz7UbR3JViWlch7ra taTbQ== X-Received: by 2002:a17:903:ad0:b0:2b4:60e6:44bc with SMTP id d9443c01a7336-2bf22eb5525mr266985ad.13.1780016719847; Thu, 28 May 2026 18:05:19 -0700 (PDT) Received: from google.com (171.46.125.34.bc.googleusercontent.com. [34.125.46.171]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e5d83sm318045ad.8.2026.05.28.18.05.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 18:05:19 -0700 (PDT) Date: Fri, 29 May 2026 01:05:14 +0000 From: Sami Tolvanen To: Kenny Glowner Cc: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Miguel Ojeda , linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rust: module_param: add missing newline to pr_warn Message-ID: <20260529010514.GA2807207@google.com> References: <20260521161405.64042-1-SisyphusCode0311@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260521161405.64042-1-SisyphusCode0311@gmail.com> On Thu, May 21, 2026 at 11:14:05AM -0500, Kenny Glowner wrote: > Add a trailing newline ('\n') to the pr_warn! call in set_param to > ensure the kernel ring buffer flushes the message correctly and > prevents log line smearing. > Applied to modules-next, thanks! [1/1] rust: module_param: add missing newline to pr_warn_once commit: ae12a56ba16adcb8a06d5b3b91d4f82a092e8de3 Best regards, Sami