From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DC923090F4 for ; Sat, 30 May 2026 03:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780110423; cv=none; b=rBASmRw3UMoDvcw/L22MI8tBf6FMjqrl6KzRIOBJqeMMXFMmvk0fiN+77UyRE8GS+WMOmmMlAlYwGNnAWj2+yyXbRMeQGPbYju+y1xoQ7ukobww0M7mTgNxTJPs8OGWFTbmwM/LC5g0Xe7y2XDD5shUlf0EbU9eT1WifdKU4lEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780110423; c=relaxed/simple; bh=Jo8C9fYgR8M+9qmgQGvTGQh0xayfuj60QKKA2cUXXLc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=d0w8xMMe1LfjVTL8UeitnjUEvC9GrxsnCn5OVaNyY4/GDbMXdoy4NKy8SPzvrBNiZHkneLX9Mx05HJ85IU9KBUscNqp+udCywqIXLjq3zGIVLJIaB88qAY5E40dz5+VSpQDNsJZ1Wj7c+KUxRUlkyjj8pIk0W7n7Ym4toO/lWXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WYNE2AnN; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WYNE2AnN" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-43b7e186a0cso2545585fac.0 for ; Fri, 29 May 2026 20:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780110421; x=1780715221; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pL8uMvAYVmFHlT5lD+kMaVasC/p+a5VnYewFeWxq91c=; b=WYNE2AnNvM7/aaU05XKNzaOW02CQRIuP93mu4Y/4Y06DGSDHwe2IHsFZouST2E8cDT 14qGzgqUYhhYm3N9+9gCaqcm8Ug/sCkSJnLpQ+UYmq40aGyRzEJ0LpsuIoskUYaiz6Gw Mj9X6RJlCqQ0qGHVsN1Gi9m/G2+zjTzTScAFZkz/O9b4tRI+w6bJd4mcnYIhZhK5P6S/ EItcsPExpFQZPTT8JLJFY4ZOXxHPJsCnBEKQTUUCfLFu+VY3g/gCsKemVALM7nOWWNDn vHwHDYEWPiSsPjvDSseJ+KIfG1QBv55NGFIHMrmnZ8RKVTw8EmN+B5wy7GWSNF0w5iBo jCBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780110421; x=1780715221; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pL8uMvAYVmFHlT5lD+kMaVasC/p+a5VnYewFeWxq91c=; b=CgwImRyuwTfN2H+lRG7GMEJMTMoOS64zA1evwacSgfgKJD0zezVQrUGjdrSK9NcJ7H JxKzPM9bFmqfk7AroNR9UvBA0jiYutAQDgJFDoqzhXKHjky9iGrSMOW7jdGiwm0Gqq/V ako6y+X6WE4mSa9fHYuJTiS+W+m4R9xVg0grYgzoLRH2HQo6oH8di3IRM0ZToI1VP03L f6FsS/8KjktjW/Btav0QYTXLuty8urRh63ORXq+siZ1tCXG9IWEcvx+O6dAi/bbRkxib uTZdMPO/LYnWmU8UhjHKZjYwk9KM38lZfHmIoZEw0NwEKaWHI5ILMfmPGv17mbQPT7vc UHUA== X-Forwarded-Encrypted: i=1; AFNElJ9YU2tqC4se8CtdGAZqpuO23+LVEcOSYfR5wmZeDD8EDY+TNL/cWJcPXcEoUV5bI+9Q7q01TY15MA+PtIo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8xLusEtTajHHjeyVrrP8qeM1e/ADvVlj30EfOlEcA5MHih9nZ 1CePsNHkV8x0iR4Of1xthlX6G+OGmFQvpUXPa2NUqpcDSr9j+rS7i4SC X-Gm-Gg: Acq92OEiUKbrnQN0fzwdT3xAQmhIkvHV4Nrz5VkobgvP7ht8cs/WNqTX+vKCfALZ9yo boRnP3tXcNBHR1shlQQa2S0lAO3zOX+Qch4KnJjyzz5rotqmRJi0kIaTFiDRqMG8juW8WPb/FvS kn+kJ/1/RiB7sOIeHGXjlJ1f4MKaJguFvVBgtbdDdGDN7IpiF51gji127rq11yMY9G7ABh9+WKZ 0q8/tXiWBuWMYTFlYAbC+1hu6X9Cj80h+6wBeu5UX72kgo9lmnWJ3cnXFsxzP1rt7kWaZFR0Ssk BW8yLMwu6I1yAmU7YKeWXE3e0S984Yn8gntbIDUT/DRcR6EIgcYBLkSxNCMbg6BpsI+XNghvP4v 4MJwXmSp5P1X4auY5ZB1KT85RxoSJQPwR4Ejev6hD+9Cn4mHo4X97qLf8bdRHYW7A4Ldq642wir 6GZY+hcG1a+0cQfSVs+OBTiC6nvK9zt9/qS5l35/FuAbqQTTee6VJmAe5WFw/aQbmqE60Dag== X-Received: by 2002:a05:6808:f0d:b0:485:5f3f:bd1b with SMTP id 5614622812f47-485fb2fca4emr1192006b6e.3.1780110421613; Fri, 29 May 2026 20:07:01 -0700 (PDT) Received: from localhost (static-23-234-115-121.cust.tzulo.com. [23.234.115.121]) by smtp.gmail.com with UTF8SMTPSA id 5614622812f47-48606211a99sm37325b6e.17.2026.05.29.20.06.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 20:07:00 -0700 (PDT) From: Sam Edwards X-Google-Original-From: Sam Edwards To: Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko Cc: Jeff Layton , Xiubo Li , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Edwards Subject: [PATCH v2 0/2] Bounce buffer for mds client decryption when vmalloc() Date: Fri, 29 May 2026 20:06:44 -0700 Message-ID: <20260530030646.85589-1-CFSworks@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Ceph maintainers, This is version 2 of my previous patchset to resolve fscrypt oops/panic when decrypting filenames from a MDS message that spilled into the vmalloc area. [1] Cheers, Sam Changes v1->v2: - As Slava pointed out, v1 was performing `snprintf(..., oname->name)` *before* the memcpy() that makes `oname->name` valid. He also raised a great point about the if/else-if block's complexity. This version simplifies the control flow structure. - Reformat some whitespace and remove unnecessary linebreaks, going a little over the 80-column soft limit, but improving readability. Feedback not addressed: - David shared some discomfort about fscrypt_fname_alloc_buffer() sometimes changing the allocation length, but it only ever lengthens the allocation and is therefore always at least NAME_MAX. - David also began some discussion around passing an explicit `tname` length; I'm still open to the idea, but would like to get a consensus around that first, because enforcing the buffer size will likely require changes to the base64_{de,en}code() function prototypes to accept buffer sizes. [1] https://lore.kernel.org/ceph-devel/20260527025828.5966-1-CFSworks@gmail.com/ Sam Edwards (2): ceph: pass fscrypt `tname` buffers directly ceph: properly decrypt filenames in vmalloc() buffers fs/ceph/crypto.c | 50 ++++++++++++++++++++++++++++++++------------ fs/ceph/crypto.h | 4 ++-- fs/ceph/mds_client.c | 12 +++++++---- 3 files changed, 47 insertions(+), 19 deletions(-) -- 2.53.0