From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3C6D39DBF9 for ; Sat, 30 May 2026 09:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780134307; cv=none; b=tp/7PgYSK0OcIT3BxMVCRH44FDf8aLx636YyOCd6jnLh7AFjlqk74pd+VzX3UpoKEytCD+GDgy1xwSLPho2ctr6iI8e0JXd53MViOZQeyc94K48JtCS31hKRoDQwZBjw9TvgDypyAWhGwFnAAD3Q+9YkJkpFBh+Mnohxp5HUuso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780134307; c=relaxed/simple; bh=g7WNCB9Rt/1OuSYvuRDcXaghERK+Kgq7rXBJpRUKNDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eFDppGLspnBeQVjVbQC+kQodqN64oDgZ7D3Dfw1v68orUo73jFNGqoQaoIK4CXgI4WrfZadpn5ovbUjgngXDhIrU24v5ByBUPzwrFwzhUKQ4xkJzmUFzI4vFjMZSJmRYi0rktQp5cUtmn+OozkSu1IY71FatQIxY2BxIckqLf4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VIeazxf/; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VIeazxf/" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3664df32e91so16316842a91.3 for ; Sat, 30 May 2026 02:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780134306; x=1780739106; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UsfY8GRrXZdSk9lyMdgzW2ibIF3DXFt06J5TGlB1HVc=; b=VIeazxf/pOgIOrSnPe35VdjpGxmNQAboJ7opWLOaRxgi6s4qOTroJfCziQi1IJKHus aK8Ya6Eet6D9HWVsbgIUlxADr+HUcdftQX133EFn97XUGWt0+YjIGNq7qUPay2blL+r+ kp3KEkX+gyUhuZOU+pCYwlaJSqrqBMdXy4TQh/PkVcjLztHL/OTIU1sAmo+IPl6smJSc pJQ26uib882FcqVZHCoD5x+BQJ4+llX5TmbubN7rXv0r8ws/O1Yz4JB1tuoBK/VsPoxJ n6jRPqLUqKzlGRr8Aj9aH5ljK60h5sToBnGA5H/AzSl+qtZUT4ItnUOHtuWMEPjlsZj0 xfqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780134306; x=1780739106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UsfY8GRrXZdSk9lyMdgzW2ibIF3DXFt06J5TGlB1HVc=; b=AU5HdEg8lyTIIY9DoYxIllOssLva/XfzYk+TQVyII6SCScUZzMZReSYF6BxmWrZCay QlKWjQxeplgr4Ju4GyXU2DxTXHCEKym+4i77NN3KuRgrVkki9V8bsYYaT6lOId0Em48s VFCi2VWvydyI9ijVTueduitSxrwMugwFQPO/rNRrhkXjcs5qcRVOzhLfMRGlZOVY5rLU oTrMXdAD9EhDILhNW7D2VrYLjnxLvXMIrfGJ5HCC6P0OM2t8JQsmYM4ek08+T+vp3Nwa hSp9YhXUhk6PlznWQgt4lEgQ2RnePJnxEsny2YWCIHfVXywpPOV2W2VEfU8WCwy0ZB3h be9w== X-Forwarded-Encrypted: i=1; AFNElJ8ctnaDsjFEbKPcomBMRHmoSFuhctnksCKa+WRazFZGCx3G16LNngk98s4MpNGrSyFBDCWKsx9vD7Gx7tM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq4/J5ELhSLlcGCLIhUOKK9rzGuk+h5iHBqEB69IDb1qcAWugX YYl+qfiFzb/++Ccunn4Lo11IZ/J7b1nY8QU0QqIn2Rex9SUAQ9xijrqK X-Gm-Gg: Acq92OGsXlHc1Rqek9nChpVeQADoYcMgdTsRUPrRF/b/THegVERgVdfRU+kKTqtOnOD Xk1C+mfDI/ig8UQpl1+DnznrHUyfcxgzQJj+EAvvdA6ZbTQ7AZ/K7HU0MqzgqKKx41MccTFzqMp IdsYCgNiRh5lLbFVtS1UJFs2i8iTFz2VxtGLO/69ncRuK2cK4qGNtuHJXTx04VMGWx4ue83Lll2 dNpsBeOzEiczLNSjYdDsSvnDpc672WZF+oqUSUJhLDP6JISXsbkRenipdM/FH3Zm9VNnGVJxiHX pR6Nf5PmZYJF6TPUqu6Vmysx3BlFERzrtK91qfvIpRvzeLj1M0YDfx1AN4HyemNZCq/YD2IFGAM +g8xO2C6aydzPxxvJpVb3rlf1bodEAXWvLK45iayYAPokHn2cPdI19sV6DTIP4t0Srv7G5HlIep oUYRd7WhM5f1rrkzs4U+wptwFjpyyIsFvJQAcolOneRw== X-Received: by 2002:a17:903:32cc:b0:2bf:23ad:8598 with SMTP id d9443c01a7336-2bf3679336dmr37430715ad.5.1780134306001; Sat, 30 May 2026 02:45:06 -0700 (PDT) Received: from rockpi-5b ([45.112.0.191]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf239e700csm61529945ad.10.2026.05.30.02.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 May 2026 02:45:05 -0700 (PDT) From: Anand Moon To: Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Maxime Jourdan , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-amlogic@lists.infradead.org (open list:DRM DRIVERS FOR AMLOGIC SOCS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Amlogic Meson SoC support), linux-kernel@vger.kernel.org (open list), linux-media@vger.kernel.org (open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM) Cc: Anand Moon , Nicolas Dufresne , Sashiko Subject: [PATCH v6 6/8] media: meson: vdec: Configure DMA mask and segment size in probe Date: Sat, 30 May 2026 15:12:52 +0530 Message-ID: <20260530094326.11892-7-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260530094326.11892-1-linux.amoon@gmail.com> References: <20260530094326.11892-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The vdec probe routine did not set explicit DMA constraints, leaving the driver dependent on platform defaults. This could cause allocation failures or fragmented buffer handling on systems with stricter DMA limits. Fix this by: - Setting a 64 bit coherent DMA mask with dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)). - Configuring the maximum contiguous segment size to UINT_MAX via vb2_dma_contig_set_max_seg_size(). This aligns the driver with common DMA setup practices and guarantees large buffer allocations work reliably across platforms. Cc: Nicolas Dufresne Reported-by: Sashiko Closes: https://lore.kernel.org/all/20260521090944.F35401F00A3D@smtp.kernel.org/ Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") Signed-off-by: Anand Moon --- drivers/staging/media/meson/vdec/vdec.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c index 4884ee04b352..f99335effe17 100644 --- a/drivers/staging/media/meson/vdec/vdec.c +++ b/drivers/staging/media/meson/vdec/vdec.c @@ -1064,6 +1064,15 @@ static int vdec_probe(struct platform_device *pdev) if (IS_ERR(core->canvas)) return PTR_ERR(core->canvas); + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); + if (ret) + return dev_err_probe(dev, ret, "Failed to set DMA mask\n"); + + ret = vb2_dma_contig_set_max_seg_size(dev, UINT_MAX); + if (ret) + return dev_err_probe(dev, ret, + "Failed to set DMA max segment size\n"); + of_id = of_match_node(vdec_dt_match, dev->of_node); core->platform = of_id->data; -- 2.50.1