From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6AB533F5A4 for ; Sun, 31 May 2026 09:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780218768; cv=none; b=FUP5KMFYSnzDc4ojwPB/ZOKRxfg9M0H2GGH2YWb2p24riEbK71TYY03IeKPEqm6mM/PIe1p586KgH77wSQyMW8bVoMmmcYDM+hJvzRySR4fEcmJTU0QtzWOtjWqdkuK7Fl+p/UJHLVDYXTv8PbscOOoMfPxJI6AP7bcpfJDgFrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780218768; c=relaxed/simple; bh=pQg5Q/iZcgJR6DLHA+71hlC+WTcoKbxsSBAxoRySv9Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MTcvzMsK6WpMdSVd6gvf7P2M8FCBr86fDr8B/HJP3wnT6TL6db2pDvspKrR9XWZZ8SjP4IGeCcmO4FGZHjyx7J113+skUvMkzClWxSJAZr8CXf4mumKyBciVNv1DLcVngY/g1wPlAmx0TPNjP2Rggdf1yJBQ8wmHxQ1loR8gnu8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WCIWVHZW; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WCIWVHZW" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5aa612bf6efso1203251e87.3 for ; Sun, 31 May 2026 02:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780218765; x=1780823565; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dGE7IsvRZpWhFx/mDtlwm79soIqXLEK47Cso1wBFxbI=; b=WCIWVHZWtBzw6eCTmD6IlHeZ70xab/FNKcz8bJLDgW3vHJZGIVgNYa6PZFFRzG0RwM uWLLyy+g1eid8dChGBH3ObxVbboGWgepfahZQ3b3B32wDhAcAotdbX6hhmVKHxkkz0dK bVmp7/i5ozOw/glbosdmDFS0qgqFDohz82TjWgBp9PmFVztjQ3kqTB4GXJogtEr334ou Gh/Oy3btJ+bj5XrtLKfuQGYtJtgaHJW6wNEGNlmD4rsFS87/W3U7wXwv++eqb140G3eQ hxYFYl3ty/nZoqtSue4SfyAdw9BTEYesEN9Fs3YIUbw1xvIrw6eht+zDKgokapxLUSYF EbyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780218765; x=1780823565; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dGE7IsvRZpWhFx/mDtlwm79soIqXLEK47Cso1wBFxbI=; b=Bp2TZC/Y1tq+tVgTgnuI4hs8NsapxMiXENBmGdrSeC49AqfDXjkbPCX86EMn9LWAVy Tou/jNEbLXzXoiq38wJkb//rbYP7Kj2g+dQxxVa5M8aCKXhMRcVKuL92bhI7umV4A/J1 RfFu5Lgm1nk/Bz1NHO29GjgTdlDBDigSZsrOeFioPLA3pxLIyWKevHXSDjXCpgZug6qc JWg+dIVCJsdS2NBdolYkNeA9qnIeU0noNpZNv/DpTOwwXX5wtiwV95S3O7mgoXQASiAW q05eEiXxWfo5nIvFE/GLiV7Urkn4mkPWc1ER1rxiRsmuh8hQWsi5G3z/PQrmZgQ0Iqah jXGA== X-Forwarded-Encrypted: i=1; AFNElJ8yIhPcUfsV/Ab6lypnK5Z/zpppr+mRNHImj1LN1GY5e6G7UZ5YS5/F5USEYHYSYRQZpQhkcvVjZLajb9E=@vger.kernel.org X-Gm-Message-State: AOJu0YxfSN4rmS5TSTuX8CDamd2XJ+Hmkq2Nw1e/OQQ2WhGKAzLdFSQ9 BbVgD1N02SK2+xVV68OKkLpSM4rQqSd/Lvk7Csi3bKfEHKpz7URnzL7HZgGue385 X-Gm-Gg: Acq92OHpuQniMJ6qVv9Pk1pf8w2Y4G5RplkhvLJ9QjIWKaIi5ZsE0rqmzV1ksjfLKNY bZr/rn808oayYZOUDJVn0/VhqJQXcoaj32PDfLJMoQySxnABB48SAZMiCR56YLv3/ct2gXlZdQ4 Tta8KPNPVjZZKDP9XSpuDrFdau3rZKGXR0FQFb75V80fdKkSdgJEI+YmG13XO0zGKJtX4piI7Ia kL4RPGQAHMCwPOy5ke2zZCIVAtQQ9p7IukiP9IJK204/6eov8EIeflyvLxhO1LHyYmiKh7PxarY 9Gmgm/U7xoFTJSUMdhguEqwp1gU7pvn2MJ7+xVoZLtgOnxPXR1qQgpc+8dNQ/PemHExZj2eklHx eIZqiFuWutai9kW7p2EygVP4vHg/YMsLVG3YInoIyB72z3U/CcoHTKGqGHrzhE5REla9STLbewC 5GxGTnlOSW8IysMjXMld38KUkHjb+nSo5KOnyf2qEkvlE2adDXA9P4wGDZBD2zYZaSs0g= X-Received: by 2002:a05:6512:1090:b0:5aa:6939:1ba5 with SMTP id 2adb3069b0e04-5aa69391c51mr437282e87.29.1780218764665; Sun, 31 May 2026 02:12:44 -0700 (PDT) Received: from Shofiq.home (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5aa5b071f33sm1455331e87.20.2026.05.31.02.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 02:12:43 -0700 (PDT) From: Md Shofiqul Islam To: mamin506@gmail.com, lizhi.hou@amd.com Cc: ogabbay@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Md Shofiqul Islam Subject: [PATCH 1/2] drm/accel/amdxdna: add debugfs support Date: Sun, 31 May 2026 12:12:41 +0300 Message-ID: <20260531091241.1764-1-shofiqtest@gmail.com> X-Mailer: git-send-email 2.51.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Expose driver state through debugfs to aid debugging and development. Three read-only entries are created under /sys/kernel/debug/accel//: - fw_version: firmware version as major.minor.sub.build - device_info: device VBNV string and device type identifier - clients: per-fd info (pid, heap usage, total BO usage) Resolves the TODO item in drivers/accel/amdxdna/TODO. Signed-off-by: Md Shofiqul Islam --- drivers/accel/amdxdna/Makefile | 1 + drivers/accel/amdxdna/amdxdna_debugfs.c | 63 +++++++++++++++++++++++++ drivers/accel/amdxdna/amdxdna_debugfs.h | 17 +++++++ drivers/accel/amdxdna/amdxdna_pci_drv.c | 3 ++ 4 files changed, 84 insertions(+) create mode 100644 drivers/accel/amdxdna/amdxdna_debugfs.c create mode 100644 drivers/accel/amdxdna/amdxdna_debugfs.h diff --git a/drivers/accel/amdxdna/Makefile b/drivers/accel/amdxdna/Makefile index cf9bf19de..01a809d88 100644 --- a/drivers/accel/amdxdna/Makefile +++ b/drivers/accel/amdxdna/Makefile @@ -10,6 +10,7 @@ amdxdna-y := \ aie2_smu.o \ aie2_solver.o \ amdxdna_ctx.o \ + amdxdna_debugfs.o \ amdxdna_gem.o \ amdxdna_iommu.o \ amdxdna_mailbox.o \ diff --git a/drivers/accel/amdxdna/amdxdna_debugfs.c b/drivers/accel/amdxdna/amdxdna_debugfs.c new file mode 100644 index 000000000..bd55a9aee --- /dev/null +++ b/drivers/accel/amdxdna/amdxdna_debugfs.c @@ -0,0 +1,63 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2026 Md Shofiqul Islam + */ + +#include +#include + +#include "amdxdna_debugfs.h" +#include "amdxdna_pci_drv.h" + +static inline struct amdxdna_dev *seq_to_xdna(struct seq_file *s) +{ + struct drm_debugfs_entry *entry = s->private; + + return to_xdna_dev(entry->dev); +} + +static int fw_version_show(struct seq_file *s, void *v) +{ + struct amdxdna_dev *xdna = seq_to_xdna(s); + + seq_printf(s, "%d.%d.%d.%d\n", + xdna->fw_ver.major, xdna->fw_ver.minor, + xdna->fw_ver.sub, xdna->fw_ver.build); + return 0; +} + +static int device_info_show(struct seq_file *s, void *v) +{ + struct amdxdna_dev *xdna = seq_to_xdna(s); + + seq_printf(s, "vbnv: %s\n", xdna->dev_info->vbnv); + seq_printf(s, "device_type: %d\n", xdna->dev_info->device_type); + return 0; +} + +static int clients_show(struct seq_file *s, void *v) +{ + struct amdxdna_dev *xdna = seq_to_xdna(s); + struct amdxdna_client *client; + + mutex_lock(&xdna->dev_lock); + list_for_each_entry(client, &xdna->client_list, node) + seq_printf(s, "pid %d heap_usage %zu total_bo_usage %zu\n", + client->pid, client->heap_usage, + client->total_bo_usage); + mutex_unlock(&xdna->dev_lock); + + return 0; +} + +static const struct drm_debugfs_info amdxdna_debugfs_list[] = { + { "fw_version", fw_version_show, 0 }, + { "device_info", device_info_show, 0 }, + { "clients", clients_show, 0 }, +}; + +void amdxdna_debugfs_init(struct amdxdna_dev *xdna) +{ + drm_debugfs_add_files(&xdna->ddev, amdxdna_debugfs_list, + ARRAY_SIZE(amdxdna_debugfs_list)); +} diff --git a/drivers/accel/amdxdna/amdxdna_debugfs.h b/drivers/accel/amdxdna/amdxdna_debugfs.h new file mode 100644 index 000000000..e742a81fe --- /dev/null +++ b/drivers/accel/amdxdna/amdxdna_debugfs.h @@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (C) 2024, Advanced Micro Devices, Inc. + */ + +#ifndef _AMDXDNA_DEBUGFS_H_ +#define _AMDXDNA_DEBUGFS_H_ + +struct amdxdna_dev; + +#ifdef CONFIG_DEBUG_FS +void amdxdna_debugfs_init(struct amdxdna_dev *xdna); +#else +static inline void amdxdna_debugfs_init(struct amdxdna_dev *xdna) {} +#endif + +#endif /* _AMDXDNA_DEBUGFS_H_ */ diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.c b/drivers/accel/amdxdna/amdxdna_pci_drv.c index b50a7d1f8..19866dbed 100644 --- a/drivers/accel/amdxdna/amdxdna_pci_drv.c +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c @@ -15,6 +15,7 @@ #include #include "amdxdna_ctx.h" +#include "amdxdna_debugfs.h" #include "amdxdna_gem.h" #include "amdxdna_pci_drv.h" #include "amdxdna_pm.h" @@ -319,6 +320,8 @@ static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id) goto failed_sysfs_fini; } + amdxdna_debugfs_init(xdna); + return 0; failed_sysfs_fini: -- 2.51.1