From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48174243951 for ; Sun, 31 May 2026 09:12:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780218762; cv=none; b=MZae7ulc4USb9xu5XJwRqgjAMMDOsSr2RXVvNjryEkxKJeMFUTVIQqRo8AFQbS0LZnobatU6yILKIEAx0LVb1kepCygWpnhsYd+87dGbc4sqoZdSqIxw/uzVLX5zvuZkpDk3WBEpSKF2vx8/so/R3FSEVMpFAZZ9LSCU49hQRKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780218762; c=relaxed/simple; bh=GtWMjgWA4XR7ByfF2eq+aSGrsmcmeBHRweSqRyAgCGc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fValaSiY0Uv4kbqWHTF36sva90GWTgfO4Qalnfwyv7J0/jpSLqXufy1VtI/l2O7SWn+A/JV2SjYfDiaWzAF2IRFvhX2zVeMGd8dpMovlJCffMPu/I17cfF8ohTJkRv/o6RGLwUU1sThmK10Q5ChFhLSu30kD+QAXZnimcY1QJ4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ayMuswFf; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ayMuswFf" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49050bfe053so58612345e9.3 for ; Sun, 31 May 2026 02:12:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780218760; x=1780823560; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=DLV/vlYx4oGCZhyGn9UGnBK8+0cqBecf0ZxhiQjsrL8=; b=ayMuswFfQDL5u6RSHtpTCOLwK/KiXK4ouSKHihZEUlQEBGrwMy6oBGFjsRr1tKPbVc XWz1r0dMujZbA/HkyxUNma49Oo6V4uIiMCzMgOtNrxOliytRx/Xjx4sjCPDPuLLphbYW xmDBB6yMZk2rEIkiurRXPHpGQT+LSAprQUPstNTcC3F+lD8JBG7gMryHKUa/zP8KcH6H cKRliEv2QMkdCzDhZVgy/l8Z0+Q6GLeHzXnH8KUoizPHW31hQW7tYmriZYhVPo49Gwn/ 69xJq5Jo39EOe/mcKw2mpgYguyzulKMF+lbpuNh6jWjrtpEoHUYWnrMj2qYfr2S0lMjL ThEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780218760; x=1780823560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DLV/vlYx4oGCZhyGn9UGnBK8+0cqBecf0ZxhiQjsrL8=; b=hYVUoicY8CBt8v7Ohw5+eSchPdCwwGPyp/UJaaUrmZPxirohYhS5zkI4E/pk6LbrP9 0kwdO5KDbeEtkMFs8IvrS9CI3e9hWMTphRMb20aGpJG0sBe2nFPAY8aIEpkTwCnHKWM+ W8nmxi/o1tkk4rSEVJKVB3w9xLqXZxvhD7T0ks4+ZpZDcUGFRYw9uQUDaQ/K2j8UZB4V TuVnCvIUx7wwR7G69IUJoGxgjtHnzsUHTz2gFr+IC7/clY1f+0+DDZGWiJ6hP8WTbQo8 2C0B4BlWmX/n5rcLjMMCEjRnOHJ4QkAHBIasyXnAlcTSe/sFNWS4KMGsA/aI5YNu6K/W dpcw== X-Forwarded-Encrypted: i=1; AFNElJ+sxYdVn1zlbSiIlDud3OKpkaDcLt/kJBO4y3o0BDz9j7uQhZUJzKriUmyr2kNvo/wIKFIFCx4wyckb/Fk=@vger.kernel.org X-Gm-Message-State: AOJu0YycB1zNfRm1LQ3lCf4R2rMXyklcw77HsVJYzyCbr9ytR810radl +pxzMd1v5sGg6I/uQFnhOn6whuLZ8r+T2JB6yADRJ72ikzIBRMaOi/wD X-Gm-Gg: Acq92OEED+Y4r1HhDjOhis8uRGiASWoH3OxNPZ2Kb0fBjVAbVNjoUw743yF/0v/UqCl /7lFPYqTggNOhB/O/k2Ue3wnecmJdzDeYm4QtLQC4iqKW8oG1DIcNDkF1j0ifdlXenbn1aZPK1U 0Eh6+snaISRcFRXbhZG6ySHIHQ8PgRLVcTNPV0U7LMWEiPIsVx2+4PD3uRX+OrIdgj3riFS2g2L imwAhy7EBbFz7RBAGsHds67vyWfK90x2akQUC6Viun7j9P5ugS5Op59xLTiRpQDd8A4E/Ju2ZMw zDIWmcNLxLH/lEqGDxvP4yUkjeJVmtLyuib8NBFX0iyBCOLAt/1IstziV9SHk8yeigjMZpHe9eB xVStw5X5BZOdNoDOMQfbu7T3mq5pjEkNPGiDWDNKk6XgfAahyD6Qau4yeGZ8pi3UB0FiJzIRXLp pCliNX7lfw+V1KXUYSAOZ57DRHvf5aags7a2eQWvLV8qI/2at03AAUCUOuJ/WZcfgm+0yPa3I= X-Received: by 2002:a05:600c:3487:b0:48f:e1ac:c94f with SMTP id 5b1f17b1804b1-490a2918103mr129996915e9.10.1780218759434; Sun, 31 May 2026 02:12:39 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d6f3612sm168254415e9.12.2026.05.31.02.12.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 31 May 2026 02:12:38 -0700 (PDT) Date: Sun, 31 May 2026 10:12:37 +0100 From: David Laight To: Manish Baing Cc: jk@codeconstruct.com.au, matt@codeconstruct.com.au, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mctp: serial: replace memset with zero-initialization Message-ID: <20260531101237.13c5580d@pumpkin> In-Reply-To: <20260530224646.160777-1-manishbaing2789@gmail.com> References: <20260530224646.160777-1-manishbaing2789@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 30 May 2026 22:46:46 +0000 Manish Baing wrote: > Use empty brace initialization (= {}) instead of explicit memset() > to zero-initialize stack memory to simplify the code. > > No functional change. Isn't it also entirely pointless? -- David > > Signed-off-by: Manish Baing > --- > Changes in v2: > - Fixed a compilation error caused by a duplicate variable declaration caught > by the kernel test robot. > > drivers/net/mctp/mctp-serial.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/mctp/mctp-serial.c b/drivers/net/mctp/mctp-serial.c > index 26c9a33fd636..df721ca4e07b 100644 > --- a/drivers/net/mctp/mctp-serial.c > +++ b/drivers/net/mctp/mctp-serial.c > @@ -536,13 +536,12 @@ struct test_chunk_tx { > > static void test_next_chunk_len(struct kunit *test) > { > - struct mctp_serial devx; > + struct mctp_serial devx = { }; > struct mctp_serial *dev = &devx; > int next; > > const struct test_chunk_tx *params = test->param_value; > > - memset(dev, 0x0, sizeof(*dev)); > memcpy(dev->txbuf, params->input, params->input_len); > dev->txlen = params->input_len; >