From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433AB375F9C for ; Mon, 1 Jun 2026 12:14:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780316048; cv=none; b=nXpid5dlsfLpjHcp55Nf+8QY4t7q9V/Hq/php/osviiboAtAjmvfm3pirjT/8DPVaTWwIAsjZ33xgvVAB7LOwy0ZSpLenXIT2CPurmvstXPdHcHwEvoFt+kO2GZw/yI7JyuY45jfGGpEG/FkEs0mtcu69OoSomXlnOdKnJkwKUo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780316048; c=relaxed/simple; bh=a0Eab8DL9emIRfV+k0U1fyr10lxlZo6PH0bm7czUA9U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SXxYUvA/ea78k2oopyMdIaYxOvDz9Ztt058V0XB3sDw3k2450npdYMdZyDqi7kpj4k0wOLY5jjPtdZqqet722I5w9yRptqYod6jNWIFdgEtXJgtL5okmzlwA5uw8mDuHgrCGepZxw5G+R2xMMv1oeoZ3FqXek0z+tHxDU2NV0jA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EIQ7j22F; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gd+f7evV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EIQ7j22F"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gd+f7evV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780316046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8KJursan6RFIgVpOy+Z9gGHMveIQA3OyIKn2aH7TFTw=; b=EIQ7j22F4rRPnT7JrUNf30NgP3S9zCGN77BMgy2+kxJTZMeMsaM9iYJBmgbm4Cy8BrjgT8 joM99zhMElIWV8GGGjFC1hLd4rM5FewpaviVtX27ozMF8oBfyixfJfmRocHJ839oaU88T4 aVHJ1Z6xTD/mmAFUHFncmKpKQtoZ+t8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-lTOcM840Py-NLbXgvs_JRA-1; Mon, 01 Jun 2026 08:14:05 -0400 X-MC-Unique: lTOcM840Py-NLbXgvs_JRA-1 X-Mimecast-MFC-AGG-ID: lTOcM840Py-NLbXgvs_JRA_1780316044 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490a7aeaddbso10002055e9.1 for ; Mon, 01 Jun 2026 05:14:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780316044; x=1780920844; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8KJursan6RFIgVpOy+Z9gGHMveIQA3OyIKn2aH7TFTw=; b=gd+f7evVdoK6QWZ/Sh79izmHFBrzsMsv1UEx1961gxoRdlhRnO7u36IIn7/W4JZS9Q eiAHnnDWAEzxWjuAhOTuNbi01UHEJMQJhtQwDYpSXISlldbMc4PZTG5RGoJkpvxpNcKZ dNNK5jRmtiAMrLzU4M2spl+OMBT2PggdZrZKZ5ft7S/V+w+1kq6Cp1QSRsreKmuUphdN 7/Ej3e9ZtWlEDga432akMyokPw2P9mhKESNlYB23epOQm5zU0XSKs5Vo0ojN3ofPsy1j 6KtV2xaD32IKeR6wAQgcVv2cYfrBoKapBMmNTZ/MECxjeYYXIezaWdy1VzVMYzkS57U4 39EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780316044; x=1780920844; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8KJursan6RFIgVpOy+Z9gGHMveIQA3OyIKn2aH7TFTw=; b=eIkll9KJPnRVyn1uZWoi2+KB0hqoS0uMwR0kU+BKuQ79lLqqSssDssS66CDWHsTbOe eKe1yhl9GACS5KKoem+OzSPTM1usM5AkBzjCvJpV+xkBj8eTQ98kWnjl4pkt4DdVJsca 9PJYaLS9ZNWBCVbNXeFknT7Sam4LFopB0hOe/nnFni374t1c9ZuZik0AeJmuyzOfho0+ RWj2iDg88+oOsC8b+72ik4WBystmIIuSBw7rBcwaWzhuTYuEguvogXlGC6OGFB829I9h Di0Bp+fumZba8DuCLqZsj8Ob8ke1gVIzwV0Omyoscb7W3g6umcSMob+3HzgKYLQyxX9/ MZwA== X-Gm-Message-State: AOJu0YxWpCzr8+Bwl13CJu0IALsVa/kDD9dLaYW7jq+VTrtRXRY/SuzM VjX9MqcQEmBXHFydSzvBwNgkHg2F1XVTOWSiCXeFGTAITVdHwouwuQMsNTG0fPNmHyshqskOW4x 0kMI22wImy/PtXUqdimVIGsoBXGc9KwAWJmypyvutdynzFzokw9z8usBQFvZr1MquCjr90tUlmH gGj7BPsvY81+c31VTFh+yWYs347Pc/RgB0En4cosH/A1o= X-Gm-Gg: Acq92OHOfVv2o/q8RNa/mS8oVM70prpY7H8+t5J0umuCPRgjSScTjh3aIHkW2HGUtLE g2VaDy/f0VneniFlqpqkxercBBU2bPQ/E+glmm4Jf5aXuumfZgIX7/dQH2wuT0JfokdIbhaLcH2 osMAjjT6QlZJnGFDZv2Tb8x2d+JFhuJJOtchEyGxfV6Snm0zkXFUiOBkjS6U5Nnwb9S1TmdVuPb jEtgfFOVJBp2tY7H5w5b26LieXlvO1f2TkVHCShgAseOwlDpgKgSsRtEe27DJrCSxy8unSoyfTM VQfN9t+F2N543vpgD21wCJKyCni4hivyF/I0ZaNo2QiAWMmE7b3x1PEoXdjw+SIJFsgJeUBll8h ALCsbdl4wGGjoCB/MIbAmFwW339zGlNJ49N2buLVNGqaP6D1CEhsJRQ== X-Received: by 2002:a05:600c:3e8c:b0:490:3d48:6cb9 with SMTP id 5b1f17b1804b1-490a2a02b06mr143723385e9.3.1780316043819; Mon, 01 Jun 2026 05:14:03 -0700 (PDT) X-Received: by 2002:a05:600c:3e8c:b0:490:3d48:6cb9 with SMTP id 5b1f17b1804b1-490a2a02b06mr143722365e9.3.1780316043140; Mon, 01 Jun 2026 05:14:03 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c053029sm75910015e9.0.2026.06.01.05.13.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 05:14:02 -0700 (PDT) Date: Mon, 1 Jun 2026 08:13:56 -0400 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v9 00/37] mm/virtio: skip redundant zeroing of host-zeroed pages Message-ID: <20260601080712-mutt-send-email-mst@kernel.org> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: I went over sashiko review of this: https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com It's mostly Sashiko apparently not seeing the whole picture (e.g. is says "an optimization is missing" and it is actually added in follow up patches). Sometimes it is unhappy while there's an explanation right in the commit log. Weird. It's a pity there's no way to respond to the review, to make it pay more attention and reconsider. It did flag a minor rebase artifact (declaration landed in the wrong patch during rebase). Mostly harmless but if there's a v10, I'll fix that. But it also flagged 4 pre-existing bugs: - page_reporting_register before DRIVER_OK, theoretical race in virtballoon_probe ordering: https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=4 - spurious OOM on large-folio swapin race in do_swap_page: https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=16 - free_huge_folio called with refcount==1 on mem_cgroup_charge_hugetlb failure: https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=20 - double-decrement of resv_huge_pages in memfd_alloc_folio error path: https://sashiko.dev/#/patchset/cover.1780067977.git.mst%40redhat.com?part=21 All seem unrelated to the specific feature, so I'd rather put off fixing these until the feature is merged. -- MST