From: Jacob Pan <jacob.pan@linux.microsoft.com>
To: Mukesh R <mrathor@linux.microsoft.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
mhklinux@outlook.com, wei.liu@kernel.org,
zhangyu1@linux.microsoft.com, schakrabarti@linux.microsoft.com,
jacob.pan@linux.microsoft.com
Subject: Re: [PATCH V1] iommu/hyperv: Create hyperv subdirectory under drivers/iommu
Date: Mon, 1 Jun 2026 21:45:14 -0700 [thread overview]
Message-ID: <20260601214514.00003833@linux.microsoft.com> (raw)
In-Reply-To: <99bc22c3-0fa9-044d-071c-53cc8c2b7548@linux.microsoft.com>
Hi Mukesh,
On Mon, 1 Jun 2026 14:23:18 -0700
Mukesh R <mrathor@linux.microsoft.com> wrote:
> >> diff --git a/drivers/iommu/hyperv/Makefile
> >> b/drivers/iommu/hyperv/Makefile new file mode 100644
> >> index 000000000000..0053e00e08e6
> >> --- /dev/null
> >> +++ b/drivers/iommu/hyperv/Makefile
> >> @@ -0,0 +1,2 @@
> >> +# SPDX-License-Identifier: GPL-2.0
> >> +obj-$(CONFIG_IRQ_REMAP) += hv-irq-remap.o
> > Should the name be x86 specific? This file will never be built for
> > ARM because:
> > CONFIG_IRQ_REMAP depends on:
> > depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI
> >
> > perhaps, hv-x86-irq-remap.c? hv-irq-remap.c sounds like a
> > generic Hyper-V IRQ-remapping backend and may be misleading once
> > arm64 Hyper-V IOMMU/interrupt support grows under this directory.
>
> we could, but looking at early version of hyperv-iommu-arm.c, it looks
> very similar, and so if there are very few ifdefs, we could just
> keep one file rather than replicating bunch of code.
With this patch as is, how could you keep one file for both ARM and X86
where hv-irq-remap.c does not build on ARM?
next prev parent reply other threads:[~2026-06-02 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 1:41 [PATCH V1] iommu/hyperv: Create hyperv subdirectory under drivers/iommu Mukesh R
2026-06-01 16:07 ` Jacob Pan
2026-06-01 21:23 ` Mukesh R
2026-06-02 4:45 ` Jacob Pan [this message]
2026-06-02 17:22 ` Mukesh R
2026-06-02 19:20 ` Mukesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601214514.00003833@linux.microsoft.com \
--to=jacob.pan@linux.microsoft.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=mrathor@linux.microsoft.com \
--cc=schakrabarti@linux.microsoft.com \
--cc=wei.liu@kernel.org \
--cc=zhangyu1@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox