From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A45C3A872A for ; Tue, 2 Jun 2026 06:59:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780383550; cv=none; b=CLGyNW18zgwGQggOwnvItPP9BDOOwAGI58Xz1enNMmz8F/9sqbisulqnhEekS8GmBOIQR5aHOyTN3WxLewHuXyxleEEXu4HO+Y7WXbS3stXvA4iU7hhfe8W6F1yWYKKonSb09GYtGuhOwSli3cHYovc/Kt5Exu+osuOxTXQDvqc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780383550; c=relaxed/simple; bh=pIG+06FZ/DHgNH53/jtFSdUrNB+urC7R94mgI4vNJ74=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qYZB/DZlHnL4l76iV3zyMzVgoYT0d4OsPRZLs0tDW1gBr1BNf7b9n3xjw0HpX9NzfSwzDqSBH1Da9aQyGKj6MUBlvJQME9HpgKzP8LEQ75ALv/1fpXczKaLycyGgq7Q0h4aOMSPf4Rs5QAhZ1X+QnaTfMvtmRdl3yoiPZv8xGqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I0P6STlL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kjDcfxO7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I0P6STlL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kjDcfxO7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780383548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sS40ddYhC+PZ+IYRQdjSjQCwzQHh2ypnu3XDzP5dhIM=; b=I0P6STlLviVIyKrqoLD3qNloC1b/ffTAW+3ofGrsS0rXTeh8TkVlaTGcLyhYSCXXqM0dQz fzY3c7IVI5drpeSocBPHwkMHQCo+4HWDvBWe5SovQ19qLNhvpnwoACRav2asPzERsFpH1y jAdP3MkmaHUqOcUUndZRvZlf+sp0y9s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-_9UjeF0yP9K8IwDN4bBezA-1; Tue, 02 Jun 2026 02:59:05 -0400 X-MC-Unique: _9UjeF0yP9K8IwDN4bBezA-1 X-Mimecast-MFC-AGG-ID: _9UjeF0yP9K8IwDN4bBezA_1780383544 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490479c2911so112889325e9.2 for ; Mon, 01 Jun 2026 23:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1780383544; x=1780988344; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=sS40ddYhC+PZ+IYRQdjSjQCwzQHh2ypnu3XDzP5dhIM=; b=kjDcfxO75/mqeuWsbVe8Lhi+zadL0ps8Byv2AmEhboil6y9mo3l+LtKIAnz1GHxux/ Z5nyjlUq4sqtBI4ZPqh5Q2XCWFMosg7fqOQUf1ElQNN7MSFviJFmWCmQSs9Nn4RtW8P2 eydgOtm+g+S2LA38NWt2VJApU2o0K81vchsCpq5ssYO3Y7qxBdKirVYSj23ySn1y6Jkj hS4FNxN9IvDNaJMgoFAu/p8/ebsfx6Bytke6cm+Xow6kvGxtODRQIZz5rvmiLu4jQE19 ofgxlcSh9lSlK21NLYJ/m6BnhIM9iln08nPlSrMCBoETUej7GTv6fK74TZ6EGI0rg0vs v+1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780383544; x=1780988344; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sS40ddYhC+PZ+IYRQdjSjQCwzQHh2ypnu3XDzP5dhIM=; b=FaVfSpI7uqoq37pXpA3TA7gB6sPoQfuOpEewZ0Tw9Yi9DrUGkTqlPxt3lh462AVDs0 BgnygOWPSwzEyZ6Bq9Sm1X6Y3QfiW2jmIBKYeoMKr1hPtLM01HtMAIriLMpcl8/u+8Y0 V97+KwTp5fVElrIAMW0CmO/5TFv70UfJri0i6E4Neys6ye8hznHRJa5Ur/nIlZDYUqao H2t5sO9ozdGi6DbCKi4Of6LIKyDywCVCVGtQ9t8TAFff5u7+6Xquv1MXrxcepRO7oUTj crcNZ3Oh7hHBDX3XKAK8FMZeRVtF9aEDmINK021fHYYeF5u4kSUZv+KF1iJKAlgYxApP oCYg== X-Forwarded-Encrypted: i=1; AFNElJ+LmSBJAq0Pz2QQYfPGfA8jm0O4wNA3ukOArnpvpLKsQwT8a4hM83bvjdF4L/yD/K33Nyj2r0G9Q5us9qY=@vger.kernel.org X-Gm-Message-State: AOJu0YxEaTlJX2wSrAZnambxqPezAJO++E+FnCC1YQ5pvcugOT65hZnF V8UZugxdUOZ0vPs2lav9ck7XYPE6kpfHvw8AiOREjEwG6rmGidMi6Nqn9xmhVB0PnSKYFOND/xt 4W25ukzLP6kptO8fArsn0veWc27F6WlZ7WV+7bLiv/lage7rJm7u+A3U35IDstTXyaw== X-Gm-Gg: Acq92OFYOexQvCKH44VNqSmFuLZPZc1rzjzrl8xL1GehsqrouAL6RI5c+AbJGq66siG A0TdNog/YC3fK1ErAP/Kr5VeJfNh2Tr0jNmnZv/ZpsBWTzNagiHY7bZLxYvwgersaTLm3wqBHzm t3RYvFoe3Ssjd6AOAFv4QCHqmdfO7bWExkGH1qH5RK8Z4vhOv7PP3Z1d/4i55XWjjrCzu+XHNhi n7Gze5YOTv8vaxCGFUCp9hPqDpuWzO6/ubysrcu2wrnFalzDyvsQHmbJ7tck5NNd+ZWhD+F7e9Y 93qBN+lTmamSeydkFGEiGzuF41LIckpxkb0FAoAKTxDF3AfKxTdvXs5Ll/I9wbH6cQXquPtkzYW keS7MjwlJn5dOT1tN0dH1JR/aUtNLVwbHkF5oQBGKwiKAa1/x8C3hqQ== X-Received: by 2002:a05:600c:2d47:b0:490:6869:46c3 with SMTP id 5b1f17b1804b1-490a2961e9dmr166050165e9.30.1780383544025; Mon, 01 Jun 2026 23:59:04 -0700 (PDT) X-Received: by 2002:a05:600c:2d47:b0:490:6869:46c3 with SMTP id 5b1f17b1804b1-490a2961e9dmr166049925e9.30.1780383543573; Mon, 01 Jun 2026 23:59:03 -0700 (PDT) Received: from redhat.com (IGLD-80-230-25-45.inter.net.il. [80.230.25.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909c09be7fsm93880255e9.7.2026.06.01.23.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 23:59:03 -0700 (PDT) Date: Tue, 2 Jun 2026 02:59:00 -0400 From: "Michael S. Tsirkin" To: yangjiale Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] VIRTIO: Update the desc 'flag' fied last in packed ring. Message-ID: <20260602025834-mutt-send-email-mst@kernel.org> References: <20260602043123.10207-1-yangjiale133@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260602043123.10207-1-yangjiale133@163.com> On Tue, Jun 02, 2026 at 12:31:23PM +0800, yangjiale wrote: > When a descriptor list spans across cache lines, > updating the flag first can lead to a scenario where the device side > perceives the flag as valid, yet the corresponding address and length > fields remain unupdated—resulting in invalid values. > Therefore, the flag field must be updated last. > > Signed-off-by: yangjiale > --- > drivers/virtio/virtio_ring.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index fbca7ce1c6bf..036b4f90d30f 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -1688,6 +1688,10 @@ static inline int virtqueue_add_packed(struct vring_virtqueue *vq, > &addr, &len, premapped, attr)) > goto unmap_release; > > + desc[i].addr = cpu_to_le64(addr); > + desc[i].len = cpu_to_le32(len); > + desc[i].id = cpu_to_le16(id); > + > flags = cpu_to_le16(vq->packed.avail_used_flags | > (++c == total_sg ? 0 : VRING_DESC_F_NEXT) | > (n < out_sgs ? 0 : VRING_DESC_F_WRITE)); > @@ -1696,10 +1700,6 @@ static inline int virtqueue_add_packed(struct vring_virtqueue *vq, > else > desc[i].flags = flags; > > - desc[i].addr = cpu_to_le64(addr); > - desc[i].len = cpu_to_le32(len); > - desc[i].id = cpu_to_le16(id); > - > if (unlikely(vq->use_map_api)) { > vq->packed.desc_extra[curr].addr = premapped ? > DMA_MAPPING_ERROR : addr; Good catch! And presumably we need a write barrier then? > -- > 2.25.1