From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: John Crispin <john@phrozen.org>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 4/4] net: dsa: mxl862xx: add support for SerDes ports
Date: Tue, 2 Jun 2026 14:22:09 -0700 [thread overview]
Message-ID: <20260602142209.740b18d7@kernel.org> (raw)
In-Reply-To: <2b57a3d73519a4be8f45252707c335ecd251b2c1.1780032869.git.daniel@makrotopia.org>
On Fri, 29 May 2026 06:40:17 +0100 Daniel Golle wrote:
> +struct mxl862xx_xpcs_pcs_cfg {
> +#ifdef __LITTLE_ENDIAN_BITFIELD
> + u8 port_id:2;
> + u8 interface:6; /* enum mxl862xx_xpcs_if_mode */
> + u8 neg_mode:2; /* enum mxl862xx_xpcs_neg_mode */
> + u8 permit_pause:1;
> + u8 usx_lane_mode:2; /* enum mxl862xx_xpcs_usx_lane_mode */
> + u8 role:1; /* enum mxl862xx_xpcs_role */
> + u8 usx_subport:2;
> +#elif defined(__BIG_ENDIAN_BITFIELD)
> + u8 interface:6; /* enum mxl862xx_xpcs_if_mode */
> + u8 port_id:2;
> + u8 usx_subport:2;
> + u8 role:1; /* enum mxl862xx_xpcs_role */
> + u8 usx_lane_mode:2; /* enum mxl862xx_xpcs_usx_lane_mode */
> + u8 permit_pause:1;
> + u8 neg_mode:2; /* enum mxl862xx_xpcs_neg_mode */
> +#else
> +#error "Unknown bitfield endianness"
> +#endif
With the bitfields and MACROS for read/write this patch give off vendor
BSP more than upstream code :( Doesn't look like the driver used
bitfileds before, please use FIELD_GET / FIELD_PUT
next prev parent reply other threads:[~2026-06-02 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 5:39 [PATCH net-next v4 0/4] net: dsa: mxl862xx: SerDes ports Daniel Golle
2026-05-29 5:39 ` [PATCH net-next v4 1/4] net: dsa: mxl862xx: store firmware version for feature gating Daniel Golle
2026-05-29 5:40 ` [PATCH net-next v4 2/4] net: dsa: mxl862xx: move phylink stubs to mxl862xx-phylink.c Daniel Golle
2026-05-29 5:40 ` [PATCH net-next v4 3/4] net: dsa: mxl862xx: move API macros to mxl862xx-host.h Daniel Golle
2026-05-29 5:40 ` [PATCH net-next v4 4/4] net: dsa: mxl862xx: add support for SerDes ports Daniel Golle
2026-06-02 21:22 ` Jakub Kicinski [this message]
2026-06-02 23:11 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260602142209.740b18d7@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox