From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09869318BB8 for ; Wed, 3 Jun 2026 19:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514368; cv=none; b=rz7qyb0EtaC5jo883mBjQxoMZKRRXHau3hYGAi0aQZL7dCjXugS1ECWQhUrdW6ygV4ypYt31WujIQ7LSA+6xE7PwxIgIIvasSVYFSI2dTVDH1PTFi4znSKMFeBIvJ9bUYxxpOtGh8ppxs9mc5J9meYpJl7i1r/Z0jbyF7Ot0F58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514368; c=relaxed/simple; bh=8JlQmKyS3DE1T02n2KBXLIJQZrrxUv2tK13RROIA0VQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=puxPAZeXOKVgHsm2k0Uw4OJhinVh3GMnELMrHtMTqNYQh26F1p41UV8deenz6PlKRwgXrgAGWutaza6Ck+AmQ1vv6SwS2yHJbcY2ARNj7lgjojhgOVmeFoV2vZL095ttGCCfZOmK7VzT5JyfozHMhouWb595KkmvIK9YBMZtmjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OGh0YWNF; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OGh0YWNF" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36d8b644473so4244790a91.3 for ; Wed, 03 Jun 2026 12:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780514366; x=1781119166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ks8udlxWFVFor68V8OzfjcCN4g9WTq8BGgBOKtU3NBQ=; b=OGh0YWNF/WVAusfT4qoVrBRvKfqP9DlGoYOSpMPTvnVRZJrTselfocWC8wOVD0crQa pb+BOeBXm4EcuOBi+ZJrNJX/trHXjYjSpZW+DHoZ6mVUvisgDIFhYbHP+Fcv8f0whKk3 KxveXyxTyE5FAeU30tUR1xcutO4Cs2w5hoUmBFRHX/JoRVu/eBGnwg4UaeYFnx1Xi9lw Iea+MrjVRTps3wQ8xUWRu56YGC7HcRki91tkYydj/IcqkDh2rAFbt5HbfcAmfMG7TNy3 nJ95yM0TWsL3OMYp6Z62xAnNzNwg26gaPuhb/YNgL2bHGUctlGyy6WRBP0rGr1p3SOQe nXVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780514366; x=1781119166; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ks8udlxWFVFor68V8OzfjcCN4g9WTq8BGgBOKtU3NBQ=; b=Elscwa67mfAMzxMOhXMK3++CZG2XMxuwHRY3mA70q/tIi05bjixHCTD0sTp8NJqhGB m5mrRzn8S4ZajdEIRcl1vZaUjO+hutZaHuyAGZrsvp0GCEg1FjGwlUtSmhbuPrVZPZGd CJwjsfGcd6N6XXYZWTLONsAzlwIN34mqR8VBMZYQ2/UxAi5KdRsuutcKlpDrSj0qU65O eN7g1VH8DFA7CzeMVfuybmw+YAIm2PNFhjU/x6z9sLKeUemH2uCfL6k4uU0oN0mR5Pcg yk77hYI2ZVCfgKMb2J76hXdRAg5dWgTJL5re7eLbzAMKCDVNefxPVeHxFwDVYHtgRxCn sddg== X-Forwarded-Encrypted: i=1; AFNElJ/bPahJUuHh4dUvOccL8QAlqIlajlJu1ypVIUnTIlmKEwurHxkMQKxLS1XjOwVc8JwrbB6fg4/JHoSFtFc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl8yYN2+9LDNSbUZeAAPKHyqIly7TlN4LySEu27h8eAxe8vu4z 3vccuP8PTmunLRE6jyiVrYpMdgTrJtHLu8rXyXlCY15OzZixkYaenBiA X-Gm-Gg: Acq92OGC5WmQi9ZUqZz/ALqAY3ryHSMSH+N6J5UGgGrASLdW4amRgPc5hQr/LmiZ9Ql 3VdTsx3PJF3AWUaGlGTmVWDWZbTONuTdvJd5YhlqX4V3sP2t6hyLTMP1HclAb4Pzrk9AKj238A4 UP7KXU/z1bJJJ9Py4LlAUS4+n7bEDG+EGCAWY1IhHfX5+5TyaLKW/5MtY8bGYuHtmy9ZQnsKlV0 wGzzKCScHr/vLucl1TVgsUuZrXefwd5Nc9HBiHzmobORz7bQJpKb0Bss88HJWerPSScD/Z3nCP4 /f1yEAuWnbBWBL8wM3JzJefU12yPygY2JzMOcywW6dnVr9lI+jcN3aEhpia8pRqcKarULW9KmM/ 38Zu07nCNs0x6+3eWoXu9E1ODxjBISfS5UcOlRtFAmx3C8AZKSGRAjkHVBBpbN7Px8xAzL6/Fq4 szEC5iDcD45Zztncv5wlCrxIlMocXXnU1tJ/BG3qerPj7qcOF6P25ZV+E6gduCN+gZ2AQYbZqOt xMIh+JyX3XkwDaa6yKiXDTd5Wy+KBJeMqLfQ4MThX9kQA== X-Received: by 2002:a17:90b:4b86:b0:366:52fe:e749 with SMTP id 98e67ed59e1d1-36e2eee0226mr4501646a91.5.1780514366160; Wed, 03 Jun 2026 12:19:26 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6dba8573sm527656a91.14.2026.06.03.12.19.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 12:19:25 -0700 (PDT) From: Rosen Penev To: linux-edac@vger.kernel.org Cc: Johannes Thumshirn , Borislav Petkov , Tony Luck , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt Date: Wed, 3 Jun 2026 12:19:08 -0700 Message-ID: <20260603191908.5618-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use platform_get_irq() to retrieve the interrupt resource instead of directly parsing and mapping the OF node via irq_of_parse_and_map(). This is the standard pattern for platform devices. In addition, platform_get_irq() returns a negative error code on failure, which is now checked. Since we are no longer using irq_of_parse_and_map(), we do not need to call irq_dispose_mapping() on error or driver removal, so remove those calls. Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Rosen Penev --- drivers/edac/mpc85xx_edac.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index 277f1c6bd522..f494d922c6a1 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c @@ -555,14 +555,17 @@ static int mpc85xx_l2_err_probe(struct platform_device *op) } if (edac_op_state == EDAC_OPSTATE_INT) { - pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0); + pdata->irq = platform_get_irq(op, 0); + if (pdata->irq < 0) { + res = pdata->irq; + goto err; + } res = devm_request_irq(&op->dev, pdata->irq, mpc85xx_l2_isr, IRQF_SHARED, "[EDAC] L2 err", edac_dev); if (res < 0) { pr_err("%s: Unable to request irq %d for MPC85xx L2 err\n", __func__, pdata->irq); - irq_dispose_mapping(pdata->irq); res = -ENODEV; goto err2; } @@ -596,10 +599,8 @@ static void mpc85xx_l2_err_remove(struct platform_device *op) edac_dbg(0, "\n"); - if (edac_op_state == EDAC_OPSTATE_INT) { + if (edac_op_state == EDAC_OPSTATE_INT) out_be32(pdata->l2_vbase + MPC85XX_L2_ERRINTEN, 0); - irq_dispose_mapping(pdata->irq); - } out_be32(pdata->l2_vbase + MPC85XX_L2_ERRDIS, orig_l2_err_disable); edac_device_del_device(&op->dev); -- 2.54.0