From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF89B315D58 for ; Wed, 3 Jun 2026 19:24:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514676; cv=none; b=nXmU1evh1TsI76FRoR97fNOHgLcb2QU2BbGCmrpGMk/2wxYo05D/LTv5UKbdRmYRiXh00cNEZBMZJ7CQONAX6/atO3AQZLXiXVQHAI5iQMpbkgIogvKIfrTtZR+V8FrKMP+POcYDJ+zXp/9HThF2RbyAIQ7kF2hFDQ/3e4TRh3c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780514676; c=relaxed/simple; bh=krNcY8aGkY0R9eiNm2+dNi/C+OFvcaJVgMnP4s96AgI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=XYdJwlnE2SeFtL7thQ5z6iadhRXlHvYbQyifB1NPJqrdaKUMBWzxupIuuCFiHoO/0i42bGPACYvxIISWkLkaIdWqWTakUVcWEIbV52hZvPYNrlAiYJwc237E4/9jq1XnQpiG3+Y6FxPjiHZDziTufudxu02GmSawOMHV0IGSP8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BCtVb/xb; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BCtVb/xb" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-36b9ec98144so4455093a91.1 for ; Wed, 03 Jun 2026 12:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780514673; x=1781119473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=og++R4ahc4AookV77c97mQ8F+3qsfkk1kwm9Se/wnb8=; b=BCtVb/xbsFuOepRbtYjKZpSnMpYa9CF9hkX7JZCRailLBxV/ZN/YMX0uiBY0lyobwB l1cxAN1/vsW2bAtsB1MakDE5s9y/5IZun9A+izR/Hfh88fvbe5ix/gFjd3BViRpqT2zK MgDFeSdb+UA4/vshXGBEXVrXkZTqbgHZohEfsydbb0Uog46pPZkmDqZLYG5WziO2L+JR DEHlFHpGPrFdZ3EJTB0BDkyCKwYFWuyz8K5pGdcG5MEA7R6lak6xmq21ZJLY3SCpviaL 8pnsQ2K+DUL7cR6I5sZf0zHSFZkk2RpBPNMwdYWRsjONWP/Gvw8lVo2hfrdm+aNh/yZB XJ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780514673; x=1781119473; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=og++R4ahc4AookV77c97mQ8F+3qsfkk1kwm9Se/wnb8=; b=Joh1K4hlgQdwi/hgjLhbWlm/HmyLURi7WQn2c4K9qaU9DkpWDRg62uUd4Z5wpuRq0z /PXLtWHBQ8mRaZxHzrXZ0hjcZHZlmK4lh8wca6rhfmcyF6XTRqPOYbSAvVs/ivEUMg5U w+NJMru8iWbiQOlkhpQEHVfujA1++iJYKq27okQPYqOgZ/RsuzEL5bYLa613olN/frCy aWRDBCWa8Ipcp0k1NxaO40UkVNNA1tjBSD7Bmp85hqIw5v+7AQIZrFuf2GmUBCum6qie WYXLHpMBjAS4bcoGLINq6IJHOunE9YFbjWXSwHZ6gEjMIiwm22LqBdNJPYsfYKteVqLC 8RUA== X-Forwarded-Encrypted: i=1; AFNElJ9JzYTLwPLIwuY0AVAnqS6+0rcCfP0JEZV4AExE/UVnuHCPDe/tq6hviGTTEvNGKQdXV7onhITczetDAAM=@vger.kernel.org X-Gm-Message-State: AOJu0YyIvP/baxC8DyZfW1Fg9z86WXy1uv8hnCA3ibLAduRKWn5Jgkwp oE/96zOZ77s/4gpn7BX8N1gBhA4UvrkqmZ7Rkv5l4N3WcmkEIGt1I+g0 X-Gm-Gg: Acq92OFAFHKDgLHEmKYTG9PG8LnUqsa0VEdCZtDJigjBR3Z2rCJU6lH+aTmK7mpptSI aNxZi8Kv/Uw/GF1FVsRtA0V2cq0jDPplncaYVarZ4gat6k67Ai4Se0+Xe6rLTnfGSx7IMfYJIQR L8OVolW6hP/Ak5xMLHGqiM9TBUx07I9X41IQpyPqz09anlrFNdY6A9dHeAZlxe4RMWXspIoyc+J jgWf/059O/TEbxz9Rq8jeqX82rqWWwQQ3UtbosqBUeTy4VzvKkvE2S1olnHfrlg9NqTaxhHH9Vv fIRKJbQXhHvBfti9n7feSLnjk9n7TMIYWpXpVmb8Vtl9Rxn08X9k8LxergPJ++eFjIJtblDYXWE KCBdUPMv6s+gnE1hXkHpJkC/nADQKdhqBI9foLCqJo9Zm4ZPYtHPLp+KVvdC5f+8GTmTRWNS7iP 3aDiE/X+NAqmR5D27nF54PVTgb4TDm5vKDH1lzWKxD3kUK3iA+j8Km1xqA98buiVZm7CcFVWbIp 85tBzNKVWOVYK+MFzbjBWNGeKnAmx0X77riSnD9ixVQNQ== X-Received: by 2002:a17:90b:268e:b0:369:e217:d110 with SMTP id 98e67ed59e1d1-36e3486bc55mr4626797a91.27.1780514673235; Wed, 03 Jun 2026 12:24:33 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6d013c9dsm480326a91.8.2026.06.03.12.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 12:24:32 -0700 (PDT) From: Rosen Penev To: linux-input@vger.kernel.org Cc: Dmitry Torokhov , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] Input: apbps2: Simplify resource mapping and IRQ retrieval Date: Wed, 3 Jun 2026 12:24:15 -0700 Message-ID: <20260603192415.6679-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify resource mapping by using devm_platform_ioremap_resource() instead of the longer devm_platform_get_and_ioremap_resource() helper as the last argument is NULL. Additionally, use platform_get_irq() to retrieve the interrupt instead of irq_of_parse_and_map() and propagate its error code on failure. irq_of_parse_and_map() requires irq_dispose_mapping, which is missing. Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Rosen Penev --- drivers/input/serio/apbps2.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/input/serio/apbps2.c b/drivers/input/serio/apbps2.c index 0aa4ab00af35..5f21acdd4113 100644 --- a/drivers/input/serio/apbps2.c +++ b/drivers/input/serio/apbps2.c @@ -140,7 +140,7 @@ static int apbps2_of_probe(struct platform_device *ofdev) } /* Find device address */ - priv->regs = devm_platform_get_and_ioremap_resource(ofdev, 0, NULL); + priv->regs = devm_platform_ioremap_resource(ofdev, 0); if (IS_ERR(priv->regs)) return PTR_ERR(priv->regs); @@ -148,7 +148,10 @@ static int apbps2_of_probe(struct platform_device *ofdev) iowrite32be(0, &priv->regs->ctrl); /* IRQ */ - irq = irq_of_parse_and_map(ofdev->dev.of_node, 0); + irq = platform_get_irq(ofdev, 0); + if (irq < 0) + return irq; + err = devm_request_irq(&ofdev->dev, irq, apbps2_isr, IRQF_SHARED, "apbps2", priv); if (err) { -- 2.54.0