From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39A1A2701BB for ; Thu, 4 Jun 2026 02:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780540721; cv=none; b=oKUI6cLU+YlJ6X9MPMMWy+/KIa7xZUYTKQVnBqqZim5+vFDSJxGG8bh4Tw6FbDwvgNUr+D3SMyyld8CQPTwFVLb45CGZD0HjRmUDcNRabkXBUMcbYvkHDLnWPGccez6vk5zqagwn/iIYhzkUDEHciVcHJcJpSo1pvM7oES+pnI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780540721; c=relaxed/simple; bh=IgUc5Qe80z/jUGLWABaGxvs/O/OI5c8g7nLD+Ltw+/U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VgM/rI7Jlj9U7Iz1B5vkFxFOz/kzw/8xEQ0IbWoKBB3n0q9k0i7BWRzt1/gFo4dhX/+zfszCkXZQCCdBP7YRuw+vSMcCC/lbTrHx9p+XfJUA6PJnq59/z3kg9fvN7jpBrn27YAOOSvLMyOI/spZ7hBxr72QclEiBmc0d96Z6cP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OV5ez7xZ; arc=none smtp.client-ip=209.85.216.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OV5ez7xZ" Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-36d9794d82aso93645a91.0 for ; Wed, 03 Jun 2026 19:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780540718; x=1781145518; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2Jg2muu/RqGJ6FJ6mWO/tENjNo0VfGXgaATf3xERkFo=; b=OV5ez7xZ4+pLtfbIY+9Sh4ZZrvgdl6KMl/hoiGyTgODYeshxlm5um63dAu8W8k++Hq ZKQjGNITXWaYVZ6V/svj88VYIO8xeSr4peH+YJUYVfss4Xksvy2ZdLaIcsoQvsgSf+tL q1pGx99x2RbWhRAmb1PBOGfAwMhfLTDs4n5NwLwG7vqIHC7+tTKoPjltAHkegByffj3L MwPU6HUkeS7fcUg+pneFcbCSr+xIR/NVttl6nSGH0nyTqgUsyf1VYMfXXk4GVecLMhOa iFPHN0ISO0EcwV07V5LJSUodQDRWHrIuBytNeS+goyYX6FAlj9PbVCSwVUYrRiOYTbEE K7Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780540718; x=1781145518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2Jg2muu/RqGJ6FJ6mWO/tENjNo0VfGXgaATf3xERkFo=; b=j3nZzfAzsKklliMtANgQiqYi5JLbqrMogQSWYJDMMRSn3Ex22vLDtPDcYhy/YD3wzN LQnbDelAiNsmjbIUPvmHGii5eUUWkQEcikTQYoVq5bDgmw+Q5r1PkYE62YEwlMYTZZ26 Ip4VbREadcZh4euV40cdfyqlyS70Dgd7LJhO3CRos3+HqY0JjlJB+X4bq3tw9jYNpAp1 HxsjojtRE5zFRBeSMGxljc1y4SYfcXdmhTU2+LutXhRj5imS1GbEjEn7Vp02mMTF0ZP9 vLKLzelEJ/TW+KV9GdJ6q6o6kxBTXIgDu7IIqcgmZf3es69fPaznd6vKdNyPtVbzqmdg pGrQ== X-Forwarded-Encrypted: i=1; AFNElJ/HBerfFx3gZZfn5oRLYB3se85D2KlxJ8O0Ib4HJdOgtuPrrXr9ngD0iOGXKFFPB1chHU1sabYHZ5xGRok=@vger.kernel.org X-Gm-Message-State: AOJu0YxT5PElf34og4AqORsdwv1tXAeehSLrUTsfBWG+MXywm5C62plO ccyTkQPzarJl3DxP3woRQlpNhK38y0VtH1+UmWH5tiv753bxaMwGIrP3 X-Gm-Gg: Acq92OFcEJi5KWqONLLId76Ju7c+7WeNOiraJJ3tBX6ieH4A/2YoWZ9mah0KxQporMf 9XzpE6/n5vfsK/ec9h8aVzO+c8E4p5OgMWU2KO8Tgzb49mLFN17JuS36JmumShrWSSP32pVHKFz 10cw5VagS5p83SAcNqk8gSqma9svVFYe+5j0EYl1J+K6E2qo8+nUPzacLWQShQrJzhLRGpvDe8a boLy4fxFJXP4w6qmQ54iuWKWYT+jPG24rNvBS/wl4GVu+LlndsssbCa+E1S0b0B4mXjzXGevAQx 5FePOVpMs/fFbm3m38quRZiZ5tbN8VOLs3x4H0iH2BWXWAQhLSP/um9ELAzFkXpXO0LERPyV8OF V5kZUVgH7VxWxJHSK5o9fK/eC5sjyWU1kUbQNWs97C/dEeedqnnFC2K+m0lcpL+8MA1uhDfkigv G6udtuXV4pZyG1VTSXyroQgId/krZETmaTvVL9OzJzT0fvRODnDaAB9uya+Q== X-Received: by 2002:a17:90a:c2c5:b0:368:9da3:c496 with SMTP id 98e67ed59e1d1-36e335db4fbmr6149440a91.24.1780540718488; Wed, 03 Jun 2026 19:38:38 -0700 (PDT) Received: from intel.company.local ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6dba8573sm1253072a91.14.2026.06.03.19.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 19:38:38 -0700 (PDT) From: Wandun Chen To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev Cc: akpm@linux-foundation.org, vbabka@kernel.org, surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, david@kernel.org, ljs@kernel.org, liam@infradead.org, rppt@kernel.org, bigeasy@linutronix.de, clrkwllms@kernel.org, Alexander.Krabler@kuka.com Subject: [RFC PATCH 1/3] mm/compaction: skip isolate mlocked folios when compact_unevictable_allowed=0 Date: Thu, 4 Jun 2026 10:38:10 +0800 Message-ID: <20260604023812.3700316-2-chenwandun1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260604023812.3700316-1-chenwandun1@gmail.com> References: <20260604023812.3700316-1-chenwandun1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wandun Chen compact_unevictable_allowed is default 0 under PREEMPT_RT, isolate_migratepages_block() skips folios with PG_unevictable set. However, mlock_folio() sets PG_mlocked immediately but defers PG_unevictable to mlock_folio_batch(), result in a folio with PG_mlocked=1 but PG_unevictable=0. Compaction will isolate such a folio. Fix by checking folio_test_mlocked() together with the existing folio_test_unevictable() check. A similar issue has been reported by Alexander Krabler on a 6.12-rt aarch64 system. Vlastimil suggested to check the mlocked flag [1]. Reported-by: Alexander Krabler Closes: https://lore.kernel.org/all/DU0PR01MB10385345F7153F334100981888259A@DU0PR01MB10385.eurprd01.prod.exchangelabs.com/ Suggested-by: Vlastimil Babka Signed-off-by: Wandun Chen Link: https://lore.kernel.org/all/33275585-f2db-4779-89f0-3ae24b455a67@suse.cz/ [1] --- mm/compaction.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index b776f35ad020..7e07b792bcb5 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1116,7 +1116,8 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, is_unevictable = folio_test_unevictable(folio); /* Compaction might skip unevictable pages but CMA takes them */ - if (!(mode & ISOLATE_UNEVICTABLE) && is_unevictable) + if (!(mode & ISOLATE_UNEVICTABLE) && + (is_unevictable || folio_test_mlocked(folio))) goto isolate_fail_put; /* -- 2.43.0