From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 730F63FB7FA for ; Thu, 4 Jun 2026 09:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780563975; cv=none; b=rvxJ9l4OPstu8L3nLraW1V81JnOB34hFsj1lQEH3EL9L8iU9ft2wKVs2wjCUqVcDtYBCtgGIqwPfB99cGC3ANP2CcVVcOApPN7I09Y6JjIVZWDFX0dSwFJwyb3h4xEeE8R4ueDa/iQXcfurlMj5sdYVsv7lZ/K8TgEvp4fhB3HQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780563975; c=relaxed/simple; bh=6nC4qMmpp4fUyVsAFDYujq7+sxNujf5CGEPAWJHIlFA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Oa41gObM97lWIDZU5SrSUijbJnFIDsTSo7x1RtcZzhInUwHwqfrs7iJIu+1/MuwYv9HMwAhajnPkYGV21bzoc0kQLTzD1EXF4DFmAqDoEkIDYdYksgkM8p4teifSx8E2hzy5VFMpgZnnwi3LdzXWiRLplXaJBheQ9sEdw6zu94M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z4Qk/eMs; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z4Qk/eMs" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490b64c8311so5789205e9.3 for ; Thu, 04 Jun 2026 02:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780563972; x=1781168772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EdFuwsES54dFvGT6zPCTaZ+yF4K8AlHGY+rBuqBIdh4=; b=Z4Qk/eMsRQn5NaOl5EnL49h5mkIDXCd6CVB06Y3pkNHIQBrrOz07RC4i9WNJ7soZ5V ZwZnlbdEhstvH16TCDK3NLc3IDK022X024ITEBaBP7leRrZPYvIKM0a2oZgI8eLPi4hf l6bUS8EAAbKpENkoLhJlvpJaE3SPEuYNQtAyuGwu5GFaav3z27CJASM9RViLgvZnE9iX HnaGV4X3VncpchGb6vO7ALPLhi36EY0JNacWYHGwLG7HcXBXRzq/C0S0jLJRDSq+IYgB Ameqbmz9JWPN6B5sTwrZ27N7L7FPN5xbYHLpuQPyHE4EtAIwP41vpiRcH1y53BQ25zuc Uo0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780563972; x=1781168772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EdFuwsES54dFvGT6zPCTaZ+yF4K8AlHGY+rBuqBIdh4=; b=Efwl20XUg/Zjzy4fAJqQCMk8parVoey/QLT/qlXniCj9CL9k8ccYZstMlosf5aGHOy 3pwViBuskWSOgNtCy3uw0PvUSSDIeAqzuYZ5NMXBqsEwiqgr7PJ38B8IuPCVB/RufFY1 hyYDB416TT14DU/xtaLR4N/8nCnMvnL5vHAskS0Vy+WOsPtOirwNXALvJNWYAbHjCW/P xkUmwAsPp+eW5N3rcnmnR9sB+nRdGXE2hxN5RNk+AXoniH9Vo5x1v8KUYstjrMUJeKJ5 jNh/yutelcXRVjVTcY/BbvxLyTYnPFjfcQUrTj3CMKxeVJ4T6wHpSV2WPBwQ0tjiAI+p a/+g== X-Forwarded-Encrypted: i=1; AFNElJ+W7IlQuF0L9XYdVoB5Az24uNhufY9defAR+vEUPL0IELkT+vDhu5izoe866RY7d+HOR9E84ASMJbmhApA=@vger.kernel.org X-Gm-Message-State: AOJu0YxH+eBqVSl1Jb/iPDjlEnBlvv4iAa8oXjudkqHluQQJGIQDSbCZ H/KilkpiGnfHuw8+Y0x9+WYk/+GPJPYXSb5MJTGfyUcUlstii3XB9Tik X-Gm-Gg: Acq92OHKAiNFdji1dHV062iZ6CmaJzCsCZHoDBWMQNb5TjCQfs/NDFYYFFlqW0MNwy2 qMove7+eTCmYSRC3eEjHKTDHbgnWehCPfDa2plGoWuJm4CifcrehPwcy2z0XfF8it0n5g8EyKK6 gCE0rRovVteSSIuuTEiDAzJHOnAz1OBDbrnsupFUfBCGmMlr4KvZl5MteYuXKTQHZ6/sJBCRMwK QemH4+e9bQsp5sY6LQeo+bD7+F+MFPPyuMTBIJWxOhXi3xx3KyZpnkHO+5vxzKH7pov4ot6MlCy hFYsjaYCAGq89O6wab29MuyrJ32opGkSVVazevsSmPtkq1nGwvvMNO9h4SvZbd0z3BY5SJmS0wM /EIbPwNTumos/RXKpApfIpSSX5mTv9J80pyYLyhF9P8s45MONGbIzFBhcql5qSeoK6sMPXbh0p8 S1RJ7g+WfQWRv11Hk/Q4fBJWQYE1eiwyub6oFd/q9BOCrrPTPtw1B6HQcdp1sM92e+fLK5ZVieG XmCkQ1pkw== X-Received: by 2002:a05:600c:8184:b0:490:5cd8:d213 with SMTP id 5b1f17b1804b1-490b5eb44f8mr113527135e9.15.1780563971711; Thu, 04 Jun 2026 02:06:11 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490b7e6c774sm70203515e9.1.2026.06.04.02.06.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2026 02:06:11 -0700 (PDT) Date: Thu, 4 Jun 2026 10:06:09 +0100 From: David Laight To: Askar Safin Cc: metze@samba.org, akpm@linux-foundation.org, axboe@kernel.dk, brauner@kernel.org, david@kernel.org, dhowells@redhat.com, hch@infradead.org, jack@suse.cz, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, miklos@szeredi.hu, netdev@vger.kernel.org, patches@lists.linux.dev, pfalcato@suse.de, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, willy@infradead.org Subject: Re: [PATCH 2/3] vmsplice: make vmsplice a trivial wrapper for preadv2/pwritev2 Message-ID: <20260604100609.6b37f500@pumpkin> In-Reply-To: <20260603211736.755139-1-safinaskar@gmail.com> References: <20260603211736.755139-1-safinaskar@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 4 Jun 2026 00:17:36 +0300 Askar Safin wrote: > Stefan Metzmacher : > > Why is 'int fd' changed to 'unsigned long fd'? > > Because preadv2 and pwritev2 take "unsigned long". I want vmsplice > to be as similar as possible to preadv2 and pwritev2. Something needs to ensure that the high 32bits of the fd get masked off on 64bit systems. They can be non-zero in the register that comes from userspace. -- David > > > Should that be its own commit if the change is desired? > > Yes, possibly. But this patchset already got to next. >