From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93C318CC13 for ; Thu, 4 Jun 2026 18:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780596358; cv=none; b=e3Dm3835c22KXcTVD+X3p+y6GocrQhOdJ7i/jg9NepWqECPyx0vFQMOuZDchm1fgNG9Q8wfVWpw1Fs1i7ylFJgaMqYxCKiRGwaWHCbdzl1nIHAee+JxqpZDc9zf5G6cncJTwHp6dtPcTt+wPdy8no+D2E3E72PvBBFjYaAsisg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780596358; c=relaxed/simple; bh=lTf6uPntjxPcMtk9M1V8TXCny6f3dbhk4slZ32ql6eg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gNlv7ir3mTf9vUGjJvq2CrMVVCfuQMrufKNKYmNSOm9eZoKd/97WNYPiPYIViIUbE6ALfCJ6iN5nyZso4Pvu1n6DqSn1Y97dvvkM4O7E7UIqxw/tWeEHuGNPq9tSMRLYaEdQvQhcNtnc0NlTgB55ReyJM7zglEr8t5jEjk3kfrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=L6lmw2HZ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="L6lmw2HZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780596355; bh=lTf6uPntjxPcMtk9M1V8TXCny6f3dbhk4slZ32ql6eg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L6lmw2HZUy0ee7XAu90UJE0Z9FVWkKBEatrdtcLRacOqmGt2EqEXk1/Kn4KbjmlnG 4YRFwMx/8c8cK870TASCF8rOUN6biP5Mk8I0Ldl9fJcJClnvLGW8dEv6dpZxOPyW/y INM4ZfJgsZnFje/whwqyX0w1CBYqLtyZ53uv3IfjHlgTGYBxtveGHqJkNZbmzyS+oo 6zf8iMNVek2Tw3ZqYrsWUCkMdpQj6V1Tpa5qfpCb9jEsHCVfkM4IdHshNHIDpBg7QQ wzqY1pBnOjrKDwJvx7V21qNi2jrZ0IpwlragoPjXLiZS4tITpEBsOgydy2O2hyCN2G 5jfj808gwd8vw== Received: from fedora-2.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id AC67817E093F; Thu, 4 Jun 2026 20:05:54 +0200 (CEST) Date: Thu, 4 Jun 2026 20:05:50 +0200 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , Neil Armstrong Subject: Re: [PATCH v2 4/7] drm/panfrost: Move perfcnt GPU disable sequence into a helper Message-ID: <20260604200550.1d31c038@fedora-2.home> In-Reply-To: <20260604-claude-fixes-v2-4-57c6bd4c1655@collabora.com> References: <20260604-claude-fixes-v2-0-57c6bd4c1655@collabora.com> <20260604-claude-fixes-v2-4-57c6bd4c1655@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 04 Jun 2026 18:35:23 +0100 Adri=C3=A1n Larumbe wrote: > Just for the sake of avoiding repetition. >=20 > Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panfrost/panfrost_perfcnt.c | 31 ++++++++++++-----------= ------ > 1 file changed, 13 insertions(+), 18 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c b/drivers/gpu/dr= m/panfrost/panfrost_perfcnt.c > index 7020c0192e18..ad1156678e91 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_perfcnt.c > +++ b/drivers/gpu/drm/panfrost/panfrost_perfcnt.c > @@ -35,6 +35,16 @@ struct panfrost_perfcnt { > struct completion dump_comp; > }; > =20 > +static void panfrost_perfcnt_gpu_disable(struct panfrost_device *pfdev) > +{ > + gpu_write(pfdev, GPU_PERFCNT_CFG, > + GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); > + gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0x0); > + gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0x0); > + gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0x0); > + gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); > +} > + > void panfrost_perfcnt_clean_cache_done(struct panfrost_device *pfdev) > { > complete(&pfdev->perfcnt->dump_comp); > @@ -193,12 +203,7 @@ static int panfrost_perfcnt_disable_locked(struct pa= nfrost_device *pfdev, > if (user !=3D perfcnt->user) > return -EINVAL; > =20 > - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0x0); > - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0x0); > - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0x0); > - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); > - gpu_write(pfdev, GPU_PERFCNT_CFG, > - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); > + panfrost_perfcnt_gpu_disable(pfdev); > =20 > perfcnt->user =3D NULL; > drm_gem_vunmap(&perfcnt->mapping->obj->base.base, &map); > @@ -327,12 +332,7 @@ int panfrost_perfcnt_init(struct panfrost_device *pf= dev) > perfcnt->bosize =3D size; > =20 > /* Start with everything disabled. */ > - gpu_write(pfdev, GPU_PERFCNT_CFG, > - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); > - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0); > - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0); > - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0); > - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); > + panfrost_perfcnt_gpu_disable(pfdev); > =20 > init_completion(&perfcnt->dump_comp); > mutex_init(&perfcnt->lock); > @@ -344,10 +344,5 @@ int panfrost_perfcnt_init(struct panfrost_device *pf= dev) > void panfrost_perfcnt_fini(struct panfrost_device *pfdev) > { > /* Disable everything before leaving. */ > - gpu_write(pfdev, GPU_PERFCNT_CFG, > - GPU_PERFCNT_CFG_MODE(GPU_PERFCNT_CFG_MODE_OFF)); > - gpu_write(pfdev, GPU_PRFCNT_JM_EN, 0); > - gpu_write(pfdev, GPU_PRFCNT_SHADER_EN, 0); > - gpu_write(pfdev, GPU_PRFCNT_MMU_L2_EN, 0); > - gpu_write(pfdev, GPU_PRFCNT_TILER_EN, 0); > + panfrost_perfcnt_gpu_disable(pfdev); > } >=20