From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94A923DD864; Fri, 5 Jun 2026 15:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780671790; cv=none; b=dP553VM68DebpixfhjKLbFAkvnqgn+w/REj4sSeK7yMcEFLly+0V0n2VpB3xo/v2L4R5wbH0P2nTYzMifchzTnx4jA0Qx8DOsLAgiVqHyZ9Qp7m8MEAlZ9U6+fjT3f3IhYUYCpbAbw5OgiMSEI4f5jhK92kNKp8hVrFlo3hH7wk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780671790; c=relaxed/simple; bh=R+74eEeUw8pIho76agsdU7ZS4ye3rkv3jnAiElBK6YU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L/+dJ1mwR5cknXF43Tn1MVQE8v7oaWDkBzZzemx8IcFMeWLuCMUs8EzD4uOgDTB6W3xUnNSJQQL65+zVW3/570kuEUhKleWXkHQhwI9L+EUgLp2SCNxU7wY4IQLZpUnE7v0aYCzjOO0KUlQStAgSig+rnX4GHAS5V7ZadFbt2Qc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=k1SJdmrO; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="k1SJdmrO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA7B81F00893; Fri, 5 Jun 2026 15:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780671789; bh=pLDIdbNf+EeN1JZXVgAOA16py+6veKivAQKpowFK6Y4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=k1SJdmrOLDcuy5stN1MtbJzUM8o634iBNdOglgLpb9yUgvebHZaWOw6k0H7LuxmWa VOQNfZXiEZEVmOoO3SEAvn9JmBqayyWP4+Y+VTSuFpgZbm0Ji7jZfHIGIdiWdvq4n6 ZBdHw/3aringbjWTz9jgHw3SVeZqWidMhN5gyvsc= Date: Fri, 5 Jun 2026 08:06:11 +0200 From: Greg Kroah-Hartman To: Fenglin Wu Cc: linux-arm-msm@vger.kernel.org, Stephen Boyd , Neil Armstrong , Abel Vesa , David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spmi: pmic-arb: Fix OF node leak in spmi_pmic_arb_register_buses() Message-ID: <2026060558-carpentry-exception-d414@gregkh> References: <20260604-spmi-bus-register-fix-v1-1-136adda83a92@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260604-spmi-bus-register-fix-v1-1-136adda83a92@oss.qualcomm.com> On Thu, Jun 04, 2026 at 10:46:03PM -0700, Fenglin Wu wrote: > Call of_node_put(child) to reduce its reference count when > bailing out from the for_each_available_child_of_node() loop > upon an error in bus registration. > > Also, return 0 directly if there are no errors in bus > registration. > > Fixes: 979987371739 ("spmi: pmic-arb: Add multi bus support") > Signed-off-by: Fenglin Wu > --- > drivers/spmi/spmi-pmic-arb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot