From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB913EFFC1 for ; Tue, 9 Jun 2026 10:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999938; cv=none; b=ep4l+Ir0m+28/GQ5qt5twz1GZND+L+8dllCuvx+oJgz3VC7GUYK2moRenL/exxe/IxziK22dJ+bh1FkgItZ01RFt1Ku2Wkryqoh3nwUrm6CNRX8ZTo46Om1vZxUl1x0ckyxxBWyzGl5fbigR79eu2/qTsp2xjtKDhiEl+h0oU90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780999938; c=relaxed/simple; bh=6ThnYIlKC57w5aotTpiMahJitgcrfjbPTuJ60lkiI5I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=g8CWR0Dfua42O8rfKrkObPk9+d8WOWzF5tyQEGEhYu6hKNFmZjsxGE+0jqwYcTHnfv5S0ja/FxIlrd9LMA/LFG5TGgg2Wu9EOrehSg3wKoXbX8R4o1w8kWK++pT7Cm78Zd3WWBmPRok9IwXGtnflaj7BnRuRajpHe7jKJJeFAqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AwEkFnHE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AwEkFnHE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E750F1F00893; Tue, 9 Jun 2026 10:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1780999937; bh=tSinoPDYa/z8MT8Mx1PvQXknZVv1+pd2L6E5VJei9oU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=AwEkFnHEuJklO14FwFLqHLVmyBeDZQmKEARpOxMFcgCbAvlxRBbvw0+lyI4g4ub39 S4VfAihgbo+LJ9wbx0Sva3e+MsT2nH69owXl3Yv6CHHs/iWL1LbtBU67IgimFtRc5g eCX/ZuIZTiSaxREL7/qaovG+olPt4woYJ3a4FGmc= Date: Tue, 9 Jun 2026 12:11:18 +0200 From: Greg Kroah-Hartman To: tze.yee.ng@altera.com Cc: Dinh Nguyen , Alan Tull , Richard Gong , linux-kernel@vger.kernel.org, Adrian Ng Ho Yin , Nazim Amirul Subject: Re: [PATCH] firmware: stratix10-svc: fix memory leaks and list corruption bugs Message-ID: <2026060903-crablike-sulfide-50c2@gregkh> References: <6e13c57d085f61fc97c90ab5121b6dcc5119e035.1780996415.git.tze.yee.ng@altera.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e13c57d085f61fc97c90ab5121b6dcc5119e035.1780996415.git.tze.yee.ng@altera.com> On Tue, Jun 09, 2026 at 02:19:44AM -0700, tze.yee.ng@altera.com wrote: > From: Tze Yee Ng > > Fix a memory leak when gen_pool_alloc() fails by freeing pmem on the error > path. Switch pmem allocation from devm_kzalloc() to kzalloc() with > explicit kfree() in the free path to match its list-managed life time. > Remove the erroneous list_del(&svc_data_mem) which corrupted the list head > on failed lookups. Add NULL guards instratix10_svc_free_memory(). > > Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") > > Signed-off-by: Tze Yee Ng > --- > drivers/firmware/stratix10-svc.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c > index 1ef65bf845fc..3b0e2b14180f 100644 > --- a/drivers/firmware/stratix10-svc.c > +++ b/drivers/firmware/stratix10-svc.c > @@ -1912,14 +1912,16 @@ void *stratix10_svc_allocate_memory(struct stratix10_svc_chan *chan, > struct gen_pool *genpool = chan->ctrl->genpool; > size_t s = roundup(size, 1 << genpool->min_alloc_order); > > - pmem = devm_kzalloc(chan->ctrl->dev, sizeof(*pmem), GFP_KERNEL); > + pmem = kzalloc_obj(*pmem); > if (!pmem) > return ERR_PTR(-ENOMEM); > > guard(mutex)(&svc_mem_lock); > va = gen_pool_alloc(genpool, s); > - if (!va) > + if (!va) { > + kfree(pmem); > return ERR_PTR(-ENOMEM); > + } > > memset((void *)va, 0, s); > pa = gen_pool_virt_to_phys(genpool, va); > @@ -1945,6 +1947,9 @@ EXPORT_SYMBOL_GPL(stratix10_svc_allocate_memory); > void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr) > { > struct stratix10_svc_data_mem *pmem; > + > + if (!chan || !kaddr) > + return; > guard(mutex)(&svc_mem_lock); > > list_for_each_entry(pmem, &svc_data_mem, node) > @@ -1953,10 +1958,9 @@ void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr) > (unsigned long)kaddr, pmem->size); > pmem->vaddr = NULL; > list_del(&pmem->node); > + kfree(pmem); > return; > } > - > - list_del(&svc_data_mem); > } > EXPORT_SYMBOL_GPL(stratix10_svc_free_memory); > > -- > 2.43.7 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot