From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872AE3438BB for ; Tue, 9 Jun 2026 11:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781005073; cv=none; b=Z6PP69SqnwblAgHDWSvJ2K3r9MdkreR1RLGuNovAcoGV6zGSTXe8m17IKyvATKYmnr+y8OWWDW1InAQF+BhhvUVMFYPGrkdWYnU/QJqMJzvjXZDj3AgQERpEvRfDZiVUHjiBARj/N0SR+GNxQzBOY7BfxixJc3Y+7XZkBeTk5pg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781005073; c=relaxed/simple; bh=ANKCTnU58OUlAOUIJqwRrknbTWPLfqPCX+uSvNWICrQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JrNdpCP1aXtjg+RjE0r0YQTVYSGIfrrZ/1Gd+mBzCQSCQZNF2EqEIMlNIEg/QPI+E0TCJyknFz6dykuV1ZBwtm4CghXAWFartro0JIe6aQ8nLBwcPnaRSOUzedywlRnWvNc3a4zLgBmfrvweZzgPnkcXVNqQyrAEY2Y4M1cIOT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/gs9wyE; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/gs9wyE" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-490a76757e5so35237665e9.2 for ; Tue, 09 Jun 2026 04:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781005071; x=1781609871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C06fqdDmC9XoMbgwTie0uFIDoyxOFPYJ9w0RtZztqRM=; b=K/gs9wyEqHWmzT3yfp8+yE7/cL2T+/Kpk1fn/jSyefWQgSF80lYKB29N5s9RMx2hXe 72atqlm2UTs6XaQ1/u53j6R0n4Gca2/nzQ8TVdOriJQq67jvijiLDsfoA50Fs/ReS+Av ZuMn5Rey4I+v0XZ90uPqIWjU6em2x3ZT5K+7Qo9+B3O7XziqW88L8bu1A22McdD/zHjP 4nWRtyFYQRztGescDMC+TjNTMKAv7nKeG4UnK2B1KGp7L43ZLww0yw9wVKACn7B5R6oB 93RDLcP3r9zh8h0r+35Egv88Isc7FkqW1u6GgPRTkl/RWEOlSsaecJUN27tfpYwYskWj 1yNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781005071; x=1781609871; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C06fqdDmC9XoMbgwTie0uFIDoyxOFPYJ9w0RtZztqRM=; b=YEGpQTTs/DOvNgYI5Vy+RtC1g2w2Bvnlp42FKhSC3V/+mLV6MxDUR1eqi2ERvBWA8a o6JuHGfxFtIes4LgIGWmIU/izXyBKDHZKNb5nDnfc7w6ytX29V0DD71XDPq8wdj52c44 +NZP4izS3RKFDXR3mZFMq9tqgAS7yY/YEB7iqrlfgG2afQGUYQK1dogUgb1M8JVvvmX+ lgr5+NRwJ2q5wMKHNuXq9aj54AV61QcMABK0WmOT8rxMuK7Wdqn8s1xCUSyZd0WOrttZ CDWXumfe4d75qjBLjbiyyQ9FoG2VVc+ZvvwyyKUxyfvZcBa3hGS9dLXTImJdDepSApvZ DirA== X-Forwarded-Encrypted: i=1; AFNElJ9X2nhB8+vzpkfj3/9e4HXOpV5Fp8HOWNQFCCcT1zynaVeWv+i2THXu/eH43iyWPgjAkfwaeJQ5ujncCjg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxs3/Ao7tDFHlvRRbGrFcWaT6cwhpnwUzn95ppqFBV3f+un5l7v x5UQqhbX9sXHj6S9KR9jBm/T6YDJ9ARePn72dLk7I2G41ktqjC90VQWd X-Gm-Gg: Acq92OHNG3t8LVZiHlwCNZ47OlwyuP/UpJT79foIAluOYDjmD4Iadn+yidRscHMA3r3 JfRX5C16w6B+/+ltg8B1ZXkP+mSfbhKnDio426kWQ8lZL8TZYX6MpXoQ9BNzyUG0mP/SZpWpuV1 Aa8aRHNF84l1gLykTN2BBi/udOd5juThG5vvgnNAJ4pXLqsYpWngHuwm+QZXd/4s4xM3ZjDJ+hM euwFnyQoaoOmhX2e3YrpwoxgkEp7ZNW7HoupkXJt3P6ljolY6cVu9PirY0Sng0AQE+mkyK9tzl8 nmYNdtABgZ8Zd76yhHZE9tDz1Vf13fq89wzLun2jfQwFXJfnxI2AT0mkuTZhWWHve5tA20d4lhx VJhfXwjuzXlXULrv43ka2WreMuub8CKnu/63P21iP/OVVd2auMXputzR3VH/femk9eEl49SUieB NAUbGlyUdFpWfCYp7zhwtlPDzorKCXXnrsivIzBqXRxpizaQoKA6WhfqFS2VE7+LGy4tAFCm0fs fd1XmghbnZvZpu0Dx+img== X-Received: by 2002:a05:600c:1c1f:b0:490:b724:dbd6 with SMTP id 5b1f17b1804b1-490c2598382mr318719865e9.6.1781005070590; Tue, 09 Jun 2026 04:37:50 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cbfe4sm486014105e9.7.2026.06.09.04.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 04:37:49 -0700 (PDT) From: David Carlier To: Daniel Scally , Jacopo Mondi Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] media: mali-c55: Fix clock leak on reset deassert failure Date: Tue, 9 Jun 2026 12:37:47 +0100 Message-ID: <20260609113747.39592-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __mali_c55_power_on() enables the clocks before deasserting the resets, but bails out on a deassert failure without disabling them again. Both callers treat a failed power-on as already cleaned up, so the clocks are left enabled. Disable them on the error path. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Signed-off-by: David Carlier --- drivers/media/platform/arm/mali-c55/mali-c55-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c index ee4a42674..fb81141d1 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c @@ -699,6 +699,8 @@ static int __mali_c55_power_on(struct mali_c55 *mali_c55) mali_c55->resets); if (ret) { dev_err(mali_c55->dev, "failed to deassert resets\n"); + clk_bulk_disable_unprepare(ARRAY_SIZE(mali_c55->clks), + mali_c55->clks); return ret; } -- 2.53.0