From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A31D73FFFA7 for ; Tue, 9 Jun 2026 11:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781005169; cv=none; b=Ce+6Xg4LT0UQkm3BbOO+7oIRoivpY4mFPH4rmveHH4xNx0FndoJq+YquibL3CBo56/gtlLId3qPF+kpXsB60SZ2ZlzTDVwmjrtT/Df3ZzfO1SxuIeGeCnAuOLnF7y4bdN9Th+f5tRGFSHHxBrJHRhTqRK3DGGOuEmFOlkr+/BB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781005169; c=relaxed/simple; bh=m996FWhRx8Jyse1pg+wk0JpYoaqx8/UREkFYUcB/3mI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OHjgRVE33wUbN9lhkhuXcdu9Z33nxUe7x+NnOM4cnW61MUSq0GfByrFL5cyvdaCSJ5I3aDfIr674Wlswnwb6WPnrn5A4fnXa5dq1PJly7CRp76uw2HQmqc3bTMLstctt07IBITSzSsdGJtIMCOtw30pOc0Lp+3FsJVpXI0Otm2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ROQr9E3c; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ROQr9E3c" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36b8d414666so3048799a91.3 for ; Tue, 09 Jun 2026 04:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781005167; x=1781609967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RFE4SMGzYu6VfqVWZy1LVzG1tn7Hezp1rS4Db45ZIm0=; b=ROQr9E3cGqMkiJLWPAGhCFmHQ5RCEH7s86veA0+pL+HxA6/9HGQ2r+mC9uE3ufOe9b HvXZEnnZF75Lwj/Laj9aDLWMdzhui+5bZB+49RKYWbHNnaw1JRjH3Ea87jckZMC7rb2I uj1UInB/hA2wibqGNka5MSzp10+n80uBmXOsKXuU4J9z1FMYQPEH3FgI+VPoWnqsb1uA rEdLmbjWoQiBaoiBaobBegWyQexlzSJS4ApMFrpsFcHULi4MzS9Bqp8nmVz6UqGQVkBD nbDMm3NWFWtPVEUGr6e6CXzv3Hm3vVbNggkbiM4HLrC28tzYC6g30FU3/OBhwujmjHF5 tU5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781005167; x=1781609967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RFE4SMGzYu6VfqVWZy1LVzG1tn7Hezp1rS4Db45ZIm0=; b=SQbG3JmfnHoS5floSfX7QWKCgQWevNWg1YWDQFma50TJKl6QcYnbMsgy1WhQB1pwO4 E/Dt8IlmX2/gaEtsaqDY80Iq55G8rCceKoN7J4bZGtPJZor2uRWN9yxEsdc1XMj/ZPXu fZOOYP8psEcbFrx6sdwRLnZZfhWZf2qykYFrtsIQLM+oW+iqLXnH7hL6iQnX4nyv7arp WNa3Zt36T/A9bhGuif72QJRzL7jRcMP7GEBp7ntv/WeAyVGZ4RgTeGX+W+9+lcKpw1+7 W8FW0UJXk4B/EAQQ/U35V7CHOJWtM6kiZfTNELaOmRRJtuJLidIXY5va1K6KmO9kQOTk y+og== X-Forwarded-Encrypted: i=1; AFNElJ8Q5/9x+UXbKhchnjgDKENPwKBr/qpytjvSssABSF/EN6YLdKTNhUndRHLqrw30jik0u2fY5oS/qoMpQK4=@vger.kernel.org X-Gm-Message-State: AOJu0YySKeL6DAzMYQpEvfvM16MS8/SxVFdLbkPKe9JQy7/Ie+qt7caH rLp+h/v1BfbUzJ2avy3NOdZe2z1OeReUdGnroMfbZ6ZPaXRsjKPcqJSR X-Gm-Gg: Acq92OF12aTxkygzScaMBbFT4CRS7/+7D3Op0PNTOBI3CWrlsUmEt7WrMReBr7dpr7p EkD+TJqOXsDz4ZJbuk/hFJwUd2dIe0RkfXMarGxtbp5xy95ZKzV1n5fq4+Myl6D3u1KEK1zoprU mYyGI0QCJdV/zHV5khGB/W9MprZkaRUSuvf5xHCiQBG1eahIrk25kfJGj90TpGAY4Btck4c3wDK vV/TKZZFBofBBmXgQIUbSWQhuQU8fRc7s4+Wz2z46EL3lVIxCvQpZ6YKSoKNe8KNn6yGF/B3M7s q0VAuj1Kiwcpt78Kt7HYy6YHKrbS48jIxVgnOM/jEN3xk3G/kBYWY+N0RCN0Er4k+pI/PJxEg7e NAvzxCuQxYcT/IBF/xffkBihCOeDaVZ7Q0J7EmSrUPaHZhT1YvtmipLmIKjVba2t4KsV0UOosJc bK3BXjlCJTWXxHrdgx0Qm/CVUfp4JpS3KY1jtIF226a08zjziruO/m7JYrnMKoc7ZYC1ru X-Received: by 2002:a17:90b:4d11:b0:36d:689a:cb27 with SMTP id 98e67ed59e1d1-37521779d48mr2843139a91.24.1781005167145; Tue, 09 Jun 2026 04:39:27 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f70660sm210755635ad.11.2026.06.09.04.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 04:39:26 -0700 (PDT) From: phucduc.bui@gmail.com To: Kuninori Morimoto , Mark Brown , Geert Uytterhoeven Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Magnus Damm , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v6 06/11] ASoC: renesas: fsi: Move fsi_clk_init() Date: Tue, 9 Jun 2026 18:38:31 +0700 Message-ID: <20260609113836.45079-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260609113836.45079-1-phucduc.bui@gmail.com> References: <20260609113836.45079-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Move fsi_clk_init() after set_rate() functions to prepare for subsequent refactoring. Acked-by: Kuninori Morimoto Suggested-by: Kuninori Morimoto Signed-off-by: bui duc phuc --- Changes in v6: - Add Acked-by tag from Kuninori Morimoto. sound/soc/renesas/fsi.c | 128 ++++++++++++++++++++-------------------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 3e3c6fd7c56b..1df7dc014363 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -717,70 +717,6 @@ static void fsi_spdif_clk_ctrl(struct fsi_priv *fsi, int enable) /* * clock function */ -static int fsi_clk_init(struct device *dev, - struct fsi_priv *fsi, - int xck, - int ick, - int div, - int (*set_rate)(struct device *dev, - struct fsi_priv *fsi)) -{ - struct fsi_clk *clock = &fsi->clock; - int is_porta = fsi_is_port_a(fsi); - - clock->xck = NULL; - clock->ick = NULL; - clock->div = NULL; - clock->rate = 0; - clock->count = 0; - clock->set_rate = set_rate; - - clock->own = devm_clk_get(dev, NULL); - if (IS_ERR(clock->own)) - return -EINVAL; - - /* external clock */ - if (xck) { - clock->xck = devm_clk_get(dev, is_porta ? "xcka" : "xckb"); - if (IS_ERR(clock->xck)) { - dev_err(dev, "can't get xck clock\n"); - return -EINVAL; - } - if (clock->xck == clock->own) { - dev_err(dev, "cpu doesn't support xck clock\n"); - return -EINVAL; - } - } - - /* FSIACLK/FSIBCLK */ - if (ick) { - clock->ick = devm_clk_get(dev, is_porta ? "icka" : "ickb"); - if (IS_ERR(clock->ick)) { - dev_err(dev, "can't get ick clock\n"); - return -EINVAL; - } - if (clock->ick == clock->own) { - dev_err(dev, "cpu doesn't support ick clock\n"); - return -EINVAL; - } - } - - /* FSI-DIV */ - if (div) { - clock->div = devm_clk_get(dev, is_porta ? "diva" : "divb"); - if (IS_ERR(clock->div)) { - dev_err(dev, "can't get div clock\n"); - return -EINVAL; - } - if (clock->div == clock->own) { - dev_err(dev, "cpu doesn't support div clock\n"); - return -EINVAL; - } - } - - return 0; -} - #define fsi_clk_invalid(fsi) fsi_clk_valid(fsi, 0) static void fsi_clk_valid(struct fsi_priv *fsi, unsigned long rate) { @@ -1034,6 +970,70 @@ static int fsi_clk_set_rate_cpg(struct device *dev, return ret; } +static int fsi_clk_init(struct device *dev, + struct fsi_priv *fsi, + int xck, + int ick, + int div, + int (*set_rate)(struct device *dev, + struct fsi_priv *fsi)) +{ + struct fsi_clk *clock = &fsi->clock; + int is_porta = fsi_is_port_a(fsi); + + clock->xck = NULL; + clock->ick = NULL; + clock->div = NULL; + clock->rate = 0; + clock->count = 0; + clock->set_rate = set_rate; + + clock->own = devm_clk_get(dev, NULL); + if (IS_ERR(clock->own)) + return -EINVAL; + + /* external clock */ + if (xck) { + clock->xck = devm_clk_get(dev, is_porta ? "xcka" : "xckb"); + if (IS_ERR(clock->xck)) { + dev_err(dev, "can't get xck clock\n"); + return -EINVAL; + } + if (clock->xck == clock->own) { + dev_err(dev, "cpu doesn't support xck clock\n"); + return -EINVAL; + } + } + + /* FSIACLK/FSIBCLK */ + if (ick) { + clock->ick = devm_clk_get(dev, is_porta ? "icka" : "ickb"); + if (IS_ERR(clock->ick)) { + dev_err(dev, "can't get ick clock\n"); + return -EINVAL; + } + if (clock->ick == clock->own) { + dev_err(dev, "cpu doesn't support ick clock\n"); + return -EINVAL; + } + } + + /* FSI-DIV */ + if (div) { + clock->div = devm_clk_get(dev, is_porta ? "diva" : "divb"); + if (IS_ERR(clock->div)) { + dev_err(dev, "can't get div clock\n"); + return -EINVAL; + } + if (clock->div == clock->own) { + dev_err(dev, "cpu doesn't support div clock\n"); + return -EINVAL; + } + } + + return 0; +} + static void fsi_pointer_update(struct fsi_stream *io, int size) { io->buff_sample_pos += size; -- 2.43.0