From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2180F3F1650 for ; Tue, 9 Jun 2026 10:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000770; cv=none; b=Gqr0C3eh0SMB6l8I4bF51IkybPPHQAcDKS3NdThHjMkWpUBmN0JQs50vHMBJOVOtpDqgKyhq7bFcxnJnZpVakDU4EUjBhrYxrxb3HwvU09TZfXFhu1UJYNqSYLDOfE6vvkbf29fZSWuxsYalU0FepZKmkAl0//0g1wJ92m+HO6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781000770; c=relaxed/simple; bh=CvjWP4qfaUy4Vu+fDzXdcGiVNmiLKemDkKshBGQW93w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j0vzwiUI1MtYIKJIs+5prK9/yx1sgLOUbi+BZZK6JK6aQXsnRiPQ88Ch7lYv5vvZnF6B/LVS0RV8ZRDrvjresEG1qEyUFbkve/kVgggu8kDOlVdGKYc+C4u6oeGqT0Dal1NJiy6FNuOPbna12Bpdwrd8wUfKX/sR853psyPLOLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lG5GqU2M; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lG5GqU2M" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-45ef779c1c2so3621620f8f.1 for ; Tue, 09 Jun 2026 03:26:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781000767; x=1781605567; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=F7DTan2GpF6A2ycsVVtBoKDWhROO13NhyoThWfu3oNA=; b=lG5GqU2M9gegkg9vFEFFMnkpnVwp1jbANzRWvLajAMLdRMO/9Hhc3V1U1cEKsLCK0U S1xaig0sweqAdOVpXG7wjQp+/9NVR5wEsevopKt1+x4E+LfXkR+WolseLKDfCbDvPFIi UozLQpUXgmlxdSw1+Bu5IMpEC2gg1G37UMom+vaTY4OMhfBwIRVUH/diMxMfC6yOXLl1 qbQ9pcpDCwuJp7l1UnjW2mc8otAej/rzHDGBpCYyfBGRjl26ZOPqN3WvY5glzVuHzYp3 MQCFhQtZ7KMx0DW1WBqxAKVOsrws6F2/Ld4rgzUK1nxo56/H6sFhivbfbuNPdEJ22eWQ ZKjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781000767; x=1781605567; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F7DTan2GpF6A2ycsVVtBoKDWhROO13NhyoThWfu3oNA=; b=YjupxSeDdD4e+Vbij2yhCR6glbehGvHdYs98B3gCo/vIN9qDDi7l/4+M9p4UWKyd5t QjVnsUVlMJ/XXibcrQh7OS4cYH+GLoO3XXQxgnfRfas5TLJO2vS2BVSPsC7a33X7pv48 4iJYvgtqMtJtFen6B33SrM9sJfgDljGRWWOqb23zseuScCcRHyKAgAfyPIPFXSEqFFYN UykaHAIuPDFDaLBhfyCtBJk4DNSl+R83o7VkZmbfvcebfFlZ8mJQsB6eAQ7JLG+fGvx/ 8Oml/5sGpHisLw3+OWyOVp9IKeSpSve93hPO9SbmdvwO8NsbaHsFzKnGZcc5oEkqKxzx 0iSg== X-Forwarded-Encrypted: i=1; AFNElJ8uVMZr8WhcHeCt9aXGdXF2LeZ+EwgnDQyNmUA79geth68wypbkQCqCzVYKQvrkSSsduLPwmN/gbcHgR5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YxiU6LuHLmE1BxRKiw7FYNksQj8sEVQIWDDB+HoXTuHlfn1Becn M5ZsnG903NFAz/E1LFRmTwoEC5FMxz8DZ/S4qlV8CWRvxMqsTivjI1s3 X-Gm-Gg: Acq92OH3kLEJf3+70wNuSeVMeCyhTTbmdZMYuSgQ6KYQqTHFX56z03cVqkiubDQeWzv 7ceKjO0LlPjWIYGWYivERftuuDg3W9s/4hD1m0ZXjQgrCOdmB7/TbH3j62I989LOP7zmA5t6h7E svS+yaMYZNX6A3wwNMOoGXNznlVm/dcsgXi4TG4WNQI9ffrorpzY08Z6upTefzoF1SJxI7gvPEG eT1IK+Khm8GLxjQiIYM9HY65A/86y876FMsGgARAzvvpgTHZodLVnvOtup1A+EdI7MKYqOXDWFF N0AQcn3PV8yqCk/yRlotMGFIvjSsMwYfBTHsIYIHxgRWGlE85mt5IC4EHHqCtnjSnsw0+8UwiWS 90V48iq5y/CTECdNJDm33d1ij1bUPjt3Ew0SrypNs5RlZay1QoLdgV01JETpnoiDP8yHzuHacaE DVJ4zIkqTK3J3QPJbzsK9LJRn6Gc+aKyetB7MWefi4CDUoYWWGaNNtlnicLY3deZy094aTty4MG VO57YJEh218MiGBKzNoqckESwZZdlOupafe+t6jxZh7fsXBmJv8vYiPCYV32OJP1OtSQfKZkGLR AkZsTcaOZ8oy5s7ofggFcaizAsH2U0wOQyg//3FdfsheVckXe4rWTcbBK8BMnS5VCW+p3A02/JX 7 X-Received: by 2002:a05:600c:4e43:b0:490:3d62:f5df with SMTP id 5b1f17b1804b1-490c25d24f4mr315035765e9.30.1781000767236; Tue, 09 Jun 2026 03:26:07 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc391aaasm543448335e9.1.2026.06.09.03.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 03:26:07 -0700 (PDT) Date: Tue, 9 Jun 2026 12:26:05 +0200 From: Joshua Crofts To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH v2 11/12] iio: dac: ad5686: write_raw: use guard(mutex)() Message-ID: <20260609122605.000010b9@gmail.com> In-Reply-To: <20260609-ad5686-new-features-v2-11-70b423f5c76d@analog.com> References: <20260609-ad5686-new-features-v2-0-70b423f5c76d@analog.com> <20260609-ad5686-new-features-v2-11-70b423f5c76d@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 09 Jun 2026 11:13:06 +0100 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Use guarded mutex lock to facilitate code review when adding new > attributes. This will allow for early returns, avoiding error-prone > locking and unlocking in error paths. Gain-control support will add > the scale attribute. > > Signed-off-by: Rodrigo Alencar Althoug is included in , it's better to explicitly add the include for it as IIO drivers are currently being moved away from these catch-all headers. With that fixed, Reviewed-by: Joshua Crofts -- Kind regards CJD