From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E799240D565 for ; Tue, 9 Jun 2026 22:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043189; cv=none; b=Z1a4ucaAtVMxnz99Nacz0LvwFFIAJnDRWutF+ZAKVf2d6lDFXa8W/46ljdbzHoKDTcGfZw/J51ummiVNWi459b5AkR8rKfYpsLPLrTvueFh2/WVfRU+ZlHRAJciK1dRsydOdvk44L1ZQS2RJfTd8m0HrC9LmV6AqmLcmMxtYs1c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043189; c=relaxed/simple; bh=qagFDp3J5fIfiyzBNIi1t4DhzgkTYU0l51sSsmyjYQE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=omAux7O9EmdXSe8aWocfn+6UeBqr3+IUT9H2EMi/JZAFgIRbMGu1aaOOYxZ7bQ8gHICrbaa0n3kQ4zgflDErsAhLp4gu08EG/hteRlQsJGhmCJUuHyo3sSdu6DJM6APgd1MxxlyI9N8IESQXw9S0uDcMYihWkqWhLekiSbjAuXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hvTmT4+g; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hvTmT4+g" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-486503ae8f0so4528856b6e.0 for ; Tue, 09 Jun 2026 15:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781043186; x=1781647986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=t2SuYOT/HPXvKrCZtDe/qeMWaHPEqePbJHi5tDeXlEA=; b=hvTmT4+gEnDiH5ui0as01NC1roZS3n0EaARgy72wRnkbR5eMbnpE/jyfX5v8shlPip jYJQlr3fK2ixyqC1IJwS20BZ0Hij3NyWsR29OzksMCxhlTfEltc0gUUrMRCd2vctcb0h MHJ3BlA/8XgeAdTsL8VzS+7v12JfNUD5DegI5dGyM/D04CLFJGkXev1d/yVOcfjLMCF8 hCbcQaKYkfAa6Lu2AixKt+zgJNfZSBT72Atpl6dx2i4CcE8qYHQ90vxK9sFnjgblKfcF kKghq3tZbcQg8+MFo2QzOGZa9eHmgwE6hUYU2RiV+XJym2ikPPW80Jx+0omexY8zMiOh 2z8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781043186; x=1781647986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t2SuYOT/HPXvKrCZtDe/qeMWaHPEqePbJHi5tDeXlEA=; b=rKjIOsHSZHwznN34RyRMtnoXfHbsVm450rbgSXSMv7sES/4Y68E9f1HzI+exL4g2Cm /vvUkx12n7rIdRgsAjuOmn+qllc6ZNdDEIR/u9vN0p5KEValKmwXnXMGYbVWoXxeqK7Q c1ites6O8le2VRkKVoPI5F/UCDvXClblTht4ldt+Lk68OG2bGpOBuS271PvOmX8x4HUS c5hQdQcOGvkHNFTRtIEmvnX73hVpAzKvAkToWhWIFXE3KERO1tvk9r2iKxcjvdkTDmkK sz3w/ZovRj3Bqouvhag7qxtAvcPp6UKVB3jKqFE+xcsF/JchxtIW1oyy0phzp5RaSy5Y LV/A== X-Forwarded-Encrypted: i=1; AFNElJ+kQ4tYj7phVpZDTPGhFFRCM4eNXgrqQWb4hT1yyMcKrEqInuEgF5l9LKhtm8Ow6rrhnB2/61Aen3f6HoA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7T8G3S8/j1wWAQLLdajY3rrqW9J6x4S3rrqEOUlD1diwfkvK+ 5+xDiciP9QlUcy1+3ue+S4Smv1LCGj0nEpFxVb5OGdKshGWqRRx8QgvXPuLutM6aAHA= X-Gm-Gg: Acq92OHtYkcQ6TwmNV+BS8joggt6jSwzLP+ihGapu1JojZysHdM8fpNbWoNeMdPD6Gu XfGd5NV2xkCg1R4An2syT9Ra2sz9HPXzFDXAM5APDAdj+KcPJ6Jloif6ChqQgiJpcygXGe/YviC +bAvoMIDDVV5vjPM30yKNnyhfLRLL4Mk8UYEN0j8G9GBnFoPQEoBAV/XNmqsGrT41P2doxeRZq2 /dODC8HcQefW4BATdpYlmdnulJ+/WQjqk71lptuMmm57QWGZpQk1enVopCto6k5n+zwPZjKKhL4 7A43YVoCptuEz3dFlyZD0zF+3TaX6vJPUmPj96ds1E9g7+6nspTa+QRNPo/ct1+tgPbdqC2XQQN 2otH0vS48O1W2h7D9ISWFlgvN5IG5QFk8hp9CFs3dEm/XbEsRDDxwk0VGpikIWsxfFqiT/kXJem FqWt98d3gkn/noH/7BdX0LDf3q+icWzPEvs7VIf9YR9MTXhC6Ut6UDrAN+pRY8gu0= X-Received: by 2002:a05:6808:1190:b0:482:4df4:ef5 with SMTP id 5614622812f47-4868dc826ccmr13806953b6e.3.1781043185864; Tue, 09 Jun 2026 15:13:05 -0700 (PDT) Received: from linuxescape (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4865b5a5a64sm17105048b6e.4.2026.06.09.15.13.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 15:13:05 -0700 (PDT) Date: Tue, 9 Jun 2026 17:13:02 -0500 From: Maxwell Doose To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" Subject: Re: [PATCH v2 11/12] iio: dac: ad5686: write_raw: use guard(mutex)() Message-ID: <20260609171302.5764edb2@linuxescape> In-Reply-To: <20260609-ad5686-new-features-v2-11-70b423f5c76d@analog.com> References: <20260609-ad5686-new-features-v2-0-70b423f5c76d@analog.com> <20260609-ad5686-new-features-v2-11-70b423f5c76d@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 09 Jun 2026 11:13:06 +0100 Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Use guarded mutex lock to facilitate code review when adding new > attributes. This will allow for early returns, avoiding error-prone > locking and unlocking in error paths. Gain-control support will add > the scale attribute. > > Signed-off-by: Rodrigo Alencar > --- > drivers/iio/dac/ad5686.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) > I agree with Joshua on this, linux/cleanup.h should definitely be included. However I don't think sending a v3 is worth the trouble (Jonathan may tweak while applying but I wouldn't count on it), so with or without: Reviewed-by: Maxwell Doose -- best regards, max