From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30B73335BA; Wed, 10 Jun 2026 00:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781052347; cv=none; b=QjJQC+wm9Ds/5fEmsC5QvAVqltPcLfNYn7qqkkEEe1evMocP8g8D5V9I6rEWA0eeUnMh0wc4JaL+Baw5292JD4iS4b17vuovMEds7F23Y+yDxdafeqFdflwzLAQS/fmL5atGEa0oRF5YKerEOesmuA0+Tiup2XGj+B6ocICa7Dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781052347; c=relaxed/simple; bh=4h/dCVIOY55Ppws/w5DnqQK3WpPW0m9YI4U3w8xC4fI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s2uhFdi+msExn1EWd26WXkXGstROu4PTirYxeao9/ZzxJ0xnsxux/lVKebeSdQ0w6qLuMI1Ru2vpZGGbPuhJ7suuM6YtcDuxw0mnLMowsh2oULqMKwKcJwWxrQMsq0z97NVcVXlssp92PNu/WcfX+JAiIzi4mzjcMFLEml+7RDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iZ5kDwhz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iZ5kDwhz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6522C1F00893; Wed, 10 Jun 2026 00:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781052345; bh=bUj8Msp56Mm2mMjdrx9sk1nhQGk4EduoLIVQnB4R67o=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=iZ5kDwhzWLXlzr0YYDj4Psv1ry86ecP8/TiXPvdqkxoo2hFAYMTsZ6RmgxhZ1zNam PXZYMDW7aYOW99F3N6JX1Fq8F8QaaHKYC6rSWkJ42hofxCIXCalFL8d58u0Fm/VO3j mAGMO8uz6X1Q4GTgBHzfzq3UeN/JWrzKEvvcaA+Xka0zUZ3v/kUhvUCJao9HP6vurn IvWRVtdEqwI/Bgzou/Tn3lV8k194dIbYOvJtq50DDn6B23s6l62/rwGAuK9Czo7PPY 2T8ZV3BUOqLK+ZxpkYdjo+DkTnK4poRWwQkSk1ht0oGEol/reh/dFbyZ9HnWEmJSTl djS1FpCXZJiQg== Date: Tue, 9 Jun 2026 17:45:44 -0700 From: Jakub Kicinski To: Samuel Moelius Cc: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , cake@lists.bufferbloat.net (moderated list:CAKE QDISC), netdev@vger.kernel.org (open list:TC subsystem), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net v2] net/sched: cake: reject overhead values that underflow length Message-ID: <20260609174544.114b82e0@kernel.org> In-Reply-To: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> References: <20260609232935.1602659.8545fdb04fbe.cake-overhead-underflow@trailofbits.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 9 Jun 2026 23:29:36 +0000 Samuel Moelius wrote: > CAKE accepts overhead values that can make adjusted packet length > arithmetic underflow. A negative effective length can wrap through > unsigned arithmetic and become a large value. Sorry, why are you posting more patches? You were told to stop yesterday. And you received an email which said: Here are a few ground rules which are frequently broken by newcomers: - You must wait at least 24 hours before posting a new version to give reviewers time to respond. This is a hard rule, no matter what your reason to repost is. - Each new version of your series should be a fresh / separate thread Add a https://lore.kernel.org/.. link to the previous version to the cover letter or changelog, instead of threading the submissions. - Until you gain experience submit one of two patches at a time, do not send multiple changes at once until some of your changes were accepted. This avoids reviewers having to provide the same feedback on multiple patches. - Avoid changing the subject of the changes or cover letter unless necessary, it breaks our patch tracking. - If you're submitting changes for issues discovered using automated tools - commit message should explain the discovery and testing process (for drivers explicitly mention that you don't have access to the device, it's not a blocker). You broke at least 2 of these already. If you keep ignoring direct maintainer feedback you will be banned.