From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38E652BE033; Wed, 10 Jun 2026 01:37:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781055438; cv=none; b=of2CKfFT839YufwGGV9I5enYsacz/575dzJYHyV6pSIiUiv+3PmxvRGtQd3rtdYygqVU06D3M+F/w37y1Yc/UnG7jseG8ZRn27C2pYvvNxfuADGCrZsolWxCg9f/hK5/T1aBn8G/qvImFXMHVM90PbtA21hCN5HAE6RVejo74ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781055438; c=relaxed/simple; bh=m55+gK7sZpsKWCJFxXo8IOEm873NXSSucsIWi9IY8S0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DXS2bXCJPj7KkJgpSzriZ7/4v6F1uyt6l7c6FzooTNwtemqXERqu1hOifIpTJWJulrKRF+h6A043Vjg/12m0D8gcl3Zh8PkLvvBd2dPtjHs77zRf+KEFb7Ly2csB+CVrUQMW1pkFLbybakCiWly15fRAIEQwysVKMgVtvJqhf+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XT37wAKu; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XT37wAKu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 608391F00893; Wed, 10 Jun 2026 01:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781055436; bh=oj+3BrWIohO8/102gzT0FtplulPKa4TBCTbQ5ava1A0=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=XT37wAKuDJUqM0FtoBBj1B9u7+lLwkWs/MTQNoggeRTqpCUa+WqL4F1k1PjQ0e3C9 Lxl6uRoOL04d6s/jaF/HcTLsdP6ERV6YAwkINUTgUa5oyhYrp8JGLfKtSKr5LcsDrD 22oW6bIfTBMyLfq5kSKbxZ0gUMelnnyVZWViM9U1qUHmKX/O5KqM06mRd8agSiwlKx NVNz7AfRguZkG/U8ohRASXWhtmO/Az9NNMC9oOPKY6qNVaimbxqMDA00yQTn7kpAzv R2IArgRniPbCsk2GZUy5rI3GFttPHF/22hvoWJSlgGQHHmPHtrl2J2f5Zdaa0MawDY qqCRtw21KYTZQ== Date: Tue, 9 Jun 2026 18:37:15 -0700 From: Jakub Kicinski To: Yizhou Zhao Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Kees Cook , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yuxiang Yang , Ao Wang , Xuewei Feng , Qi Li , Ke Xu Subject: Re: [PATCH net] vlan: prevent cross-netns promisc/allmulti propagation Message-ID: <20260609183715.006f7bd4@kernel.org> In-Reply-To: <20260607113529.98178-1-zhaoyz24@mails.tsinghua.edu.cn> References: <20260607113529.98178-1-zhaoyz24@mails.tsinghua.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 7 Jun 2026 19:35:28 +0800 Yizhou Zhao wrote: > vlan_dev_change_rx_flags() propagates IFF_PROMISC and IFF_ALLMULTI > changes from a VLAN device to its real device. If the VLAN device has > been moved to another network namespace, a user with CAP_NET_ADMIN in > that namespace can toggle these flags on the VLAN device and change the > promiscuity/allmulti counters on the real device in the original > namespace. I'd think that's expected. There's a higher chance this patch will break someone's intentional setup than prevent an issue... If anyone on the list disagrees please speak up -- pw-bot: reject