From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F366374A02 for ; Tue, 9 Jun 2026 19:43:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034212; cv=none; b=ivCkw+xw/EUBLzE/CLxNWJak1giumcORzY1KaPeyD/T+invV17Bes6/hvhCP6DWFPDis1W6UCXbNRSRgiMWZEZUMfcHNjFKzA+rew+zvZrm1LzUqftj4+1fxFrbUrNKgQpP8bvr+EVukpIaBIdUwOPNenSMJlj2lDs3we5f+4Rw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034212; c=relaxed/simple; bh=hhKYJazjJge73y6yNe5PGiyzjbkw4XoIZrmixT/ypn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JChZA2NFfWRZVCvVxvrffYBxRL3tcYWhZgb5+/7oRil3SvUynwM4H6eI9XK230LHthNJ3yE30Ar+52MTO4M/5txkIYba69n1HAY4uL2Nqe5szaZmisX1bibp13KWzoX+8En9qDTPifrfToJ34NWRVams3orGDlzZoaVjbP2gmkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gBmzPx22; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gBmzPx22" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8423f236418so3289573b3a.1 for ; Tue, 09 Jun 2026 12:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781034210; x=1781639010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZebOJ0xoX4ZIU1H13OA9Ye3a+JpFQ7aYIL/Bsme9n2s=; b=gBmzPx22MlQpYpYHd29TKdRfdFF/p7/923B4uJVe0IUcozOwJ4M01v4mDrl7qWckV2 z5M/ueUSIcRZL6QvzLKDLXMd+PgZEtR1eQD6MBqmkowfFR6CsalDN7iFViYieqXDdNps imp85y3Uct89Xn8swIHx8lLysFdOUqd+HkLJvTHMaJOH/C5WWs64vSo2kR0rQOaaoID1 pkq03/1JwZIk5/07gA8DZoLPWP/VfDMsEAAs2QzfBuNKIdCDxOcTThufLnb6va7rrUXn O93/9trNYXXsZS0dLXGlnwsfFLqTqcb4sxDUgM5Iw2Mk/UUtjB3jQemdYUE+dxZXC8/U gBaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781034210; x=1781639010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZebOJ0xoX4ZIU1H13OA9Ye3a+JpFQ7aYIL/Bsme9n2s=; b=T+Oejk6wBe8b79FMT8vZSEy9+peA+a1qYs1dzeaIn1XEjRsGL5d1Q2gQGB1Ox+JRve URemEs6ogA2AGoj4yiiBGQOKiLwQMBao97429JW8MGz78sMBjjNebsWpsnrK60sw1y1n qdWUz1JcDwNJROODOoe7vlxacLfh6qY3ACBFU3FhI1ACXgpQAfA3DGvRtvo2H4o1NvsL eMU4brnZF4CQrtA20Ra45J1PMKXQKYcsuZWmAB0cVGagzbmm7jqYo8DDZ+Z6XwkSxHpJ SCqsmIJQn6bW64y7p2BSH6ttrjhtCxpbNf0oh/zR1/kdQvkS2TemvNL1JSWrM9jcqwZ1 gNZw== X-Forwarded-Encrypted: i=1; AFNElJ/oQlE3xg0xQOoQbeUymde1h1Laxk7ZnFzrldY9Ib9yquH3DHI15JGsfIl1vEABjKe51geLeddWBY2jQs0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1d1EaRjl0ud7v1YZrJKEOzS1rVX2MmJ09Oxar3L5YGkym4Yv0 xC6TXG+szHl1KnT09d0qf0VDtx6iC3RGqdpvUaRlL/opmQjt/glrSBEZ X-Gm-Gg: Acq92OFcaO5bugM8aeDSc7nytSoIWqsSsTDeOMWptIzBisLyig03ettag+yGinTS8hS LoVtV/YpU5zJVNDrEuiawwg4AGPtDYGryEOROrmrEgUGDuzhYR44bl3yqPR4g758JWJz5IRp/HF kEuWNloMRXkbkvuai8Xk8zWQX4Pp+fTi+w1dXslrrJs0bGOadTWpNqT6q8OKR25g6YQ0WpD737k SHEfGCFeFwWX1Mo9fh4ILoSx34BkTOa/mE3FHzoj2TirdsGcl/e3SkvM+k7oxsI+egw3p/Vj0qC Zdm3IARMcIH/0YLX5cyqVl96zBajoaZ6TKsdG+V76xm8FJHmQFXWOQju8GuCANsBzWDcdv7uD+B WNecsbUP22OxlhbGKOb4woJeQUW8ISPPIhMvtzJzjGcj8RNQQ2uhFL23IUUuMrTP51MuZ2DFrlz SwsHcX8hMWPUs0zcyIjgNmUAV43Xx/wJzbFrXjig/mBqgFbK2wr8qYpAxrnb+izzU5eVG825GR9 NxCn4uFsomvZge15ewWs11ITLv+AQoRUv+hDDJ+rDbG9w== X-Received: by 2002:a05:6a00:b807:b0:82a:5d55:5807 with SMTP id d2e1a72fcca58-842b0e1c8b1mr21630502b3a.6.1781034210504; Tue, 09 Jun 2026 12:43:30 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828daf76sm22715683b3a.42.2026.06.09.12.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 12:43:30 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Grant Likely , Tim Yamin , Julia Lawall , Jeff Garzik , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 1/5] ata: pata_mpc52xx: fix NULL pointer dereference in IRQ handler Date: Tue, 9 Jun 2026 12:43:07 -0700 Message-ID: <20260609194311.6217-2-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609194311.6217-1-rosenp@gmail.com> References: <20260609194311.6217-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Assign priv->dmatsk before request_irq() to ensure the IRQ handler does not dereference a NULL pointer. The handler accesses priv->dmatsk via bcom_retrieve_buffer(). Assisted-by: opencode:big-pickle Fixes: 6b61e69e7bc1 ("powerpc/mpc5200: Add MDMA/UDMA support to MPC5200 ATA driver") Signed-off-by: Rosen Penev --- drivers/ata/pata_mpc52xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index 210a63283f62..fe445d6aaff6 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -766,6 +766,8 @@ static int mpc52xx_ata_probe(struct platform_device *op) goto err1; } + priv->dmatsk = dmatsk; + task_irq = bcom_get_task_irq(dmatsk); rv = devm_request_irq(&op->dev, task_irq, &mpc52xx_ata_task_irq, 0, "ATA task", priv); @@ -773,7 +775,6 @@ static int mpc52xx_ata_probe(struct platform_device *op) dev_err(&op->dev, "error requesting DMA IRQ\n"); goto err2; } - priv->dmatsk = dmatsk; /* Init the hw */ rv = mpc52xx_ata_hw_init(priv); -- 2.54.0