From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 083CC347BDB for ; Tue, 9 Jun 2026 19:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034215; cv=none; b=dJReehUr+YWFG4pnoh80IujWceclOjAyD+Mf0nIa+i0k5bOqkMYzr3Ma6MuKCtVhMC6IH2X4SBf0zyCzFExW+x/8/+poan7vOZoPy6e6f8+9ZlXbqquWJcTnn7/fHoEnl76e2/aLbO/BbkogXJy8Nbj82nSF6ZDNeCO8C1ip8R4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781034215; c=relaxed/simple; bh=XqjBLZIewikmafzIZ1I0WakYSpYhiLflFvH+OAvaGUY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PjT9soeGOafsVuXobw09p2eg1fhObPofA0dV1hskjiiAsHHGBfXVxc+0T6ijGm0FOaxNDF77Gs2XpYmA+WVQ9Ny8Y5UI7q6g6ES9nvpNDk4IZdYKBXITt1hgTQ9txRuc20rOsyxgS4RvJ7SttA12RokenH5JAB6LpNJegTOPaDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NlvcsfCy; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NlvcsfCy" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c85d8615b09so3487042a12.3 for ; Tue, 09 Jun 2026 12:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781034213; x=1781639013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PP4RTugBF0O+yHDk5iqRwbV8b2jPQiiO46jM32LZa9M=; b=NlvcsfCyHO95pBjBq9lzlbZc1dICLtD04kH0crAsFipcJqbuivgi6OVR80n562eFMB aWTjupkkCG+tSa66jZdVHa/vjz3nx7xdZQVW7g0zb4GFlOEmeAl4Pw+sQZKj7siJpX/j v6bkw2mJOUWCtqHxq3BGIldh7bPCNwmKRiz5WnK75WeiTV1p6kN0WRDGhftj27TXTvuC 8w4UOqAVbWawzgmuqaNnaU332Rua1sMpCHBKvUS1OHkXNpof8C1ahMk8d9SVWTN3xhet Go7yTM6wfRhyaEROGciTSFjpa91NJW4zB0Mb0fUpcPAqlqAe9cuW3IA/arSbscp+boJ6 MAsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781034213; x=1781639013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PP4RTugBF0O+yHDk5iqRwbV8b2jPQiiO46jM32LZa9M=; b=h2C0eAOW83E+7xetafyq/w8clQ5tJCF/4KXpviHl0t61eSpiqyzpuW48re04Q64w25 1PZGpkG8aa1qvWjfSvo8bcNCNxx6aSmiqQgoCW3WYcASYimY6lKF3abgaJVgY62ky4k1 n/CTQ6kA/Ra5K3fFlFkrmB9CUQ6osE0xtjxNvYKnykd1oN9oAAlFoThC8PzvDPnt/hCJ A1Xdsh4PLv30eOIRRpUBoJePK9HMLAIzyGvR0//BaECEFoVfJjiI4o7ZMnF8EunEhblV qWQpggwjDCxPPBqCI+pdU7e4I/iykK1jpUqvdTbfqqTQeajAxQAz2fVtfTInaTW0903h L8GQ== X-Forwarded-Encrypted: i=1; AFNElJ8rkXa9IILq9e1rrj0yQp8K+xF/V2/YPD6sO6yxDwuj0zM5rWg6ZpdnNI85imvUj3K5eifzSy/gIrkIhyI=@vger.kernel.org X-Gm-Message-State: AOJu0YynumXyi0Klit60JYVIGNdfuzgfxoi4fiYurXDlf1cWp+4jCYab VGo/1gTnFzKG8Rw27WRIKD+aXt4mZQo6vaIKgg5IVME/8xosFfbPXJgr X-Gm-Gg: Acq92OHaKCM5SxhIavJDjGWC+KkmFsjgCR2ZdY+poxgGGEypxSqeOUjX3RgD2jj58FL mf6hVF8drct5+rW00HrKHHCNxy/YGww7G47VaQl+F1tBI4+6EytQeu193+Y0fvjJZBlFznDSWJU KHW+CW2Kgg0k/P/wrd+1yB/QAiK1Yq0lc6zGjzm6pQubSEeQE7LwfNp0wi11MekrLAskbicImIN Mm7G5dh3aR8vU35IEhjs6z0dMJhHzZjtEan0pe9C/W/L/0KPhIbdi7670FnEIyR9UBaI3wf1VjG LYEFFsaMTv/Bop68+D6hbuE8K5OMzyX3vVWfq7OatT9n750vkBKP+B5uPal8NyOvsc2s8uX6k9r FVsuEqdgn7Gs+2yzapUNfPUp1Gg6jp2NZqaJT9XVAgT/SUhCc+QHtOX55wtFFefFW1UnIVAQZg8 dtjRqU2kFTcEFshdLE1xdRcv/ctW6xgysDp4e5EaKrtObIKzy/FmHthA47TgVGYXdj9Scvw4Vye oqB1HzREPVe/DzZuFZnIDDhB548Py2CKSk7mM3iE2Zkrg== X-Received: by 2002:a05:6a00:813:b0:842:55b6:f5a1 with SMTP id d2e1a72fcca58-842b0d8a604mr21267445b3a.6.1781034213362; Tue, 09 Jun 2026 12:43:33 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-842828daf76sm22715683b3a.42.2026.06.09.12.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 12:43:32 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Grant Likely , Tim Yamin , Julia Lawall , Jeff Garzik , linux-kernel@vger.kernel.org (open list) Subject: [PATCHv2 3/5] ata: pata_mpc52xx: remove redundant irq_dispose_mapping calls Date: Tue, 9 Jun 2026 12:43:09 -0700 Message-ID: <20260609194311.6217-4-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609194311.6217-1-rosenp@gmail.com> References: <20260609194311.6217-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit bcom_ata_release() calls bcom_task_free(), which already calls irq_dispose_mapping(tsk->irq). The explicit irq_dispose_mapping() calls in the probe error path and remove function are redundant and cause a double-free of the same mapping. Remove them. Assisted-by: opencode:big-pickle Fixes: d01159dffa15 ("drivers/ata/pata_mpc52xx.c: clean up error handling code") Signed-off-by: Rosen Penev --- drivers/ata/pata_mpc52xx.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c index b46b83df03d1..d13cfaf285dc 100644 --- a/drivers/ata/pata_mpc52xx.c +++ b/drivers/ata/pata_mpc52xx.c @@ -795,7 +795,6 @@ static int mpc52xx_ata_probe(struct platform_device *op) err_free_irq: free_irq(task_irq, priv); - irq_dispose_mapping(task_irq); err_free_task: bcom_ata_release(dmatsk); err1: @@ -815,7 +814,6 @@ static void mpc52xx_ata_remove(struct platform_device *op) /* Clean up DMA */ task_irq = bcom_get_task_irq(priv->dmatsk); free_irq(task_irq, priv); - irq_dispose_mapping(task_irq); bcom_ata_release(priv->dmatsk); irq_dispose_mapping(priv->ata_irq); } -- 2.54.0