From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9493B19C1 for ; Tue, 9 Jun 2026 21:26:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781040400; cv=none; b=lE7MVuiitoxpDY3nse99EJmOyoUp+9Bo1faOT4JBQ0OVQNGxeUaWpN11UM7QtPRSRFQkEG+u+aUytK22Kb1fXFQwwEJOqGUDwxddez9TO/q/hKQ+VwxTuW/sZ96VqcrQg2ffvJP3g/QN9xIbdVTQega+CKOmJ8L+kZryjFGOKSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781040400; c=relaxed/simple; bh=RjcmqHddOPJFPlXAo7SY94la3yf/PIGdxvDHfx5w/Vo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q3FqzCHB+uR9AXeDj0QZejT7VhNI5JWTvYOH38ngaiNNShFLuiP+ZBkweW/+QpROtSUluSupVOIef2da79uIo+AI9knePAo7DIn2h7zBwPS/v9Suyw/PWfIJ7rqSg+6FfEnKTklpijtveft+vBBK2Pw6nj5shu9EpoCnc1BZ4Gc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZaBhmIRp; arc=none smtp.client-ip=209.85.160.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZaBhmIRp" Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-5176bbb9384so60778741cf.1 for ; Tue, 09 Jun 2026 14:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781040398; x=1781645198; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5q5PI7NNO6j/SihoDeyAbVWZeOHgS2VkuRW1R2tonY8=; b=ZaBhmIRpH1mNM3B7H2hsntKtF/ioI/t+KeEY3PrA/mabHu5QBCNuCAbdKwMPAWct3n 5nGTHlu78eR0tahcLNvgqs2Itv+MzH3zOMZjye+QmQppyf8Wwq2rI60C+j1h5TyDp3SG 2HzcX3x3E+dD9zQJfoylrc8/x2du+Oj7XzOvHZJjOgzfZ49ecBVsj5t3nlhcrdW7mM0L CNXdtqsKag9EtYBEN7fuKg8PzT/fFO6XfXnflpUYeOt3Bx31Z5PE47ddIeddELpMMQLQ lkhiewndxoCKOtHg73z5rnak2Z0m9iaWAwmyg0PjIXWSWO9gOSF5YpwVYc48jOJxet1X mgmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781040398; x=1781645198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5q5PI7NNO6j/SihoDeyAbVWZeOHgS2VkuRW1R2tonY8=; b=EUDxRD+mRPgvDaqBEB7v/S0f1and1WiboyfHPYnNYzxNfnIrpopogyqWUba8aulHwR h9XtxA5m0zGS5mAPOUUV3nIIRyOU2Ozcl32trTVv3vLurhcuzluH8Yc135W7o1C9YKhq aoUVKOBZoNn+q69i5QGziApEN4DvYy31ueGqgGnfJZGbrdkqLvj4pt8gMXDitzHN6raG LF41h9Jn9OKeQAhXWPBAf/M2pQjwIvkREaNLuNCfRBHqIR1VshK8nnt1enPZDLLFiZUJ iwVQQCZfgw6HoiMrRwrwG6t7SbFvheCVUBs4/KlynSlpLAcjg1XXowEkweRLz8XHB1Mp 8o0A== X-Forwarded-Encrypted: i=1; AFNElJ84+2j7d29QPRfcBAO/+3hUeFWPBKB5i43CPNuuBScInFsgJcEupYJg3a2NQewIlMggysrmrvrfvCsNl48=@vger.kernel.org X-Gm-Message-State: AOJu0YwL/yDYzLT+2KKs06SIFXqc9phwf9TgSI3E57yMcBEbTczK0UO5 2snRyW2o+O8CaX+IApapQzBzJHM6FbSldhOG2ZSKITaslKRRrFzkopAv X-Gm-Gg: Acq92OFjihZkFilVLYKNK+2XBygiDpLdkS2qE6qeKejd59tfVJuorWVmjCmmONqO77j LuXQsw8LhRuVMQnxJ1CdquFsoY8XXVEB5Ihp97wwLKcktd5oaXg1CcTg4hYvGpFzVs4BRd5LYDG tWY0NVewArD33Fi0F4C9311L6WtLKgMeczQizLotbHPH1LvF99ymcDkfjmdUfu9u8CQpbEzj71v ijqKExzuLpPpkaXf+pdx3v+Es6Rv+CLlk+jEo/b1IvAzlea8ScMyOF179kUqXxTxDu8cn3Ma/hW Uwe1b9QBdAM05aMkCmC1G0pbrYGkGDa34eD1Bf7iyfxuRVAaosZdraZTR7d97Lxbf5i9MJm5DOM gx4oUxLvQrPgy5XXHW/9BdPz+bdt9TK1RKBMqxSuEDu1BSyA3d9ssf2GCrCHaS9L6EiPm+DcCEI Ph4UFhNByYGi+QFbfwPbSq6z3dUrIEIeDD0/1bj/0Iazbzz2UjScPBCE1PkQSTcWW0M8d6XgzzP PriFmM= X-Received: by 2002:a05:622a:1f9a:b0:517:8541:8b70 with SMTP id d75a77b69052e-51795c614d6mr320278931cf.45.1781040397949; Tue, 09 Jun 2026 14:26:37 -0700 (PDT) Received: from fedora (pool-100-11-178-145.phlapa.fios.verizon.net. [100.11.178.145]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ceccdcb3c5sm226713036d6.21.2026.06.09.14.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 14:26:37 -0700 (PDT) From: Dave Carey To: platform-driver-x86@vger.kernel.org Cc: johannes.goede@oss.qualcomm.com, mpearson-lenovo@squebb.ca, ilpo.jarvinen@linux.intel.com, armin.wolf@outlook.de, linux-kernel@vger.kernel.org, Dave Carey Subject: [PATCH v7 1/2] platform/x86/lenovo: lenovo-ymc: Suppress probe on Yoga Book 9 14IAH10 Date: Tue, 9 Jun 2026 17:26:30 -0400 Message-ID: <20260609212631.925943-2-carvsdriver@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609212631.925943-1-carvsdriver@gmail.com> References: <20260608215205.678182-1-carvsdriver@gmail.com> <20260609212631.925943-1-carvsdriver@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Yoga Book 9 14IAH10 (DMI product name "83KJ") has a dedicated yb9-kbdock WMI driver that registers an input device reporting SW_TABLET_MODE to track the detachable Bluetooth keyboard. lenovo-ymc also loads on this machine and creates an input node with the SW_TABLET_MODE capability bit set. For input switches, the presence of the capability bit has semantic meaning: userspace (e.g. GNOME) reads the switch state at startup from every node advertising the capability and does not expect more than one such node. Add a DMI match for the Yoga Book 9 14IAH10 to probe() so that lenovo-ymc returns -ENODEV on this hardware, leaving yb9-kbdock as the sole SW_TABLET_MODE source. The ymc_ec_trigger EC write, the only other action taken in response to a YMC event, is guarded by a separate DMI table that excludes this machine; no other functionality is affected. Signed-off-by: Dave Carey --- drivers/platform/x86/lenovo/ymc.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/platform/x86/lenovo/ymc.c b/drivers/platform/x86/lenovo/ymc.c --- a/drivers/platform/x86/lenovo/ymc.c +++ b/drivers/platform/x86/lenovo/ymc.c @@ -23,7 +23,23 @@ module_param(force, bool, 0444); static bool force; module_param(force, bool, 0444); MODULE_PARM_DESC(force, "Force loading on boards without a convertible DMI chassis-type"); +static const struct dmi_system_id lenovo_ymc_nosupport_dmi_table[] = { + { + /* + * Yoga Book 9 14IAH10: SW_TABLET_MODE is reported by the + * yb9-kbdock driver. Suppress lenovo-ymc on this machine to + * avoid userspace seeing two input nodes that both advertise + * the SW_TABLET_MODE capability. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83KJ"), + }, + }, + { } +}; + static const struct dmi_system_id allowed_chasis_types_dmi_table[] = { { .matches = { @@ -100,7 +116,10 @@ static int lenovo_ymc_probe(struct wmi_device *wdev, const void *ctx) struct lenovo_ymc_private *priv; struct input_dev *input_dev; int err; + if (dmi_check_system(lenovo_ymc_nosupport_dmi_table)) + return -ENODEV; + if (!dmi_check_system(allowed_chasis_types_dmi_table)) { if (force) dev_info(&wdev->dev, "Force loading Lenovo YMC support\n"); -- 2.54.0