From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7B03F0744 for ; Tue, 9 Jun 2026 22:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043608; cv=none; b=T2AD1xMfNW+S/DlGR6HETcIv/T5y+ssQTWQADTgbmpM9Y098IrsBQkH9V3XXV5VcJM25IaJrFPKJzPHPka4LsIaLFlUroUtzUsRUDkq95+YW7lN+xJ8CuqixIsLehSCfXo9M+tW+oNLln3El8Trv9fP0ujM6LfTHriZXIcw8EO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043608; c=relaxed/simple; bh=QNstBAc1L91v28F1oF1V1UBDhakUFuGDQ4mwwDQaYVc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CH3rKWX8Jg+zHFJB4ESNiAtRPJNRT+rcq0kTLoPBdZ2C2rU1aZUuZSAxEtEz4MvE++he/TyePSKVu0hIyk9ls2qwD6ZHwnyYxO2jVdA3FZnpjkFg19pQ84KsL2tS0fPnqvIUPT+IgZ7SUImQTkUeBJzhAKAqMSxy1ZIJisqLeO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oOkkrGal; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oOkkrGal" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c859878eb48so2401525a12.0 for ; Tue, 09 Jun 2026 15:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781043599; x=1781648399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1tT9xKJ0Z4ILZqTxJ8ZpiwY1jbcqBK/pYbLAZ3NF4IQ=; b=oOkkrGalBPfrahHB/2lhvZ0ibia84S3xEnmw8VJcr6PUBVDsQErd/MaqJ8pPZIpaNh RNSAVGdMceMpBD7IusPlRkTi2E6ErC5YbFKWfGl8aT4vSWPiu/0AjAyqs0cogUmf1Rzz ZbjdxBwmrlp7ufEyRXKu4FGZgMneCUJrNsMMC0tLODW19YaFUPNAuExcOdOeY6qIDO0D Wp/W65U/RFXoJMyGtVohfWdqQRJNzB5QxQJg/moCI3HbqWIHgD7zhzehW7Zzf7ekTX8u PxwWKZ99n7ehOcANvz8u0KF9IlPJwBAVMHVnK8T92r0igfsykZxQa0ChWTlxK2d1OIdc 0Grg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781043599; x=1781648399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1tT9xKJ0Z4ILZqTxJ8ZpiwY1jbcqBK/pYbLAZ3NF4IQ=; b=fLpIpgdHWMBfLB0lB5nDCDcxXMwrbX1rFNtz/c5z6HA9bSE7NomRV5eBrqtrTNxEKR EhBV2hku+up5H4c4s6lV/+ZFvPQnmNFZWmBvwtcJXtM5aO6FTp5JcwdplJWjYKY/TbWd Oe9NzM0Cihr9RR/kZY16Zp8YxB3bOa6p8l11tvrkXCEdlHV/D0mMUP7EgYGhBlWnXfAy fu1ntGsiRuttY6I7sVqKNvhAMDF2/YmJrPyiqajrps5RATOHcHjA655zGjnPYH09hB30 N12NMHK4SdEUAGttP2N4nhdM7yq2JNFE7xa+48+/u9PTlyKAnIVQPOTPgae274G+SpSE wlQg== X-Forwarded-Encrypted: i=1; AFNElJ/nv0gMZy19ylsi8rSWY56tkb3I0wxt0RQxYTK3Kmq4WgH8hcbvHqmHns/PXWgFPLzrOG+hNZBXW4Hcpbs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6I5OuyCsE8TzKepHADZ81frBZeAKakteVtX/pkxDFxKZCb7Or pJbYTbMRIsLgCx/r5CL74MWfrxkvZY2dhhey+eEZqA06jl/emy5kBwYO X-Gm-Gg: Acq92OG99tlv4en8vwh1bSfHajvZ2feZc2yfVAakNV1ZAuI+BECCQrLnAwGXfbWYJPv 4CUMSLkCEZf6afQDyPk9ytMdq5taoTPHCsSCnEyEBGTxr557Rl12C6rRaheKIcLNNKHUMu7anWR 16StoGiBmrBWrSNHBFB9DQz+PShw6jzL+cEVME6hlg2uyXkOmq5nCn6E8uSKttm+n9F2Sd5dEf8 4LtzTFfpLxWkWhr9kbHvn6xXsSQ8OUoQzxjNCKKZqm0kYq6KR58frx3Q24k96PZqNuNv5QJZVBt sQTU8jS2LvVrHZJBIpS4yVVq2XOlmmV6JWFGHH/yVCrb4Zy5jTG757SNHGvFIZFJH083+AeDve8 C5/moEp1br+qQxsjlBxQwpf5fCL1uRLPusru+w6+FyFSytX1mMCwK3Nh9SonElMFElEYDs2Ci9r 4ZSGcDotZkXCB4DwqyLjsVb6jTlC/MrgoNdgcPcjhjzoY8gjMmZOQSToRTinwLNa/P7SKgW1PaS iLuzYMO9B/qa5tHRMaAaXfH41F0R85ZH0QYOdb3wzBCjg== X-Received: by 2002:a05:6a21:104:b0:3b4:7eb0:479f with SMTP id adf61e73a8af0-3b4ccd3a851mr24318303637.5.1781043599239; Tue, 09 Jun 2026 15:19:59 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df04ff24sm19661834a12.14.2026.06.09.15.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 15:19:58 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv3 07/15] dmaengine: fsldma: fix request_irqs unwind freeing unregistered IRQ Date: Tue, 9 Jun 2026 15:19:18 -0700 Message-ID: <20260609221926.35538-8-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609221926.35538-1-rosenp@gmail.com> References: <20260609221926.35538-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When fsldma_request_irqs() fails on a per-channel IRQ, the unwind loop starts at the current index i, which calls free_irq() on the IRQ that request_irq() just failed to register. Decrement i before the loop to skip the failed channel. Bug introduced by commit 586f54672b33 ("dmaengine: fsldma: convert to platform_get_irq_optional()"). Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index 4475d50a94f5..c04a7fbd2ed0 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1088,7 +1088,7 @@ static int fsldma_request_irqs(struct fsldma_device *fdev) return 0; out_unwind: - for (/* none */; i >= 0; i--) { + for (i--; i >= 0; i--) { chan = fdev->chan[i]; if (!chan) continue; -- 2.54.0