From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CD46374A1D for ; Tue, 9 Jun 2026 22:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043603; cv=none; b=V9MA7LiiyDzAqWODuu50wqwI0WLYaxSOE3lwVPAWsPzMcCNWbOEvqHvcKpgg2o9Gm6RBoIBFBHsetBSELsfcc+iXEZRW58PoKgGzbITo7qHK8FqXHKf3jaHjFwr96mrjpGV64O2cwFb/+q7T4yAuWQR5Zhr2mC1N8niM8u9XRBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781043603; c=relaxed/simple; bh=lAp8VELf1WIzDtTXvES1MckgNe5J8JcBQCSWSAEzxUM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H++xiJHKArYdOfLaHuo6Jvk3gKX4dPS0WifQVRL7OHG0xDWtBwQKHp1hTtIGuJ4rWrFeF+VCz5JHiRWlLLW9jJ2pQeXZ1OwbYR+aOxaUvQ+wHd9+HhqAeBThQgNnf7Rq5G6qzhjxxfrngl9R+8IIONWNGdtUDLDjyH4tETHoMqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=owsqGYc5; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="owsqGYc5" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c85822059d8so3799282a12.1 for ; Tue, 09 Jun 2026 15:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781043601; x=1781648401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=txLeeHxUVUSX7wi9aUsbTgq6v6+yCgWQ3OKqqrJje5Y=; b=owsqGYc5F8l34VtY9R4ahiOF9KjV+lmV5S4ES9aqC6NcaemRsK3stk6WLfBsptNCL5 DIZGW/TV+p2zlcvTQ+uQCiVTjJ93PrZOHKLRdQ03T/RsHCILpEaRhCCRQ1fprgz1PTYF 39L0MrhRHaePtQvDZQpCQ0fWknNDJQjwzWBIebL/2PW/cGH6yPC15+kjrH6lS9FvBQqg mQjC8Y84dF5D/wOntevosTnOFEmbd1TWGIGpbSbcLJ9O9vbQ9V3Ue2BxLBouT7ReQ+F5 TaHWb5p1CcR0AmjkUhGRiugR816AjLL2cYl6ZgxD5wLoFeq4tkCBaKum5fPxlIiKHeZV GRiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781043601; x=1781648401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=txLeeHxUVUSX7wi9aUsbTgq6v6+yCgWQ3OKqqrJje5Y=; b=E+kCGjQ6oBrsol4I6+7TtvWqTC6zEpFmiGG5dLveXj4CawxrED4M0lUpD1nDgZTVaq 2UFOTgqWMSumuVaHKpG+da4nTRh1txqzNGHHfviKM6/OAmoKgfYkjztOQsiw9T3lBFLB KoLYGdGX9qoF5BOdFxmvhMunhlMfNPIHXp+NWXjMTr0uMUD8ul9FVH3jdZ1Cgzomj1Gx NIb0Zw6NONqVoLrI8Vi4vlwOHyg0U0oH7LoR4RwmocW4flG+Hz5+vDOBKw5pYUYFnbXx Pgzrxnok63/5GaPEZctXCyLZH1pnXIGdFAdDtSBVLaiUu7bfXk7x5Z3qZc4eFKAPpY00 rzrQ== X-Forwarded-Encrypted: i=1; AFNElJ/dh+t8E9J7vsgKfm+S7NsCfXpePKPUe9AvPS6ZCFztgriB7FFY8+vjaJfjZMa/iF4ckwWMwToLaSzTkno=@vger.kernel.org X-Gm-Message-State: AOJu0YwxWFrV3WDBx2fR0CqlOcpx8QBDpUt2P5JpMu7s76pw6D4g6tlS IxBGagavFs1Yu/B/P8X9kb7FxjL1NNho6MWcQAHolf2GqE5CLPciTPLb X-Gm-Gg: Acq92OGiOgYsFyupPlc0qLkMuuhoioBOYTn9lSR9fzVp8kqzC8G+57IhxEUNRrl1ocH zSwNLXbGo09/e9avPivud0ZkfmHPkmTxGby2HYOmTkTQs7Pl53UcjCcd+Fbzof7nrxdC+FbpnDW +ZoU75MezYXKfcbsuzKfNLV6BgfGdM/lUzSceMlhFThd8PlpYXo4Y97Ld9//F6gG4945Dd2jw86 vtouTuwd4lBjLcItIbovqT4pe9Mew/QFp37UWV9jyC2OayaVEjlaRo76rNSUB9Rm4dQfPtDG9g8 mxoZ6i+xDuscck32XHyd3fyFXHKTbDvd7GZtkSeDXodtK5yVaqKBsaVkWT9TXpXEqwydWeOfXiF KEGBVQAIidzxXkPeJRqtcF9DLudOcbQ50X6anfS2pXlQB09huxxdNi3clUcsaUtWf640rAk4wU6 8cuC6S5x1xFUZncOIRv847bczFkpPb6l4wtH9efG6dsH76Xon4PTbzJflZvs2FmBU2wTCBqJ6+V 297tJCRMkLwhq42g7Yb3EjtDNo8zn/cH31JaSxoYMTuMw== X-Received: by 2002:a05:6a21:4c16:b0:3b4:8ad2:5ea8 with SMTP id adf61e73a8af0-3b4ccf81eebmr27631680637.30.1781043600819; Tue, 09 Jun 2026 15:20:00 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85df04ff24sm19661834a12.14.2026.06.09.15.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 15:20:00 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , Zhang Wei , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), linuxppc-dev@lists.ozlabs.org (open list:FREESCALE DMA DRIVER), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv3 08/15] dmaengine: fsldma: convert to platform_get_irq_optional() Date: Tue, 9 Jun 2026 15:19:19 -0700 Message-ID: <20260609221926.35538-9-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609221926.35538-1-rosenp@gmail.com> References: <20260609221926.35538-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the per-controller irq_of_parse_and_map() call with platform_get_irq_optional(). The controller IRQ is optional -- when absent (-ENXIO) the driver falls back to per-channel IRQs. Any other error is treated as fatal. The corresponding irq_dispose_mapping() calls in the probe error path and remove function are removed. The per-channel IRQ mapping in fsl_dma_chan_probe() uses a child device_node rather than the platform device's of_node, so it is not converted here. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/fsldma.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index c04a7fbd2ed0..eba194d64105 100644 --- a/drivers/dma/fsldma.c +++ b/drivers/dma/fsldma.c @@ -1213,7 +1213,6 @@ static void fsl_dma_chan_remove(struct fsldma_chan *chan) spin_unlock_bh(&chan->desc_lock); tasklet_kill(&chan->tasklet); - irq_dispose_mapping(chan->irq); list_del(&chan->common.device_node); iounmap(chan->regs); kfree(chan); @@ -1248,7 +1247,14 @@ static int fsldma_of_probe(struct platform_device *op) } /* map the channel IRQ if it exists, but don't hookup the handler yet */ - fdev->irq = irq_of_parse_and_map(op->dev.of_node, 0); + fdev->irq = platform_get_irq_optional(op, 0); + if (fdev->irq < 0) { + if (fdev->irq != -ENXIO) { + err = fdev->irq; + goto out_iounmap; + } + fdev->irq = 0; + } dma_cap_set(DMA_MEMCPY, fdev->common.cap_mask); dma_cap_set(DMA_SLAVE, fdev->common.cap_mask); @@ -1317,7 +1323,7 @@ static int fsldma_of_probe(struct platform_device *op) if (fdev->chan[i]) fsl_dma_chan_remove(fdev->chan[i]); } - irq_dispose_mapping(fdev->irq); +out_iounmap: iounmap(fdev->regs); out_free: kfree(fdev); @@ -1353,7 +1359,6 @@ static void fsldma_of_remove(struct platform_device *op) if (chans[i]) fsl_dma_chan_remove(chans[i]); } - irq_dispose_mapping(fdev->irq); iounmap(fdev->regs); kfree(fdev); -- 2.54.0