From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32262382397 for ; Wed, 10 Jun 2026 06:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781074680; cv=none; b=Hft98jP4EnMYMskrWuqiRcBEhAXABAU5vIRyCst8fY8PSXgPP9GaD6Vl7dtp8/wcpQiPgTGxi+6jL9MCyvPoN/jxK8K0zNwNedA4SBwme/bz98Tu3NJDVgSsRX97Hy0XacxnJZIlRdvB2mandMSMj9K6UZGv1qnrvnmFHQs3Mqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781074680; c=relaxed/simple; bh=WJIzuDJasOYvuMgvG7Z+VZObw0JRQQ1y90Jp3zccoBE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p08rVlKzrUlR71JcHlIfIi2USP66urmraUqDc1fw/myy2tdxA76iINymi8I19DH69EXvbnKXHz28+hitJl/0i+FnvoF+lphvxwmnn6KW9qOkkUe9o6xRiDZMgRaZXbFwHlr2/eTp+as0/ZXgnKkdhSzkrGDmhYS4/mbj4dd18AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JKK3JxOi; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JKK3JxOi" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36ba285e98bso6346958a91.2 for ; Tue, 09 Jun 2026 23:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781074678; x=1781679478; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2IpAF7CoB1il0GFwhvQu8VHaL8UO9qbHKNoxbe0clO0=; b=JKK3JxOihUx+XZG5f/CZb0zKT8Ww31/kPG7dWjlE2qMQOsxpQ7LUGrvl1r4GQe/dYg +enDDZx+QVGRUR2711ekCE4SsnoQlf8Uz6SIzFLW5PlDbCna6MFEjPFsWd9uGS4q5yA1 0Lyqts+9y10tOE1C6lE/YD5y18uNZkVwz9ELUxT6ogSJEOgZWeF/HG7nehtiZFR/gnAS 0vwNeRxGE7grZFbxfEavBdgthfXyXwv83/jlDGajo6POcFB/wkbQQ6xG4u7fYtGEIKYl I/whaMsSaABpjTf1NGySjUS4AmL7D4cGZ5WUd9/nWUwbD1+u1vOkmphCuWecg4rq0kds +uKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781074678; x=1781679478; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2IpAF7CoB1il0GFwhvQu8VHaL8UO9qbHKNoxbe0clO0=; b=WTJ6HcODi/ujJEbWrwPxo7hSW9+42BHdMopoGPVrOIjfc7ohp3xZkZR9/wrjuB5vzL t9qvt8QSCy7n4l83laLhbNmciAaOkslnmgszuQz6+KxMjFGcYVX7srcehiFxbPae8sxA D9X9j/7mtmc76Q6bIdC0t/ZDqJKrBtyr/+ZeWvJYzKmqK6lWgN5lvaVh3h88rgTAM+LV fs3qIF2Pd+maxSEuoSCbrxWl9Z6Vu/+qd1qRULFdb5f0IfJQ13wroXEhYMe8ruZRusL+ pqGfeKn1NwD8IZWydWo3yxM0eCQ9EWtybs8eGceurOFDnBfuzdH9WQxcfXBN3Q0lxYhs JkqQ== X-Forwarded-Encrypted: i=1; AFNElJ9q8Kcoc1DoguZn8o//x5hrZ0RKx9ChpXd7tvG3C0z76KTGs3NGrjwwOKP8VTYED/Z6V1dzqny4sf+TvHY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5hDzbXMzbDb+i4Y82HpgjdwZ2K6hEQJ7ms8QJ2T9VWAJ4QYSs ZQOfenb1aFFj6AiY0/xogOiKHnhRwk0i2W5FgMDUPUOfaMGJylIX1nKvFCN2o9sz X-Gm-Gg: Acq92OFyWDv66y14p6VEPPISc11ztmy0eL4qOfEEuthFXMO2rvp9JKzl6qh3H/kQdKp GKvMqFtRT1FduNEL15+PG97e+0JNnpS2kE2TfNhxpgjZgexyKnCgTqtFL7d42J57k8OK/1AiZYv PLwRi7Z0K3p3jGYpk+BDXWRm64rnJd07Ol16/JxSVMiuk+kps3RzC5oj95zwfVahlqKpOihI4hK IlFa1BqtKnbOrH7AutZjRjdb5IWNFtqcbTYr/bheF2LdirrB8FQxNfxJuEsZd61+4qRVd0uSKiX AQqEvSAZUPdtQNA7GGB/E1QDVTN+cmCEbacynHK4rwXJtFdzWAZFZMf9dwnZA85PWbAHiftZO1s o4P4EV3Vvxj+JukC91mSWI5P6uUVuu2fQOAguRpZzQTTxik5Xe8ZMM+IrlaEhrxzHEznlFRSgyR iA3B2sE+O8pBbzeN/hUt6Ru2uroOXziVFkJDbgpoOA8Jt77IBGvc5XbDm+NlLW8Q8Cvx8pv9YXt qF3GsjkTRD4gdDAw3rc8lPvAaKFAFjQlHIKwVwiJOvFGA== X-Received: by 2002:a17:90b:558b:b0:369:de03:29c8 with SMTP id 98e67ed59e1d1-370f122c744mr31101897a91.23.1781074678486; Tue, 09 Jun 2026 23:57:58 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36f6bf830b2sm20064781a91.4.2026.06.09.23.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2026 23:57:57 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Vinod Koul , Frank Li , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] dma: mv_xor: add missing platform remove function Date: Tue, 9 Jun 2026 23:57:36 -0700 Message-ID: <20260610065737.118211-3-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260610065737.118211-1-rosenp@gmail.com> References: <20260610065737.118211-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was missing a remove callback, so channels, DMA devices, and IRQs were never cleaned up on driver unbind. Implement mv_xor_remove to undo probe, patterned after the existing error path. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/dma/mv_xor.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c index a97fa0038652..3fc39cca7cbd 100644 --- a/drivers/dma/mv_xor.c +++ b/drivers/dma/mv_xor.c @@ -1452,8 +1452,22 @@ static int mv_xor_probe(struct platform_device *pdev) return ret; } +static void mv_xor_remove(struct platform_device *pdev) +{ + struct mv_xor_device *xordev = platform_get_drvdata(pdev); + int i; + + for (i = 0; i < MV_XOR_MAX_CHANNELS; i++) + if (xordev->channels[i]) { + mv_xor_channel_remove(xordev->channels[i]); + if (pdev->dev.of_node) + irq_dispose_mapping(xordev->channels[i]->irq); + } +} + static struct platform_driver mv_xor_driver = { .probe = mv_xor_probe, + .remove = mv_xor_remove, .suspend = mv_xor_suspend, .resume = mv_xor_resume, .driver = { -- 2.54.0