From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A58A304BDF for ; Wed, 10 Jun 2026 21:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781128616; cv=none; b=TWn8VpAq/OmFP119ef34qllJFL3mGqa67TWPTFBBhiLnShSM2y+r0DKM3F3HD+0nKeT/KXBHCbJnfOk1WCMNXMikNivMISHvRgRXNhat7MAY+fwdZit04fMHvI05VKHyOI0rL1Y5ONCjHkRu3FTAhCqSXQONFXvKwXoamuqAMUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781128616; c=relaxed/simple; bh=7j+dNQOA13yRH4BVPpXE0SQ8gv7p+/ml66i5E7IgQsU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G/2oBlvmJ38Sfcl4sDbfcJ7ugh7FXa9sKo7ZpjGs0UQJnQ+0IMHlZ5EKOUrL6rLbfFfQ0MuUM/pDpC+eNsgBVtP4i8RwTHrwezFgtilJIZmYIrDlr1mYdkpGJOYBL2eAQRLw8XxkD3mlSz/wcxG0jQxvyjipAQxctDSxGk28R0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S+NQzn3/; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S+NQzn3/" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-45ef56d9b67so5691026f8f.2 for ; Wed, 10 Jun 2026 14:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781128613; x=1781733413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yD6ITlqzgHastXjegJzEESG+cmrbmOcZAzF3fxOvMuk=; b=S+NQzn3/TkMMHfxVC5Hma3R0uNrAvMpzLy/LsUiBazyCLm9wUaOSLJq6CIhldE1HrF C30HB7Yetvh50VdSXuaGLtnSy1FGixNsCEbcJH+mluUWOJ2X3s6vfniWA3FmTOvC5RN4 3h7UVz4vjpHU8msPrL/Cpfx6pBqoWveIKAL3YyKn/04mLu/SiZA7Ie5bGiMuBIvtEcTE lLtJen3j/KVnyUtqF4erhl3g8070W8x1uH4UwRO9O/Dp9uiuBCMdRvBnVQxo9WfvTyB1 rMFRfgz3SKWHUs7mQPTptAknQlAHTg2oEdNptMSCjJfmsaarQqBLUcHqDl46L6SpPtWP 4fDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781128613; x=1781733413; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yD6ITlqzgHastXjegJzEESG+cmrbmOcZAzF3fxOvMuk=; b=LRh4SP7OUH3pd1N7SxDBiX6HK/EFTL+0aMgZLrBeKY8oPKU10BZ7Op0CV899t/De7p AApXL5LMZO03LMT+TuQbyp/sloMsj9CUFlgPehFNiUMZHPaGGDKvauIdGR2C0lKPvyOp WlmXs293HszHKK7NV07towAsjghfVeiEpiwz0jmIGGDOf//HdIkhv/x6yE0D1lQWZIfv fbKscBaaOXRSWAL+lGNUVZ9yqf/YDUShMwrCzH50DDYEOXhoIqM1ebU5ElE8drcY0iGW rww2zR42qmLOVLpahdMp4cEw7VOV5zs1CLWStDhaLM/mMaNw0RnBP5UQOM4A9MZP7drw jZBQ== X-Forwarded-Encrypted: i=1; AFNElJ+ly796eiG/jt6JaRyxYYBOAwnP/x7s2rXl17FG7y5BjI+AsMZDimOxGPKtJfwS7isOvHxTuG7wU8Ot4z4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5sF8dpKLBE2tlsvTuk+ss1Pc91PL2rhFJ13bCbGQ6iuj1bDLK YNEUpEp4kgngL2/FYV264Js+Lny/5WXtuVW1/83vU/7XGhH6az+Z5t/q X-Gm-Gg: Acq92OHMnS9APdJu8cnU1ccigqLtLm3DYzC2KanQP7RIqAgdKHKr62mOzzSW8ouCTb4 +bn2U+YEpRsMkyIvOVFNisQIBmycXWm016dqEaYe6Oe8Ej8KAgnF9eao9277TLq+PZks480nBT1 JvYUil9cbdBhslF0WeIK2s6J/NPvr6PoMjrL4niIHxh1ZOiQi+9Xas6XbYp/dD46qOzu7jU9uIv m0ilkRnrmIte7xHLvueUwa9Bd/56+gzVFx7gX1H9T4ohS0i+e4HIVRB4nF06x2wpKTQyFqxrBPb hQrwhW2N/yosrbLPKafaMSwct1iPOnkGHcDxmfO/77jPPRoiA7FA8N+THhTp62GjgVP7KLa+8DR tQkKRdeiFqpH9k4R2dmEmockRzao6SSB5pinbvc4DuuW75unqUgGUcV7KDpnei/1QSDTLPCQxPL n4R/7yBFkIwgF0mvVnyjZ2OAbJATZdIJC5TQxs6Q0g2rIrgVc/nA0ppQXStfJZ4FYcoh5q+3zaF BvpcL6jyH8GqSBTvueeMg== X-Received: by 2002:a5d:64cf:0:b0:45e:f29d:d438 with SMTP id ffacd0b85a97d-460677ce9d6mr55947f8f.28.1781128612832; Wed, 10 Jun 2026 14:56:52 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35fd33sm81407452f8f.35.2026.06.10.14.56.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 14:56:52 -0700 (PDT) From: David Carlier To: Daniel Scally , Jacopo Mondi Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, David Carlier , stable@vger.kernel.org Subject: [PATCH] media: mali-c55: Fix scaler factor overflow for large crop sizes Date: Wed, 10 Jun 2026 22:56:48 +0100 Message-ID: <20260610215649.98274-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The horizontal and vertical scaling factors multiply the crop dimensions by MALI_C55_RSZ_SCALER_FACTOR, a Q4.20 factor of (1 << 20). Both operands are 32-bit, so the multiplication wraps before the result is stored in the u64 scale variables. For any crop dimension of 4096 or more (the maximum is 8192) the value overflows; an 8192 to 4096 downscale yields a TINC of zero, so the scaler never advances and the output is corrupted. Cast the crop dimensions to u64 before the multiplication. Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- drivers/media/platform/arm/mali-c55/mali-c55-resizer.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c b/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c index c4f46651d..0713e7d43 100644 --- a/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c +++ b/drivers/media/platform/arm/mali-c55/mali-c55-resizer.c @@ -422,8 +422,8 @@ static int mali_c55_rsz_program_resizer(struct mali_c55_resizer *rsz, mali_c55_resizer_program_coefficients(rsz); /* Program the V/H scaling factor in Q4.20 format. */ - h_scale = crop->width * MALI_C55_RSZ_SCALER_FACTOR; - v_scale = crop->height * MALI_C55_RSZ_SCALER_FACTOR; + h_scale = (u64)crop->width * MALI_C55_RSZ_SCALER_FACTOR; + v_scale = (u64)crop->height * MALI_C55_RSZ_SCALER_FACTOR; do_div(h_scale, scale->width); do_div(v_scale, scale->height); -- 2.53.0