The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Cc: Thomas Gleixner <tglx@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>
Subject: Re: [PATCH] MIPS: VDSO: Avoid including .got in dynamic segment
Date: Wed, 10 Jun 2026 15:47:45 -0700	[thread overview]
Message-ID: <20260610224745.GA2820589@ax162> (raw)
In-Reply-To: <20260610093311-dcb6efd5-6921-48a6-a97a-8739fe7d3417@linutronix.de>

On Wed, Jun 10, 2026 at 09:45:08AM +0200, Thomas Weißschuh wrote:
> On Tue, Jun 09, 2026 at 06:31:21PM -0700, Nathan Chancellor wrote:
> > The fixes tag feels a little strong since it seems like it has just been
> > luck up until this point that there has been no warning but I decided to
> > be conservative and include it regardless. Feel free to remove it if you
> > see fit.
> 
> I have seen this issue independently from the commit blamed above.
> It occurs at least on commit 2b7a25df823d ("Merge tag 'mm-nonmm-stable-2026-02-18-19-56'
> of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm").
> If you want I can investigate more, but the Fixes above works for me, too.

Maybe it would be better to blame the original vDSO commit then?

Fixes: ebb5e78cc634 ("MIPS: Initial implementation of a VDSO")

I cannot build with LLVM back that far but something tells me that this
could happen back then too just because .got is not described there. I
don't have a strong opinion though, this does not appear to be a
functional issue since llvm-readelf just falls back to using .dynamic
directly IIUC. I guess tglx could make the call during application if he
is okay with that?

-- 
Cheers,
Nathan

  reply	other threads:[~2026-06-10 22:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-10  1:31 [PATCH] MIPS: VDSO: Avoid including .got in dynamic segment Nathan Chancellor
2026-06-10  7:45 ` Thomas Weißschuh
2026-06-10 22:47   ` Nathan Chancellor [this message]
2026-06-10 15:50 ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260610224745.GA2820589@ax162 \
    --to=nathan@kernel.org \
    --cc=justinstitt@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox