From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3F3A33A711 for ; Thu, 11 Jun 2026 03:39:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149166; cv=none; b=F4ZTzW9I2BCcBjWjlsvYEVAKMMslHd7nBD4/SD3PjDIN5f63jRGt2VnrXWStRaieXSf9g6sspGUnbleGF4x/1MOwAnKPAqG6xx9f2+pUazt/8Se0y/ug1Y5Kk0W10YXJZy+7rehXC6uqiAMo8bprHKuoSsmwIPAX5anHMzVUe2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781149166; c=relaxed/simple; bh=cmMm1p6O9Mp3axJclA4sAP6G4alWEw5/lSU36Eie7X4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EX61292eMUcAR4S+4ld+lVPdkIUsNMh8LSjyIX0ib9sm6jFyrtKw7nw/kdiP508KZyG3nnKPBF1ZcjQWWjAMGwEmLOLY3CBuxUWOBiov9xzbEOrwLEXbkNXi7ag7BZLzi7jaLeIYACbNopZj+LQ/KNyT8l6xwCLb7bNvk7O0JIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ai0cgQfP; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ai0cgQfP" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-8423b08b293so3280618b3a.3 for ; Wed, 10 Jun 2026 20:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781149160; x=1781753960; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w+4cm9QbNYmcZl/MXjwCiNY3TdxompycqRGjEnRpi0s=; b=Ai0cgQfPlGbsqJVFjJ6ooooc9vvOirX/FhsIbeh45iuQ5FSVURM2ADxO+9I8gzkNHf 7V2Vns1VsBlLr4DguY6oFSDJ68r7hy7WAUwcPHkEmVbYly4s5bA802zivt4ZcMp4hVMb +3o5va4aP3NvC/HEgV/sIl+78IH0wNX2UowkTh5qWhWFkTby8SGnRYP3mvzKsuWwR5YG GFhlCurePKydVAQdmH4zSU9NkSf/hgpINMh1IVL0Mj8N+cYbPrMcqqmMQvB8lboTmhTT xaLk3CexHgpWBe+pmFpPBgsZZ+cFivNeMGrhCNQuqSeTQ+na45RY+hV5llFvBJEbUsvN dgyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781149160; x=1781753960; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=w+4cm9QbNYmcZl/MXjwCiNY3TdxompycqRGjEnRpi0s=; b=bkeCK7kemB7w7r0ZoJWnKTKJ+305uKXQnz/buhRtg6xYpuvHJap9/lXJfnPfdzI3Kh qLtUmGyiCgkhNFKffhgpXPyToFEN9hIRcP/hQr2W91WzWSuTeF7/y+IY/L1gakTpqZzE W5JZIMU4uNMTOsLksXCJtk4ZayxYKLdSnlq4Cnu5p5ZPVVPBvqeI10UVL08DZRkPr+2t hD4KLaoRZQrc50wOtGJRY4aMgSgLdbXLrEnosOnPzeKqTTlnCBx4WZaiT+ZjksItMfy2 j9Nq2PZV2KRb3PgN0vDCJ8cnM6yuwplZnnuDPGkE8BxOKNyD/8E6zD5eukDeqJoiK9nH /XSA== X-Forwarded-Encrypted: i=1; AFNElJ8YsykxQiJmsXToRp61OLQIpEOElaRu+HLrKiHq9QrN9NfmVRiMhNOCPb/E4TI9xi24B3qBDVHaoql5bNU=@vger.kernel.org X-Gm-Message-State: AOJu0YyFfvrwbnO08v5u1YjOW4GleDioYgq1yVHAG/mykLpIakb6WUfm s0Jy831lMsPmT3mwVNPcEcOC0POiWX5vUJxyFcfn+Xa46noFgqXMduwa X-Gm-Gg: Acq92OFVYHctXCPf7bY6HYwKjpyDgyKrJHcrvWF7bgSESuilZGMEcFjM1vdhRKSfHE1 FwwoNhmrv6HxgLImEU9sgCU9M57yyvL7UQ+7syt1pfKCcGutoNvvTqsuMv9dhz4btCKYcAd/gET pvjvoQcmTJTW5DkT2ypQoEllExVUS2ZH9XEjzeHcgEcsEi1BtxLI+VgaPdkDl9YestrGC076WqP 68mqbSgGJj1GbrAMvUU0i5fN+R7o0/v4wKCd/DzWtguiJihGSIlEL8Ch7g/A+YfzukglCKW69f7 wdiW4Zw0VnSwkwuoDJcqooCyeARW5EW3UoL/JKu6J/Y6h8TnMI9tmvasN64NoH9N8aQbA/EHAXu gr4o0i8caMry6a0hcB8XGwyFUNkuQYMw6Z6igkIUJwjJ9WbDBclAmhB3EKXqbJuvbzNNM8uCjFK oG/lg0/mqAKSmuJgkapB4u8/YbZ7tSaPS+m7tkw7shDKAxAeW1SzycgdcImrTQ9WdfUxCne3Q03 01HK/eJrryTnOtclcFW5ANor9RX2Dh6WNtNXehrdvkYhA== X-Received: by 2002:a05:6a00:194a:b0:842:5ea5:5ff8 with SMTP id d2e1a72fcca58-84336bc62c8mr967189b3a.42.1781149160353; Wed, 10 Jun 2026 20:39:20 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84337bb47eesm334548b3a.13.2026.06.10.20.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 20:39:19 -0700 (PDT) From: Rosen Penev To: linux-serial@vger.kernel.org Cc: Greg Kroah-Hartman , Jiri Slaby , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE) Subject: [PATCHv3 5/6] serial: mxs-auart: clamp RX DMA count to buffer size Date: Wed, 10 Jun 2026 20:38:55 -0700 Message-ID: <20260611033856.6476-6-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260611033856.6476-1-rosenp@gmail.com> References: <20260611033856.6476-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In dma_rx_callback(), the RX count from the hardware status register (AUART_STAT_RXCOUNT_MASK = 0xffff) is passed directly to tty_insert_flip_string() without any bounds check. Since rx_dma_buf is allocated with UART_XMIT_SIZE (4096 bytes), a hardware fault or compromised peripheral reporting a count larger than 4096 would cause an out-of-bounds read, potentially leaking kernel memory. Clamp the count to UART_XMIT_SIZE before use. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/tty/serial/mxs-auart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/mxs-auart.c b/drivers/tty/serial/mxs-auart.c index e2b656638ab3..fe48a372d022 100644 --- a/drivers/tty/serial/mxs-auart.c +++ b/drivers/tty/serial/mxs-auart.c @@ -823,7 +823,7 @@ static void dma_rx_callback(void *arg) stat &= ~(AUART_STAT_OERR | AUART_STAT_BERR | AUART_STAT_PERR | AUART_STAT_FERR); - count = stat & AUART_STAT_RXCOUNT_MASK; + count = min_t(u32, stat & AUART_STAT_RXCOUNT_MASK, UART_XMIT_SIZE); tty_insert_flip_string(port, s->rx_dma_buf, count); mxs_write(stat, s, REG_STAT); -- 2.54.0