From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 366402D0617 for ; Thu, 11 Jun 2026 10:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781174585; cv=none; b=nNwlvme8wg3yA7QYCO6xF7yZ0nT9FcKA0Ammwd9I1iw5kBPaWRshe5XNG+RsY7iRPdrMSopNWxms0vnJvKJ6/Vrp0WgGsrS2bKZwIp1ZASUBx5UVsFP9La15iGt7uF7ZIvG9F6rV5CfDCwDwMZ2BmSLmC0hztki2PmNoOFthNg0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781174585; c=relaxed/simple; bh=inQjxgWwPEtT4CnPw+fCJAJFNMKy78lOn5LXLW2oVNI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qg0iv5/YIRj5/cigQumK6jJvB4+R0OaYqgI/LChwGW1SvEjwnJYSe2YR8GpoF+J31l065Ct7pVJiZu9F+8acWP87i85JK5yRZufTmZt1ooBKqMx4njGexlT3sRv3bP5mb43gOoeKwHWMVPAtVIvC/I2OHuH+5C3yI4/DZyAHVI4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dJtZ0Fcs; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=nsBT5VAW; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dJtZ0Fcs"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="nsBT5VAW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781174583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eTU8IEl2ECfz/odKayZYUlnGxNgbfPhvdxEP2MTzPP0=; b=dJtZ0Fcs5ZpJu6G+qm075Zl4ux/UpF8Xv5bvrrZ9uoE3J7h+aXl0E+q7GbDn+HHRSiFxsc yo0rZHyKkH8epkUaX5iw+PYYD43IsnKoohp16w5mYda4w5k0n7LJcqtcfqV18YZyGKpVgd Hun9q8dO2xgMWeIO/+HKHASbD0/sNrg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-GLele7sQMsuYV1oKfxnXZQ-1; Thu, 11 Jun 2026 06:43:02 -0400 X-MC-Unique: GLele7sQMsuYV1oKfxnXZQ-1 X-Mimecast-MFC-AGG-ID: GLele7sQMsuYV1oKfxnXZQ_1781174581 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-45eec2badc4so3969958f8f.2 for ; Thu, 11 Jun 2026 03:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781174581; x=1781779381; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eTU8IEl2ECfz/odKayZYUlnGxNgbfPhvdxEP2MTzPP0=; b=nsBT5VAWJ5oiWOOYPoFWrZXjs2TMwvOop8eFKcLjDQLdEHPm1648dE5xO3hUAZ32wA d4lr0BxlYDaNbWtOMffxXTJp8pXuVHt+X461/W/l9L3dNmsMOGlA1++p1JWIq6sa/ziE ffOOleoMgVMt5A65wwaO5vqRoCuX8Xz/zOTWxO6TXwKBg5oEo/lybxNc0Ss52quR8SwJ i8Vt/esFubiBoyBjq4DYvAmG3CWrfSVtfgUsZzcfjxeM8QWvr6c8d41CIWRAIsu7aaxK PU+a9NTNGu3Z6XT0dDW9VFxaPrBxQwiuiAnR5+j0QnWgI0UI6D7vEj7CWWvOqhTl8I3G RRyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781174581; x=1781779381; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eTU8IEl2ECfz/odKayZYUlnGxNgbfPhvdxEP2MTzPP0=; b=JcCPzK1Yh3jN8K6yhI0vtzN7xyx79X6xqgZaKcjSAG9k446ohIJTxLFsU4a7fxqjOa YzZhrtutEjKIBVfIP2erSxcJw5bhZWSyz0yyEXK2X4228k5SmTN1EMCofYuMXWDWlsbq cGLO2e9y0exceFJgbtxAbxFf5fHow/T/A7hWshG5PzAYhgqukf775yo2AiAIi6lftrr/ PbuEZfdN/QWlkkLTXuElIEo6HMlilWwPzs1Lvm1fDgFIBgGaI5QUYnnsol6G8deTQgIw Reo00yMP9xdTLuq879TT2R1WlEZJDEL3haZ3+Hrr4e2dwziYgNTYDs2qAuRPQrrW4hM8 SLLQ== X-Forwarded-Encrypted: i=1; AFNElJ/+PYd/KEgETRU3j7r4J0KGb7w1+JbFGBZe8RgvPpxLBZdsA32OkkQpTbzhkX1d35yAZRUK2ZBlUdvJEb0=@vger.kernel.org X-Gm-Message-State: AOJu0YwR/mJSJzG+9I3MuBdb58vzLj5qhdZLl3sGhSp2lfUBMNQV3qCB FQ/OWiivaf3xa8sEX0CHbexd/BQzL34ucPssE2jelLgNdheQBhLqSQs7F/MeS9icPWSaL1dPZUK 5KO4mvlYMSFz9Ao1NoJHTEPCEKizLBBVnqvsCXVwGefVzMnvxAeP3gT9V+Nb2px+XrA== X-Gm-Gg: Acq92OHawmHC0T8KpuepExd9VtQ20w4tJ8uUWylea/szRLSJ5kEIibVwD6kpu5rUFJz qTsEQ0vQZaKnQThPdeVSR399sPMRuc0xiflV4SEfENPQ9oOXRPG9H4DOmSumRXxA4C4lmfWpjJm Vd41oyl1hSl7Pqw7vug3cNcbl4H4Vw1PVewYokt8qD2ljF9NuqtdLYod6vITQiB5bRsUIaM99YH FeLhTLK+ah70F46sV5+c3kJFvR7ydqUCszcECklvEm8PtOpSiQNpy1QQL3PvBMgjIrRj5/hJ/pc bA/FJCSIE4ZA7oB98LLEp5YgyyLrsVtr2vzXx2oxYFjG7irFgqFW/JyYQJIaynwmh9zoy9fh6xP vSZgIghYsulYEoizrTMS5lDH1j5kKgCqdfzm0vuNJRK4alu2W54uwzg== X-Received: by 2002:a05:600c:b96:b0:490:be14:bfda with SMTP id 5b1f17b1804b1-490e55baa3cmr26317085e9.6.1781174580808; Thu, 11 Jun 2026 03:43:00 -0700 (PDT) X-Received: by 2002:a05:600c:b96:b0:490:be14:bfda with SMTP id 5b1f17b1804b1-490e55baa3cmr26316475e9.6.1781174580281; Thu, 11 Jun 2026 03:43:00 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f344762sm84495116f8f.23.2026.06.11.03.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 03:42:59 -0700 (PDT) Date: Thu, 11 Jun 2026 06:42:56 -0400 From: "Michael S. Tsirkin" To: Herbert Xu Cc: Michael Bommarito , Olivia Mackall , linux-crypto@vger.kernel.org, Jason Wang , Kees Cook , Christian Borntraeger , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Williams , Ingo Molnar , "H. Peter Anvin" , torvalds@linux-foundation.org, alan@linux.intel.com, tglx@linutronix.de Subject: Re: [PATCH v3] hwrng: virtio: clamp device-reported used.len at copy_data() Message-ID: <20260611064040-mutt-send-email-mst@kernel.org> References: <20260531142251.2792061-1-michael.bommarito@gmail.com> <20260611025916-mutt-send-email-mst@kernel.org> <20260611035035-mutt-send-email-mst@kernel.org> <20260611050731-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jun 11, 2026 at 05:19:26PM +0800, Herbert Xu wrote: > On Thu, Jun 11, 2026 at 05:10:32AM -0400, Michael S. Tsirkin wrote: > > > > data_avail is under hypervisor control > > > > avail = min_t(unsigned int, vi->data_avail, sizeof(vi->data)); > > if (vi->data_idx >= avail) { > > vi->data_idx = 0; > > > > and maybe this can speculate past the if? > > > > I agree, this is all speculation ) > > Either it is vulnerable to Spectre, or it isn't. Adding nospec > markers when you're not sure is cargo cult programming. AKA defence is depth programming) Alright we can drop this. No biggie. -- MST