From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45BAD3B42CA for ; Thu, 11 Jun 2026 07:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781161791; cv=none; b=mhr00LbFiz4ezYIYpKjQTSpJq7w9RmP7UHTq+GTjDP7GMgL0uXZkF8f1lwNAbD/WsvqHq2HLEx10+gBogGNn8N+90jrMleY8iyrIhI+OqnE7kEntoiN8sRxwXjJWUM8BRbXbQkh+SMOFMoekkVo3G5gL+D/9h6K3+MKfTqtLzAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781161791; c=relaxed/simple; bh=IKO12KcgDP0OMKzs9zbTXFZ45kmsBccLGC6hECGVoes=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YoVcBTQj0cM7y49DybvbMhZKM+KUo+QXe4uIaO0ktsm0UHaIUbwsJ6ms9ji7btOK3MIVTMTVSpsRZNmH9CeJg77jFQikBUjbAiae9FcoYM1TL2VFiASbVdIlvYFvMu1fFRztGmvnHc4NbsQp7yD2APDTbYdDqp0+3Ef6MoRXU6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PNC45Vph; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PNC45Vph" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2bf20f6be6bso60337965ad.3 for ; Thu, 11 Jun 2026 00:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781161789; x=1781766589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n4R2Iy9HQQbE66UKxWqI1tK/Xn2Y0sSn/4Eic9bhbjQ=; b=PNC45VphnfWkCR6nhgP6lgd0BorRwf18qcxyv6x0taKfQmPdsoySHNyFTqBqEHJ7EN KAIjjT60OqeK7gUb9nSabRmpzx1Nq/SsHZk6C7TOSzl51+273Cay7sqeVtuLO/nQjY00 ugUhHhWA/c72gFqY/YiaiiXbfFe2MX95Mcz5jfA9YQEdZDLrrHYGyIKg/DMh8XxuuVv3 XyAL7m6rvkMlzoDiSYwbyBtkhlA6BmWAtfJtsz28b9cqCOnmurw7U8y+KaeicmMQhoOm iX+3SEZy2v4mziCUffANKiTk7iYSnJQL2JJhp6eraALEdPv5KT7acwocEquzlRxLfA8h 7OSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781161789; x=1781766589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n4R2Iy9HQQbE66UKxWqI1tK/Xn2Y0sSn/4Eic9bhbjQ=; b=reK7eHISvEJLsRVNvH0Mmn1FubisCtmUO/jQ28bjXTbb06W7cXY0HNDrDGeL4XJEHc heh5AZnadYdLOQFp3FnOp77G2U3bWUW1ViBiz0be2F9JKHQWL/oZfKG5LTykVxuy4Hys xC7zrQEBbs6bA7t/u1Rqca5R7L+7Y9En1v6axYpOFG6/ZuinOJ9Q1/10xPukRNxf4kWR s2FSg7PQM09ycafiWnpR/J8tUp10OaE3bjMxisaFIJejjnU/lneqGatc4aBh1nJyODJv ZxNQcYWGavJEBeu3op/Xu82lf+YPY/EkHD/SaSzoLF73eTGo6CefpYWgnOeRyBCeRhLp mBKA== X-Forwarded-Encrypted: i=1; AFNElJ/qQObWWJeG8Ss1rn7PHEFk5AEv7wdce1M/ffXnGOhEN2bzC3c3TmU/tM5HliYrcoKs0W0QGv6fx7l8T/o=@vger.kernel.org X-Gm-Message-State: AOJu0YxAJs8pl4NToYPpsOonAlqpTbz1kndR4lrzNvGPp4fJZ7hoWZ8k TVQ2UBqGR8685ruMfHuov52uEM9UKaNtdtYGSaJ5DV+5CrHNQwk5Yi1a X-Gm-Gg: Acq92OH0mx1U6ctWXmdx9p9O9lOSCebrNStUlPzq+yZnT8uKKnPuuHGHstvrJb/EqJx wcocFS88JzY6KrVtXJvkP+PAs/8jW2ueAdeKaCZMZCQr0O24HQgaSTaYAoZ4GOqf2m5tArNqjmT R2sNV3ATZs88LDjoT7emp9cIEFMg2kaewAn5cpbsPBmoNxuxH2+cTppa8whjKeCmpi1QRPO36pr z2gtI15AW+Ru4j14g3gFiqFarXD3VQ2Yzs59h+SlwJQIGnjNXEQDb3N2uzAVHRy5y0VxqacujyW fhRW103hHZW8Q4evezuvesuDuor+bxACg9PRKiXVRxkNcgJngYJgPu7PvMeeBIbY4dL8ZXKXXMM PbzeI46B/rWMKL/U8vXRgGrxXUGxLG6chx/gj+YsmA3wvmeP7BJafqK0axTEqi9xtAUAqPbT7KE 0caBAA3CXJaB8dgCtGuz5tysvyxj/5oIIAjSTTP654AR67VFGo59d5r2JN65bD X-Received: by 2002:a17:903:22c9:b0:2c0:b6c7:227e with SMTP id d9443c01a7336-2c2f0731f7emr19720455ad.5.1781161788709; Thu, 11 Jun 2026 00:09:48 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:661d:3046::4cf:39]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c2d9bb2199sm18818975ad.77.2026.06.11.00.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 00:09:48 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Florian Fainelli , Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kurt Kanzenbach , Jiri Pirko , Simon Horman , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 5/5] devlink: Warn on resource ID collision with PARENT_TOP Date: Thu, 11 Jun 2026 15:08:51 +0800 Message-ID: <20260611070856.889700-6-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260611070856.889700-1-mmyangfl@gmail.com> References: <20260611070856.889700-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ID 0 serves as the sentinel DEVLINK_RESOURCE_ID_PARENT_TOP to mark top-level resources. While it is technically possible to use 0 as a real resource ID, a user might be tempted to write: enum { MY_RESOURCE_ID_A, /* == DEVLINK_RESOURCE_ID_PARENT_TOP ! */ MY_RESOURCE_ID_B, MY_RESOURCE_ID_C, MY_RESOURCE_ID_D, ... }; register(..., MY_RESOURCE_ID_C, DEVLINK_RESOURCE_ID_PARENT_TOP, ...); register(..., MY_RESOURCE_ID_D, MY_RESOURCE_ID_C, ...); /* D is a child of C */ register(..., MY_RESOURCE_ID_A, DEVLINK_RESOURCE_ID_PARENT_TOP, ...); register(..., MY_RESOURCE_ID_B, MY_RESOURCE_ID_A, ...); /* Is B intentionally top-level, or is it actually a child of A? */ Add a WARN_ON() to catch this and prevent confusion. Signed-off-by: David Yang --- net/devlink/resource.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/devlink/resource.c b/net/devlink/resource.c index 3d2f42bc2fb5..574108ccfe5d 100644 --- a/net/devlink/resource.c +++ b/net/devlink/resource.c @@ -486,6 +486,8 @@ __devl_resource_register(struct devlink *devlink, struct list_head *resource_list; bool top_hierarchy; + WARN_ON(resource_id == DEVLINK_RESOURCE_ID_PARENT_TOP); + lockdep_assert_held(&devlink->lock); top_hierarchy = parent_resource_id == DEVLINK_RESOURCE_ID_PARENT_TOP; -- 2.53.0