From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05FDC364E92 for ; Thu, 11 Jun 2026 07:29:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781162963; cv=none; b=st+dnUiffLwMoTlGSSwdjMUh65fd8Q0EDz68hbFTfO+peTupSuyczdjads0o9hNwdE1e7Acc+DpwWnAoylpJLN3AVdAT6Gqq1d+nCU37SOhwh8yQfM24xxIGIQUa8iAB+PDqZ5gknIxWFP9RNL+A/Z3WURGDD8ZpC9j3GE46WY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781162963; c=relaxed/simple; bh=zTZ9Os93AQKT7+0fhNo6c0IbMZasjMPF3/fzgYRsXzs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BM20rGD6gP+6jAjia5/82xIcd+iLfedZDDo1HPgls1/XfDddN8U4g8iZcaJML2ZLXF5SdRKNcrnttlzxt6rJvoMEHZJnNe7/wcfgUuURHXg75ouxV/G4o5BvGbPrs0Jk0+dizypaVLeYJySObp0Kthu7RW1MVDIHagiSWxtZZqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LlS9gxky; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LlS9gxky" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-490b64c8311so83484175e9.3 for ; Thu, 11 Jun 2026 00:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781162960; x=1781767760; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kLWj6In0UlvucvwDBHBjq5i6uLvtSDMxHxfyE/vi404=; b=LlS9gxkyeA3NPwtWwblrcKLmLNejPwMoRhzVJddVLB1FMGnDSra6gaQlZjVuxx/bwN 6ZI1PVBIy+QcPmQsydAh6hXs5XeFj90sTMv7dFG5DFMz7OJEv0+HYsnpCehwVfTyu/c1 DU/dO4E/MaEBZ3Aaj5RKNDYsMpezapXslzN/w4WcJiiYDH9lHTt0YKG0GBHaE2I+1gp/ 2uQm0AWOLWrGnGIxHwXuuDg9+/vWGzKKNLT6Y1Ys145vhXsXwqPySE40V2VgFMJXdprV rqWA58q38LCayOVSMQKjQPFLAL3F+/NZKafDQf3fB47YLzbTH4X17xCtBa3K7VnDhlc8 aY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781162960; x=1781767760; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kLWj6In0UlvucvwDBHBjq5i6uLvtSDMxHxfyE/vi404=; b=W2YSXI8rKG6WJzDqYvqLgR+zmB3Gz4kttLOhZSYP5BJGjAzKSx4hHz62Rc5RNh0ALn jbIyM1hYbUyXvw4d8H4NpjcMwfbuNdvOaibsqKPjjE+W7HjHQzw2TPrhB/GchEJrlBIP 0oITduJnmZNKbbhHcYI/G5WMldWccF9FH6Bslfwd4+Zmh1v6Um+WqpjPDTvpdxRd5f3s uPRtOcHw14lKCSoCEw7rOXXdFOfwakflKYXz3xttFqN4QeQr/BkiIMop/J6WQTLD8pEn Q3mwzvGFtyQo6JTBrA5aV5w7uUIpaI2UkAZJw7hC+wIhpvPxs1L/MiNawLcAfHRwWVxC 9ntg== X-Forwarded-Encrypted: i=1; AFNElJ89/9mdhRY/OB/byAsOoZ6NWaXwHhD3Omti2rjyHDdSzRaJjuJOxX/TKD0zPY9tvL7vcVoBPY3+hVhnCmg=@vger.kernel.org X-Gm-Message-State: AOJu0YyBPWe0d4NxcPSnOG8UGTRDflrC5Xr4hPVtOZW90foa3TopHGOO h5GLDxxHxhf1YDMKXzLq3h8lplTZ1guK5IJJEXCxFlABf2ACa84rAkgJRnx/mQ== X-Gm-Gg: Acq92OFzn1Q8Vymt/hduUWC5OApJjkWt2JVgG/QAXOxF9d3I8WqqgRH4fj8BilDZZdb cZf2mJzhRkMCMexD5Q37XPHnDKmkNCdhrhAuOQCISVFzsaCXVuREnoH3YA2fBkdmxYC7EhqdRp3 tqbQhHqEiCIhtCz5IEQ8zphrGR7DfKZ9Ne5Ph7rzEifA4a41IMejKXExcvXOb3uMtfZ37zYlKcO ZyJfNI3loLvpS2aY2BDaDg6CRt+oogrmIlsQ4hMZKsLNmAZBkSuZIJmHpWL9UcIG/wZhbAo3UTE uT1iP9zQ7kQedKy+V3nTCtcXOUyDHBnTY0U/STtvxEcq4wNmhMiQBWhBDKQGGDNBQHgMa1DVl7v VbKMV7kvgYIdxKLOVRNcqz+ov0XfSJw2dX8tOUgBT641WZOPv0asHB3CE4zfPKP4J03m8Betyol mFVc/0kGqKRtNgnSx39yoSFFhA94Pmv894Lls5fsa5Hd4ZNUi85kLCRzwmA9FiSbgy9vzW9xvhI RRaUDNwC/ewVZ6y+sGwJorLZyIDTA85fnybWZFW X-Received: by 2002:a05:600c:570b:b0:490:e19b:bd99 with SMTP id 5b1f17b1804b1-490e5628910mr12983235e9.30.1781162960308; Thu, 11 Jun 2026 00:29:20 -0700 (PDT) Received: from workstation.speedport.ip (p200300d507395eb363324778b2a2e5aa.dip0.t-ipconnect.de. [2003:d5:739:5eb3:6332:4778:b2a2:e5aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e5314dedsm30487825e9.9.2026.06.11.00.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 00:29:19 -0700 (PDT) From: Mert Seftali To: Hans de Goede , Mauro Carvalho Chehab Cc: Andy Shevchenko , Kees Cook , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mert Seftali Subject: [PATCH v3] media: atomisp: gmin: Use str_on_off() helper Date: Thu, 11 Jun 2026 09:28:52 +0200 Message-ID: <20260611072852.20777-1-mertsftl@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the open-coded "on" : "off" ternary with the standard str_on_off() helper from . This improves readability and reuses the kernel's existing string helper instead of duplicating the literals. No functional change intended. Signed-off-by: Mert Seftali Reviewed-by: Kees Cook Reviewed-by: Andy Shevchenko --- Changes in v3: - Collect Reviewed-by tag from Kees Cook. - No code changes since v2. drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c index 4026e98c5845..cb60cb3fab48 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c @@ -13,6 +13,8 @@ #include #include #include +#include + #include "../../include/linux/atomisp_platform.h" #include "../../include/linux/atomisp_gmin_platform.h" @@ -916,8 +918,7 @@ static int gmin_acpi_pm_ctrl(struct v4l2_subdev *subdev, int on) if (gs->clock_on == on) return 0; - dev_dbg(subdev->dev, "Setting power state to %s\n", - on ? "on" : "off"); + dev_dbg(subdev->dev, "Setting power state to %s\n", str_on_off(on)); if (on) ret = acpi_device_set_power(adev, @@ -930,7 +931,7 @@ static int gmin_acpi_pm_ctrl(struct v4l2_subdev *subdev, int on) gs->clock_on = on; else dev_err(subdev->dev, "Couldn't set power state to %s\n", - on ? "on" : "off"); + str_on_off(on)); return ret; } -- 2.54.0