From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4374740683D for ; Thu, 11 Jun 2026 14:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781187137; cv=none; b=U7JRXRkT1NNd+w6rBmE4QThAxpwPsBZIK83d7P6ot15zwEgrXEfNESMomGuI+LyRzvcXz10SIuqDGThFQHLLgz7CIn+7773sHM7uRrSNub7TmwwT3dLUbOdTikdGwnRGfcZIOoWME6GyblfShcZTt3Qwo+u+zKgnJ6T4/lD0Dko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781187137; c=relaxed/simple; bh=sQeuR4owy4vX0IS15ajkyCUjrvN0HyfK66H9HDiTaLE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Cm5F+KS6qUByKf/HBCXiSv4gM4DSHpN6EerUsZYPs/qkXoOAMlla8EeiqjmXKiFPpuXlCUGDGHMYJeCjE8vNStUd+zqUr8bSe18nllWKBN9BFKMSF8jTO+L84HI1PakkkyZLpcaRmNOwT9xs9WDhhhAMLE2Nhd4zp8KJ316Znmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZI+WdGg5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=i4KiLaI2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZI+WdGg5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="i4KiLaI2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781187135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5tc2CbHnfT965SsW89vV2H3dWMtMCRgjtBX+OD0OWEw=; b=ZI+WdGg5xiuq1vN1xhYowVfgn8j2oP93sNg+TX8AQUhJaAcV/osHZW1q3BhjzOg364Il2x AOj6IdGWWXJmn6kUKGHIGScUd8TGBujPze7kIdP+A4PJh7lNYHfRnrJc5v5GdnEZclY4HA tZx7Wgqn8jkVzLq4AAt+M8o9hRN+8IU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-380-0L2FbtdhP2afUYEih_0VUg-1; Thu, 11 Jun 2026 10:12:13 -0400 X-MC-Unique: 0L2FbtdhP2afUYEih_0VUg-1 X-Mimecast-MFC-AGG-ID: 0L2FbtdhP2afUYEih_0VUg_1781187132 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-45eef10d5ebso4185721f8f.0 for ; Thu, 11 Jun 2026 07:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781187132; x=1781791932; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5tc2CbHnfT965SsW89vV2H3dWMtMCRgjtBX+OD0OWEw=; b=i4KiLaI2OnOc0k9KySHuMu4wOgVOWO9Hk0w3oYB0piWUDCa9/n74rDOX7Xm9TTTFlG xC4fwExHpX7EZsZSFrn15roEEP6hiLNAgqqIMVqCvZM+/jr1aiZG1GMRETWe9NSNoDk7 Wy/zhH+2wZCxtOmKCNrj0xpdftTeb0DSDioCDN3Z2q6NA505+jmDCsaRxtLgp0MmAqY5 ykRxDQlxX1eXADsRJT7RPGQCz+m5HrgO6lTWT5CE6q1uTQxCrnclFHctWcK+fYGWHWaa PhkMNNVFOHu5BUsbU/ZiE0ovp8xW3Y9hUZ29BxI2xUSBuqSRQm47ejr7K4hfO/5ghmcZ rWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781187132; x=1781791932; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5tc2CbHnfT965SsW89vV2H3dWMtMCRgjtBX+OD0OWEw=; b=XJyQqG4lJrH/xDdyj195n6JSbUdLnNYC0DxaqV+/PVfxZN0zxakN2tr4mAaOSKRoSc +Gd5Ka5PHdooH0JjeWAe1vbcUcZpJ83hXTA/NnzP+DPU9duXbnLBu+Qr+CalGSlvDYF6 4PzchrB9oIP/dVr3/OXttrziE+JDeRwCU1ihniD0MIePpxdhB94Lu8CgoWkx0hK34k5I OkUjR7l2VQGf7iRJ58pyQ1ia4UEIDI50KQAze0cvsuSCaeHYOA9Qd1p4vSUM6c+SQRz9 vLufv2s3+3skKMGP0X1e1JvGYUO00UT1M1PcFVH/peFwgABeyp4CrLAGlzNde9nlJ0SZ ebGA== X-Forwarded-Encrypted: i=1; AFNElJ/zKOQ0cU9nxKvtYe24IC6FrKh72xBHk8R9VPmjgp/h1XR2AELCPVuXAqHYguNGCxKls/wOcSDJvkt9oCw=@vger.kernel.org X-Gm-Message-State: AOJu0YwC58c69MSjGfPSDnWfFO67Zg42dsi0NIIedbKc2sRNcW0mVvl+ lyAfchbF7hQ76tWwMNZCPqSvx/j4LMmQP4u3IKo/Vhc2mGJskT1aSKJUW5WQEDU6cF4XZYVs+rJ uJEg0M/7VLcPdO/YFIl8PJwx1Hq4AMGTgXn5ICGwalPl9DYENAMrNFJ2gZC/P+SvtNA== X-Gm-Gg: Acq92OHW43sYkbf8H5hvyl7AuDE0HCOk6BH9aax7PBae64Z1tC1UKXP6DVXKNLEw45m pGYYmyE2H825inJdfytUPs80Bcvml/l1mh0sI0OUtv3BeIThX5XTaLsWV5WPhbXXFI2LkfCQzHF dZXJfsIUCMzysiH6Md7j5OpYX0BQ+9U40NdtS/wopW6CFV9sj8B1Pcj550W7Z/di3X4uYzQIlWz USjdn0wHNlrx4b8flNa6FyRuScRTY8GtxuPTjiEIqjH0wFhELWwc+cYbAhsjqNUPXa7jFwFyWvO RpPSYXqq/dD56CiJ3ph9AjI17cdfIkwuiT9+rUNs8eqslOebtlHYvBij1/KH4ZsAC8SOpF51BKN iUCerKmr8YthRS9CBtoedssr2SOs9J941OnJDvHszD9sReGlLQlKJZg== X-Received: by 2002:a05:600c:3511:b0:490:6237:521d with SMTP id 5b1f17b1804b1-490e55d38famr39913515e9.13.1781187131090; Thu, 11 Jun 2026 07:12:11 -0700 (PDT) X-Received: by 2002:a05:600c:3511:b0:490:6237:521d with SMTP id 5b1f17b1804b1-490e55d38famr39912545e9.13.1781187130434; Thu, 11 Jun 2026 07:12:10 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2ca1a43sm73488695e9.8.2026.06.11.07.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 07:12:09 -0700 (PDT) Date: Thu, 11 Jun 2026 10:12:07 -0400 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Maxime Coquelin , Stefano Garzarella , Jason Wang , Xuan Zhuo , Laurent Vivier , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Cindy Lu , Yongji Xie Subject: Re: [PATCH 0/2] Fix lock errors in VDUSE suspend feature Message-ID: <20260611101154-mutt-send-email-mst@kernel.org> References: <20260611133806.198402-1-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260611133806.198402-1-eperezma@redhat.com> On Thu, Jun 11, 2026 at 03:38:04PM +0200, Eugenio Pérez wrote: > Fix wrong ordering at taking semaphore after spinlock and convert the spinlock > take and release into guards, so they are not lost after a return. > > This series goes on top of https://lore.kernel.org/lkml/20260610083452.477759-1-eperezma@redhat.com/ And vduse: Fix error around jumping over a __cleanup() variable does it obliviate that? > --- > It would be great if these can be squashed. > > Eugenio Pérez (2): > vduse: fix not releasing taken semaphore in vduse_dev_queue_irq_work > vduse: not take the device semaphore while holding vq spinlock > > drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > -- > 2.54.0