From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CDC43FBEBC for ; Thu, 11 Jun 2026 14:14:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781187286; cv=none; b=QdnOhzIE/AW3SI92bXAsk/9Vp2hPNU4HLcoACt2rxCSZS2mRQLyjAsjnXVa7BcQ1fdSYU0QN1iEdWIrdhwrr+Wx3xMJPUrsvB+kukwYH/XMp80+K4H5z3P5Lrblw3FlHR+F8sv0v1PIeHx35xqbFyEvxBd1Ei/mX9C4EzHue5tU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781187286; c=relaxed/simple; bh=gfXXJLb0osriWBGidJ0dB7eIOLrIpOF6r/9loXmgON4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PKCV9CGAAfu2GLRBIUws0FruExvW7/aevnPt31XK2BTP6tKTSonfrkJiviUy+pzL3mJPWUmJD5ecp2kohfJHuU1ucO8DjNFmCwpLQeZGp03KD2savsT/4SMMvtmRnsqRCWot29ahFFMkU2GK/+a9Ck48HOmVkmWUP9n4xSBSRlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H3BjUA6U; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=FM9jad3n; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H3BjUA6U"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="FM9jad3n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781187284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pjyIWLCuQzUyfe06LzkWeX0zKL+6OD4pYbYVEYPIpiU=; b=H3BjUA6U2pOBpNBdT2XbfH7qlAYLCxLI1HFspf0pfTA3ZSNQP7acAgtqQyLII1dSZSb1qN 2ZaaXfCE/rS9i4pk8eB6pZcnGLyztJib6hsHu0oNTDlO/nLIUSvVe7lp1ScNWPT2duhx9Q McC67RBiMdIVQQca3BIGEcRE17BeqLk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-593-QCaDXZqjPG-WsmpdIJ3Kdg-1; Thu, 11 Jun 2026 10:14:42 -0400 X-MC-Unique: QCaDXZqjPG-WsmpdIJ3Kdg-1 X-Mimecast-MFC-AGG-ID: QCaDXZqjPG-WsmpdIJ3Kdg_1781187279 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-4600c8cb13aso5015396f8f.1 for ; Thu, 11 Jun 2026 07:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781187279; x=1781792079; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=pjyIWLCuQzUyfe06LzkWeX0zKL+6OD4pYbYVEYPIpiU=; b=FM9jad3nik3Sn7w9/jPyxKnsRvaeeog6n0N+lXBFeIBsuFEsVLWhD7tn6v26s3CIS7 f4D0b89vSfgdiMhbNo2YObWEQxYU4igiEyprfTpxbakspRTE5EmLqWoOKB2vrYSsCqH+ FMxvxn30lOJ3ZZ7jSs+9adfM8/SxLLGRwI4nWbM1pThe2atNnt2Vq0zz7+7gpOjfFcJB YmQrj/jBRXhxQdJ9afZg8IsIQzC83Wro61tYNBuWU4BolbUbfLPlXFdoqEa6GvT1Ajde f9Xbp8mxd6k5n1zSlRMQSDwvySVKf4Whm2U7yBdSPqGnNHIP56ocqhPChONS2mYY92jz Tjmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781187279; x=1781792079; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pjyIWLCuQzUyfe06LzkWeX0zKL+6OD4pYbYVEYPIpiU=; b=gnmbSaMCmbq+qNy83SXXrcTVvvttFcPY8FUPr8ytiAP2ry6Ujy1KrsMNkWL3LOy4Tb ICeg1/BcFVkW7NwqVuQDdt8a3A9Emub1BDFZFQM/SJ0ESJD7a2LbI4HHgQMUL+3iHWN3 Wl28ZDTUAgqX299Qw4mnqZGG9CN38mfTenLHdCWtFqWmjlK/M6MYwTMmucSCzvjGMOde z+YrZe9/rAVo9Lm4U/ZoTY5im22oVGJE1Vwxkcepv7nLDsLtswvgl7dTLGtrI3soVfiR eLnSOTt7FZBsqRVc8Z3xuK70gVnOEn9944qUTz1Znud9MbTTHX5PfBi3WoOxNmVYq/bX dB7Q== X-Forwarded-Encrypted: i=1; AFNElJ8sZcA1GCuxpVwZsyaBEb+8iC02TIZNmlIzNMQ9++NqSMCz8s6Uh+bOnZZ+D4ww/bJ4U4K/qmUxbI0Ubpw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7HvAgrBVVyD9gS5gPEh7J1WErgv0P/VsQzXnP07fCfowK01bi EH3viXG7AnWtEUT+lSOthTqk850KnYUCovBhkE6m+S4AdttaKGIbZuZkAgybAlDLwBFeVktJd38 Gug9DyICga+5okDxNZGciltsbv1+CviM03PYX3tp6mbGoy+bVfTPYJ7lbt5RxZy2VIg== X-Gm-Gg: Acq92OFfRJBa72UZ+uUnGs4BSNdhb6kW97MmMai/A886zwCfOZkhEGoix30OoS4VyvO wuxfqUVPeVwCZWtux8Gf0Yxu0e4wNKJd8F/Zco7cCKybEC5LHveX++ArMW7CK39jXNOtUhzhETo OknV3fMVQvMgIOVISitZOCNeF9fprzo82rEktoZ2u7p14Et93B/AEIYaZ2fgWh4DOLPl5PJewwt cQ39M8F2lPH3w5hJgI+d5ukAPunVoas8BbBiCXLfT3mOEF0B29xalmUmjboPyxIcySnReGa8jFw G4mTEUMD0iczmxxnCP7OMaIZsimBFXT1KYyM8E4QJKsvK7QJzrG0pZNb7u2BE53CwRi9Qx5wbe9 Wbu4K2hpPMRn+4UHxSpFKhavMxSn7ZDfl9eqJaV9/1T6yC9V6uXzLLQ== X-Received: by 2002:a5d:584a:0:b0:44b:5398:4e85 with SMTP id ffacd0b85a97d-460677a62e8mr4628784f8f.22.1781187279154; Thu, 11 Jun 2026 07:14:39 -0700 (PDT) X-Received: by 2002:a5d:584a:0:b0:44b:5398:4e85 with SMTP id ffacd0b85a97d-460677a62e8mr4628703f8f.22.1781187278514; Thu, 11 Jun 2026 07:14:38 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46028a6dce6sm73902362f8f.30.2026.06.11.07.14.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 07:14:38 -0700 (PDT) Date: Thu, 11 Jun 2026 10:14:35 -0400 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Maxime Coquelin , Stefano Garzarella , Jason Wang , Xuan Zhuo , Laurent Vivier , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Cindy Lu , Yongji Xie Subject: Re: [PATCH 0/2] Fix lock errors in VDUSE suspend feature Message-ID: <20260611101422-mutt-send-email-mst@kernel.org> References: <20260611133806.198402-1-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260611133806.198402-1-eperezma@redhat.com> On Thu, Jun 11, 2026 at 03:38:04PM +0200, Eugenio Pérez wrote: > Fix wrong ordering at taking semaphore after spinlock and convert the spinlock > take and release into guards, so they are not lost after a return. > > This series goes on top of https://lore.kernel.org/lkml/20260610083452.477759-1-eperezma@redhat.com/ > --- > It would be great if these can be squashed. if you want that then just send v4. > > Eugenio Pérez (2): > vduse: fix not releasing taken semaphore in vduse_dev_queue_irq_work > vduse: not take the device semaphore while holding vq spinlock > > drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > -- > 2.54.0