From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FCC22AD37 for ; Thu, 11 Jun 2026 14:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781189183; cv=none; b=EQfPrS9A/JjXSXT9fv9EqKabgyD44oAEWFKWvrKaA1Vi9BTaQNnRZ0A1jbHcVR0I+HY45zGh8c1U3mffS7VdN4BYH4r+bwPJOHwTKsMH7NDzgZaSNFJi112+KLgFaPKNiziHua+z3U3eaEtkHMGOWfBMqPFEaisvjfARA4c7sJs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781189183; c=relaxed/simple; bh=HLRZVI/nWRZlQ0fNkl1o80BEAq+WpNTkgdhT/Vbv+Ao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nWtmi2sXfdtJgNrDYmjBZj1pHMF0KG+loG66+ynkMkJ0GY+RMWh+mClvY/50YzqSU1JHUkVSc2frh+Wwd/x8D+nyF9F3UvfZWzGcLSJRJtTsblDMN7uoZBEZj5oiArNS50NVkhSz3R0qvh/ZbionUbgk8bPlhZICDhWsWZTrABw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Lh9pgUGD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=npA9C7cF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Lh9pgUGD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="npA9C7cF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781189180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZCBJLZgel9njZ+2Qcv8LZumt8TieX4eENcyuZdZiuU=; b=Lh9pgUGDfnW1yuCudDS+cu58tejH1OssQGxILtk4sTqQLeBYXzS7WdhtqU3OMMVxV3Gtpr 7za7c1QhFZw0Tu55ZMdXkG/MLHfn6PxC1lZdv8Qo1Y5jgOwUGrMTT8UvJSMWODHFYa+lcs TAMPEKDk+qRsEoWcDyC9ibcPIAfkmk4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-gsXJbB-aP6-X322Wv36caw-1; Thu, 11 Jun 2026 10:46:19 -0400 X-MC-Unique: gsXJbB-aP6-X322Wv36caw-1 X-Mimecast-MFC-AGG-ID: gsXJbB-aP6-X322Wv36caw_1781189178 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-490bde3d239so63587845e9.1 for ; Thu, 11 Jun 2026 07:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781189178; x=1781793978; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=IZCBJLZgel9njZ+2Qcv8LZumt8TieX4eENcyuZdZiuU=; b=npA9C7cFfCLiIrFTYpObsmAuVCrmb96vMbYPpcNnJsT85anZCOB+J9ON4y/9klWv9s DKY9E0x8nxbTysUAOY+3VbYO1QGu8vhWL3wE8fZPBz/idz1B9fiunaT3U1myKD63JiGS bIMJv2sKZsmQrei4s6L/Y9leW6wjesC5kep8wyuGd2iyrh/+YzAiDsCkIPU36CqomRwp kft/anfO+CB8gRcU17SIAuNMV3V+IbFOYLbDP2G/FVFR0x+w24MSZmBg+rzw0EblyhZ5 6/4kLLb/TMA+rbCsKsCpnQo9yzHKXKmPiIJhiwPWMttNG1qBPGwF4xlxJf5XusKM2plM fB6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781189178; x=1781793978; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IZCBJLZgel9njZ+2Qcv8LZumt8TieX4eENcyuZdZiuU=; b=YKSbO9MqWMMD+eJ/DK4Vnt/awHXjHSdorESULrT+Dib+Oxuj8cOfGdaJxp63eK295D uTRdHMYjnnBlzj+cf+c1g4TYR9cVeHZJdgDj+12OmBrn+sRG5AnJXIyB+m3ikV12zEwu OKJavS3MCgnuCiY6sU4aipLCo/mza859Tdm5Yz+d8zPB+eAEsgt9rjNkJufYezWWuNW4 J0rXsuOW14XNSaOMojk06sbMN5SQ7Si/ipJeVd0yOqrrhgvlTE/dzd9xXaUY4chVQmNg msKhcEo6Q8MVLP0b/dXKPfg3WZgWzWNQcm/IT+J9oVebD5nI3UWNPFC4Msj+mxwuUmCB O6hA== X-Forwarded-Encrypted: i=1; AFNElJ9Y1mf6/UH/WwFnqDNuxaRiPQ1C/MssRNBwCEf1NC/dcvzxg0gqHMG97v/WLnyBz8wMN7u8rJ0iiZBtjwI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz832anNfnbjX3nUBX38orpLqkx9o5YWvKhtzLsv1+QTtlXEE4o pKVfyAGtYVsISXUJF2KPkua66xk38fMnLHmNnOxltUoCMxiI0abjNondWHjakBIUABBylNPF1eV +6kTOPcI7IgOXdyZ1fW4CUSnMtnUFQbOzueDmvqi+fzCAneeA538DdzsnykotRFYLnA== X-Gm-Gg: Acq92OEhNfLV5gLPOm31LUj23LwDisn62L/nKRz4kMUEouCxzxNmMiqmFc98k8qF8kx 2PONoLQI2dc3+G16qyME9MXjzvGctY9YAQ8oSQa2v3PCG46vptj4nurwo0HPBY3I/58ZjNn9bqM NmUsJ9P3Dl8BywlfRv0mz8qHBiLHzh0lelfWXsdumucGwjce53rxelbA8ZThyLRok3U7yBUuyGU 3yVieeMijkmxuQM98Mgy0MHv3Mhr4l7n+hzEdoDQSu+/5otI/ue0cr1pQp7/tSLIH3cpBR5/5la gYX48ef39/+Bf2AuFr+2BQ6c81+ipb5bTVvL9zbMVwsmdFtvEozl2jW7xlKkDtq8b6e0p/co4xb n2UzSDhVf7uw//V8Dda18UmUQAZidPEjsKJ0LggO7zUuoh8sIzagGGQ== X-Received: by 2002:a05:600d:8443:10b0:490:6237:5200 with SMTP id 5b1f17b1804b1-490e55df76fmr32011555e9.10.1781189177930; Thu, 11 Jun 2026 07:46:17 -0700 (PDT) X-Received: by 2002:a05:600d:8443:10b0:490:6237:5200 with SMTP id 5b1f17b1804b1-490e55df76fmr32011085e9.10.1781189177421; Thu, 11 Jun 2026 07:46:17 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2d0475asm112317975e9.12.2026.06.11.07.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 07:46:16 -0700 (PDT) Date: Thu, 11 Jun 2026 10:46:14 -0400 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Maxime Coquelin , Stefano Garzarella , Jason Wang , Xuan Zhuo , Laurent Vivier , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Cindy Lu , Yongji Xie Subject: Re: [PATCH 0/2] Fix lock errors in VDUSE suspend feature Message-ID: <20260611104605-mutt-send-email-mst@kernel.org> References: <20260611133806.198402-1-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260611133806.198402-1-eperezma@redhat.com> On Thu, Jun 11, 2026 at 03:38:04PM +0200, Eugenio Pérez wrote: > Fix wrong ordering at taking semaphore after spinlock and convert the spinlock > take and release into guards, so they are not lost after a return. > > This series goes on top of https://lore.kernel.org/lkml/20260610083452.477759-1-eperezma@redhat.com/ does not apply there. > --- > It would be great if these can be squashed. > > Eugenio Pérez (2): > vduse: fix not releasing taken semaphore in vduse_dev_queue_irq_work > vduse: not take the device semaphore while holding vq spinlock > > drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > -- > 2.54.0