From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D8552C0F91 for ; Thu, 11 Jun 2026 14:49:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781189372; cv=none; b=rqbNNjymMsIVVcS7pT0l3ClTIWbhrsdJ76ITERKoR40cG9dEt/w0y/OkpuNraB1vUVWEVnc9iAPBs1aTRu9XWYy/3bt2HKR1FQHVBwceesGU7x7Zpmzz/U+/mzCp5oCxMpLEyKC5Y09N+u91UaorE2WXNsjr6bQlKacE1Myimx4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781189372; c=relaxed/simple; bh=GVR3IzepjIau27q934U4LHfHOmq90DeMvAfprRoWz1I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZkBYOqm/0qIShyl0ns4VtxVm9O6pqUIuf45T+ij62zkfEOICgO2Bq/vTki5fgE+jc5KN57wwzoY9fEE2xRLKmC+Libv7ZWNsmvTyvh9rsrXbmfKj9aQA2cdZEWR78oDzM4XIwn6Oj/UTK8ujhXtOLycBrvzONUJQOFsAaBBzNP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hMrJzXJR; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=UCgI8o16; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hMrJzXJR"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="UCgI8o16" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781189370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N72ufb7CXlxMySq23Pr+DrLKTSb8AC1L0hhig87DTpI=; b=hMrJzXJRwN6yAfXxaB1EgYBPdt2KGD0112HdBMGEXudkvpf/+67VRC11S2Xtat9Cu0HyAc tbs6Q7/VTM8/eYmyy0cUtt1rK3Pp0QQQOzNVADTFkHTsbjUrRdOTrAsyckQoYUTn4YN3wv jYd6fQ6zwuYTLCUh/TEVJ5L/lzEiYZY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-fWvh2F84MRazlG3MU5VsFA-1; Thu, 11 Jun 2026 10:49:29 -0400 X-MC-Unique: fWvh2F84MRazlG3MU5VsFA-1 X-Mimecast-MFC-AGG-ID: fWvh2F84MRazlG3MU5VsFA_1781189368 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-490dad70f95so25574645e9.3 for ; Thu, 11 Jun 2026 07:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781189368; x=1781794168; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=N72ufb7CXlxMySq23Pr+DrLKTSb8AC1L0hhig87DTpI=; b=UCgI8o16xPE9xavnosCngtgr2KmLg8PA7SGCPp6YHBR18EEE5dICD4xLUO+py8Zd+H ign2QeXuA/udlp06iRYWUvrNtiimPQ5ycyOzf2wyKRA9ii8lPGCXIJ+9BffKcsB7nG9i D+1Yp/RuAKvop9hBQiafJmbO51YAKkQiVI1r2WhGADt9kybmLlgYBDO/CjDvy18Xx4GT 4v9a+ORAzFBb2VJ9S5ITQQKfPTTlxeNqXpyujtCk0qzZPpRQQpcMkBNWNDPwQQdQGLEe SRZb3qGoVHEcQ6lcbiFJsA7wN2WffAjmBTqdEtz/gzYDrxHCjhDxsiQ98NsTbU/UGK1q iZvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781189368; x=1781794168; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N72ufb7CXlxMySq23Pr+DrLKTSb8AC1L0hhig87DTpI=; b=CzLGXigmzImLe4xa/+AiPp+JbVyIezEc7ICTTCYSFA3sgIZfM9StwLzSDkzldO746X e31oZhKfnmRYvRzQdwqQKvkFA0HSDY2Gaw0LT9fHXt9MU7dL1xPnanm6VhtwvnWKX4bu ntKXhBOJ7Pk3YWcANsPQczmoA9vbYNTuOuwJncGKsptDf7BAezCKQ7B905aFjjCkSht6 gYCdMBB27dpUEev6gWwl7rTnl6KSoxZ287Y9tMAMJPtNeDmgLqWu+TKS8tgdnGV5ees1 /5ZBnsN0UFTmF68BtNqR59S+bN7TiVUWeJ+sY5b38+/bf0kW1xBLV/Yqak3dpU523kyX OJDg== X-Forwarded-Encrypted: i=1; AFNElJ8qP32BPcAcvEkrWmUzvCwWr6sCWApESpZ6eptRJo4A8q/lAl2Fw8Q270yxtVjd1Ds5i90xmgxpgbbOwnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxCVKhP1EIusVTyh2m3GAGx2j12Tzl4tevPtUvDmi/hZ0NGfH5H sdOwHN2D81jf3sZLORlvxCByY7nDBRe/AyY9IPmstBXkUY9D9qmLQeKa9BNQOF2jycHr1234umf CFQhxTvCLinaAmVIYIafyQaUB3vWDZyujOAqqH82BbLjYE0zQ1QT0dz9ajcrKRaAYPg== X-Gm-Gg: Acq92OFHZY765oXxjElDDrZ1tiki7sPFAJOPyUF9EjXTXQ8fA0X37HucCcaFZn+TpvQ wIbBvE5OVzuA7uu3u2RP3U3haslG8dk1GtFSC08m7Ef+kUX3Fibv8uyE199ppXDxpGKAL4wP9n5 eQWz9YuOIMcyn3REf0EATvmgfLCn7rtZKy+3uyZm+B6b7aocs2cIiClGD0CyAoFayUMMG1aU/UF eD8cA82sXNlpCGib3jvuya572AiHMJds8GF7MFJr5UBugwCAzFIctaauhI35H4/DA3ReKHPessI yxjRVwLEsAmvwUh5KTbiyHpwlyt7Db+/7bxvFKpJdewkRHeYN8lMqcTXnF4itL6pXJ6UU/UsmAN 22SsHAMs9Vq+iDHLvgHOkx2VVes2cbLUmlZNaOsOh+FXz8Pt3hDCsVA== X-Received: by 2002:a05:600c:c493:b0:490:b780:13f7 with SMTP id 5b1f17b1804b1-490e5639b1bmr42945775e9.23.1781189367653; Thu, 11 Jun 2026 07:49:27 -0700 (PDT) X-Received: by 2002:a05:600c:c493:b0:490:b780:13f7 with SMTP id 5b1f17b1804b1-490e5639b1bmr42945295e9.23.1781189367167; Thu, 11 Jun 2026 07:49:27 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2c7ea52sm76480855e9.2.2026.06.11.07.49.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 07:49:26 -0700 (PDT) Date: Thu, 11 Jun 2026 10:49:23 -0400 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Maxime Coquelin , Stefano Garzarella , Jason Wang , Xuan Zhuo , Laurent Vivier , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Cindy Lu , Yongji Xie Subject: Re: [PATCH 0/2] Fix lock errors in VDUSE suspend feature Message-ID: <20260611104914-mutt-send-email-mst@kernel.org> References: <20260611133806.198402-1-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260611133806.198402-1-eperezma@redhat.com> On Thu, Jun 11, 2026 at 03:38:04PM +0200, Eugenio Pérez wrote: > Fix wrong ordering at taking semaphore after spinlock and convert the spinlock > take and release into guards, so they are not lost after a return. > > This series goes on top of https://lore.kernel.org/lkml/20260610083452.477759-1-eperezma@redhat.com/ You mean 20260610-vduse_vq_kick-fix-guard-usage-v1-1-0ce02c08006e@kernel.org actually > --- > It would be great if these can be squashed. > > Eugenio Pérez (2): > vduse: fix not releasing taken semaphore in vduse_dev_queue_irq_work > vduse: not take the device semaphore while holding vq spinlock > > drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > -- > 2.54.0