From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB8E3B8130 for ; Thu, 11 Jun 2026 14:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781189608; cv=none; b=ls2u0UWroq6zBMDNRnW4QpolU5XZLZdUdf6gD27Oa39Aco3Yn/rbq/zAGvq5qEHIzwihvB+zLzw2d3MWU3VDqngItlVC2YuCq4tz4AGniOscf2/cBDZjVL+DHACYgcJEJhZ01bj9QKYPyk4Y2T5ila8u0TsUY+5qFczhBOTWm7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781189608; c=relaxed/simple; bh=ngodjvfSmvKDAhoSAS0ov5UY/Fa9ubei/Hr0+hJ35YY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ifvcUxtJrYWeG9oRunQv8CO4n6OLygvxqNwf5pJNJCMn1z+Vs2YbWC8NNBGxrZ4VwUPqKFmz0+Ta9TvnYO5rIv7JImh6205+SnpX6WXP6Mgv9j82NRpnyvIHOIHbIZuDy+hGpF2lTmacgHLSyHLy3X13/EWne47nIUCB5QcTcao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hcITs+en; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=X1l41zJy; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hcITs+en"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="X1l41zJy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781189606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3w9pl/7ybPBlxrBW6E+7z5shAxFcf8N1LcJaLLuo6Cw=; b=hcITs+enXoGaePquWcqEJP9xEL828x3u9jw6IUhJsxYFHZBRSiAC6YKZ3y9zhxz1/8ACsw 6g29XUYPsiLVyVJrCJBVa93sn8iX/r3KBW5AFL2x97/0qZSCnVWFecj9dZSwSsnlBEKoPp treJzldyMl/otjlbgt6qOH7hvWs2vpA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-BheSuWqiPSmbpXwCaESoZA-1; Thu, 11 Jun 2026 10:53:23 -0400 X-MC-Unique: BheSuWqiPSmbpXwCaESoZA-1 X-Mimecast-MFC-AGG-ID: BheSuWqiPSmbpXwCaESoZA_1781189602 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-46067b07571so506171f8f.1 for ; Thu, 11 Jun 2026 07:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781189602; x=1781794402; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=3w9pl/7ybPBlxrBW6E+7z5shAxFcf8N1LcJaLLuo6Cw=; b=X1l41zJygZcxRqMPDWKEHNENiQ+gK8W8VQxP/uQ0lMVOeNavdLSwUeOwtgiJI3AOYJ XZA+Ku9cEguXYEhi+esZDh/Ye7eLYWZdQ4xIy6CqU9yzaDQP2VqAXHs3Q3vFhbtBlWu3 rMqh8a8f1EPRfSrJeY+wKAD2GSVMxXz0mMW5+NXXpIgkFJ2lPwmPFobZxxvJ5IpSMlU1 kKUQsF0HOSUKNJzVwY8sCFstEVml6TjDK3xBy/M3yGmyuYXGTSfEl3Wf5Xjwx8TAMH24 HSJx/1oIyYImcQcOFuypgQVDCxegLIkHTvRpZhh7uPhQnIfEJ0xXRpq2/oWvN3eowpp2 VE7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781189602; x=1781794402; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3w9pl/7ybPBlxrBW6E+7z5shAxFcf8N1LcJaLLuo6Cw=; b=QXjApARGW3f+N3Qy5GRbt13jWM79nnvAUvPq5hPibF4T5iI6lN9B4ts1p6qDyQOpKc 9GSt0rU+GUyAuVvjqpHBEmDKAPZkEvV9WPJGl876Chasg5e7VK8/ocPxU1qTynCeIYtk GP8WGkT0Gnco22B8EtvYyhyduxN4+sNigMKYgPbo8J+0JoTj5f9VktED19EN+8CauJ6c Z31BcX4M3OZEztSwpxlu+Oi+cqIUraUdsHYOdVdf3SiB06el9u07kp+LjiVcTnaJS6CV BVTBFJrt5YQ2fBvbDgKRn9fCyEPsxEBZdFBIqjsEEi0aLBpVNybe3B8z5EEy6o43egLh Ns2w== X-Forwarded-Encrypted: i=1; AFNElJ8dIkeg4wJkvpY0WGCq4xdnQ0CcZKcBJuhqPWBxowwPUSRZhyjazd18JmBPr5Mh4S4nafCCldAxMO2fsEY=@vger.kernel.org X-Gm-Message-State: AOJu0YxHIQBMQlP/AwCQay24slhmvqEHkxk1dlAv2XqBKaV1cqodgY6n OPPcoDdISJOj4GiHknceV2LVQf+IQ/r57ZGQ88ba6qMwjTWM//DIqs/3P16LknPDYSdWtApxLJZ DHMXnytL4qz3CdX/1pi3OPSIg5KfSw2vxDWOEz4ZOfEixcKeWVPKQsb5XRdz3zKYEXQ== X-Gm-Gg: Acq92OEG3bojML0BkJJWnYgmzZ9oCIRwIN2Z+bzPaPkx012oHaOoZ3uUljXEm35QmC1 AMrxjT/orXxQ1XXtljkgZAXG+RDwjesGXZX5IuLNxm5DWHQwchW0NfVSSPpcdT/Ar0/Eajb0I9Q 3Oi8a929flExyccmU2k79OVcjMKugmb24AnkBOJyW9VJ7oWmBYNf/D0kAdiODd6P3LporzZjAgQ Y6RB2bV/ySGqoTuu8rQbQ32y9zAyJQnxBGxU1T3rsI9rRcN/yMpdJU5qZeLduzCYkk3IAHSc6Rl cQy7iMtMCFinanXLZNSFB1pIiB1d0epa9TKWp8JFmINN1QxjPWe3PefSXFHkE7ZQKQOPmmt2WHu HRTj5Yo9NLLl3t5mEwFlsz4SDvoJj89S3MJ840d3UMH3F2U0zIi/YWQ== X-Received: by 2002:a05:6000:2681:b0:45e:f93a:2069 with SMTP id ffacd0b85a97d-46067c22851mr3992578f8f.23.1781189601890; Thu, 11 Jun 2026 07:53:21 -0700 (PDT) X-Received: by 2002:a05:6000:2681:b0:45e:f93a:2069 with SMTP id ffacd0b85a97d-46067c22851mr3992528f8f.23.1781189601380; Thu, 11 Jun 2026 07:53:21 -0700 (PDT) Received: from redhat.com (IGLD-80-230-85-71.inter.net.il. [80.230.85.71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2dcbe3sm76299890f8f.8.2026.06.11.07.53.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 07:53:20 -0700 (PDT) Date: Thu, 11 Jun 2026 10:53:18 -0400 From: "Michael S. Tsirkin" To: Eugenio =?iso-8859-1?Q?P=E9rez?= Cc: Maxime Coquelin , Stefano Garzarella , Jason Wang , Xuan Zhuo , Laurent Vivier , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Cindy Lu , Yongji Xie Subject: Re: [PATCH 0/2] Fix lock errors in VDUSE suspend feature Message-ID: <20260611105251-mutt-send-email-mst@kernel.org> References: <20260611133806.198402-1-eperezma@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260611133806.198402-1-eperezma@redhat.com> On Thu, Jun 11, 2026 at 03:38:04PM +0200, Eugenio Pérez wrote: > Fix wrong ordering at taking semaphore after spinlock and convert the spinlock > take and release into guards, so they are not lost after a return. > > This series goes on top of https://lore.kernel.org/lkml/20260610083452.477759-1-eperezma@redhat.com/ > --- > It would be great if these can be squashed. ok i figured out the confusion. squashed > > Eugenio Pérez (2): > vduse: fix not releasing taken semaphore in vduse_dev_queue_irq_work > vduse: not take the device semaphore while holding vq spinlock > > drivers/vdpa/vdpa_user/vduse_dev.c | 17 ++++++----------- > 1 file changed, 6 insertions(+), 11 deletions(-) > > -- > 2.54.0