From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85E0638BF89 for ; Fri, 12 Jun 2026 01:34:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781228080; cv=none; b=Zimoe0owzuGk1zhrcLxYHF/YzyCJBLpT+4E71UXTRnNAWAgFhB7PkMY/mB3hcZackgyj1ibvpdhG5EpCXdyyNaMHz7v2J6w4PlNE5BFCLm2eeTCTaF8dWG17L4s5LAkOTkQg7uZr3V3OHTg93hCnUg0Y277fmisX5Zs2Wx9WZ64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781228080; c=relaxed/simple; bh=AJpCk4J32WNyLFxxfpnYHB/kVMhE8euK4GNuaoR7vtA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DUA0pNhp7E0Ok34CHsmpjcrP2ruhoPEMNuM8KSF8ZXSgxNLcPSiWgJvlTZVyzLbISWiAD6wfYJkAAT3nfgbOLMV3r3wmRJHbvw8VhAEQa8l3ov1qm8/rrosrpN2mPmdVaIfF1fMZiG5SaiGokA5RmgHH4NExKurTVEk+/KuFfv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S1wxNE+T; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S1wxNE+T" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-36d8b644473so458435a91.3 for ; Thu, 11 Jun 2026 18:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781228078; x=1781832878; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=54g1mIxlnWdVC1XTdANPpLR1bjjl4JSbtVvv4qaUW8k=; b=S1wxNE+To6CKZTUh5geCmZg9ybnXfcCYWar0tebgJjcXfrUPkTYuH+0w8U8V5OieX8 /jbUP+N/oDyjtfvX7eafv13ednZlPgs1NUxsVvlBFtCuPJwFJNJaFNTGSQTDhDoljkRc O/KKx7+G1Cr//bFc5avAERKapmdkm0MnJvVdbURSJaMaVpfCCBHXdR5A83zqvNOIDkqN O2yN6lSH0N3dwXBZpysmMOjygKHYmjjVOZy+/GuZuTNsQSFzaEQhsmDMv6TCSgUp51Nf ommhHNmcP6A5A7vYNzBlNrwe88rXYDIZxfxw7UckeEQU7WhDLSm+4COO77PYarR5Qq/4 VYag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781228078; x=1781832878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=54g1mIxlnWdVC1XTdANPpLR1bjjl4JSbtVvv4qaUW8k=; b=sFDv8ucBOkPeXauBldvZu6d2awgUOq1rK2tCAP/cxm8JG0SwTitb+hdP/C/DfH6Qh9 MPL68oMzAra9AreoGmsMdVd1GP8KseBzGK6oNqJN/I40nRYJBIgicztMHWLJs19s4Exj DVv9/d7AnzZDAFtC0/HTz66PudgFDxVXMOt/MB8fUrZZkJuT/IBi0KrayBgSlvMcoK9y 06LXa4e0tvzbhsvBbghXSI1Rk4LwP+6unHggmDphrM+c6dtESalaY1vNYOBC3H53KyyL UtkHmgLAcZ0Dvu1CCmpI4GpClKJiVyBmiTIawgXkXGeBe0ytNEa58QlNvasrCpo3S3Zo 4sbA== X-Forwarded-Encrypted: i=1; AFNElJ8UBawsmjNbUQXcut7JPzu8uaEN7vnB2hUL2ZSZPKyYB0RpFNPNrFj/eXxKQqhq7D8MntNS47ccevveFdg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzau3/ozvfMGe/9eEY0FicA8DFYVn4rcKsKVNDyV7WSJYFjTsio LZdTgpchRrpCCM+Z8xvZHuyAOaY3YzSolM8KPtJUjIJsxDpSiKn4OZ0B X-Gm-Gg: Acq92OGf3lxI1YaK0DbJrwEqK+/dMet4jxYyHb0SYEOsMOOjmMYuOmVUgcBOxPqPbOT p8fM4G5NUBQXdN7vppQ8w31Cxrhowz2hnS/zqbHoxAxPrwjx+xZoV0VzllOxXG4zJHs9Re6Am+e rX4uKEK8bHrbVdh9DbCXGZQ3dQ9Z2WQk54+oDeUF0J51hVsXz0okL0Xo98F7l5jD7jZup1kSOV3 jhpKgA3YEo/uftUUpulX1vzwPj1D3txT+edzlRsjSXcUft1eLQegi6E4GJZ00wz0OkZ4IiriffP ooZMFiebp0otRHWwrCZGrcsVkIdz1Sk+eo9ImjWoHjxhPkU45iyy/r0NKRQhoAdNyziqcgaqgHS 0K+GPFUOPqMhPmthaAnYKoNEJ8VvYaup7dxA42ZzEJzkq/DeRMwbTyZ87RlFhgSu2peRSbVKUpy KLE2EbGqOzJOYM76IE6qJhZ3DvGg== X-Received: by 2002:a17:90a:e7ce:b0:36d:ae6a:22ed with SMTP id 98e67ed59e1d1-37a041afaa2mr939962a91.22.1781228077904; Thu, 11 Jun 2026 18:34:37 -0700 (PDT) Received: from wanpengli.. ([2408:822f:1aba:84a0:651:104c:ba0c:1f4a]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-37a1f07bbfdsm250713a91.5.2026.06.11.18.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 18:34:37 -0700 (PDT) From: Wanpeng Li To: Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Paolo Bonzini , Sean Christopherson Cc: K Prateek Nayak , Christian Borntraeger , Steven Rostedt , Vincent Guittot , Juri Lelli , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Wanpeng Li , Richie Buturla Subject: [PATCH v3 08/10] KVM: x86/lapic: Clear IPI tracking on matching-vector EOI Date: Fri, 12 Jun 2026 09:33:53 +0800 Message-ID: <20260612013355.59231-9-kernellwp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260612013355.59231-1-kernellwp@gmail.com> References: <20260612013355.59231-1-kernellwp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wanpeng Li Clear IPI tracking from both EOI sites, apic_set_eoi() and kvm_apic_set_eoi_accelerated(), matched on the EOI'd vector. A receiver may handle unrelated interrupts between an IPI's arrival and its EOI; a vector-blind clear could evict the still-pending context and make directed yield miss the receiver. When the vector matches, clear the receiver's context unconditionally, and clear the sender's pending flag only if it still points at this receiver with the same vector and within the recency window. The existing trace_kvm_eoi() tracepoint already records the vector, so no new tracepoint is added. Signed-off-by: Wanpeng Li --- arch/x86/kvm/lapic.c | 61 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 3a5f197eb2c6..0925d359384e 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -1746,6 +1746,65 @@ static void kvm_ioapic_send_eoi(struct kvm_lapic *apic, int vector) #endif } +/* + * Clear IPI tracking state associated with a just-acknowledged vector. + * + * Called from both the emulated APIC_EOI write path (apic_set_eoi) + * and the accelerated exit path (kvm_apic_set_eoi_accelerated). + * + * Vector matching is deliberate: the receiver may handle an unrelated + * interrupt (timer, device IRQ) between an IPI's arrival and its EOI. + * If we cleared unconditionally, such an intermediate EOI would evict + * the still-pending IPI context and cause directed yield to miss the + * real receiver. We therefore only touch state when the EOI'd vector + * matches the one we recorded at send time. + * + * Two-stage cleanup: + * 1. Clear the receiver's context unconditionally when the vector + * matches: it has processed exactly this IPI. + * 2. Clear the sender's pending_ipi flag only if the sender still + * points at this receiver, with the same vector, and within the + * configured recency window. This avoids evicting a newer IPI + * that happens to share the vector with a stale one. + */ +static void kvm_clear_ipi_on_eoi(struct kvm_lapic *apic, int vector) +{ + struct kvm_vcpu *receiver = apic->vcpu; + struct kvm_vcpu *sender; + int sender_idx; + u64 then, now; + + if (unlikely(!READ_ONCE(ipi_tracking_enabled))) + return; + + if (vector < 0 || vector > 0xff) + return; + + if (READ_ONCE(receiver->arch.ipi_context.vector) != (u8)vector) + return; + + sender_idx = READ_ONCE(receiver->arch.ipi_context.last_ipi_sender); + kvm_vcpu_clear_ipi_context(receiver); + + if (sender_idx < 0) + return; + + sender = kvm_get_vcpu(receiver->kvm, sender_idx); + if (!sender) + return; + + if (READ_ONCE(sender->arch.ipi_context.last_ipi_receiver) != + receiver->vcpu_idx) + return; + if (READ_ONCE(sender->arch.ipi_context.vector) != (u8)vector) + return; + + then = READ_ONCE(sender->arch.ipi_context.ipi_time_ns); + now = ktime_get_mono_fast_ns(); + if (now - then <= READ_ONCE(ipi_window_ns)) + WRITE_ONCE(sender->arch.ipi_context.pending_ipi, false); +} + static int apic_set_eoi(struct kvm_lapic *apic) { int vector = apic_find_highest_isr(apic); @@ -1766,6 +1825,7 @@ static int apic_set_eoi(struct kvm_lapic *apic) kvm_hv_synic_send_eoi(apic->vcpu, vector); kvm_ioapic_send_eoi(apic, vector); + kvm_clear_ipi_on_eoi(apic, vector); kvm_make_request(KVM_REQ_EVENT, apic->vcpu); return vector; } @@ -1781,6 +1841,7 @@ void kvm_apic_set_eoi_accelerated(struct kvm_vcpu *vcpu, int vector) trace_kvm_eoi(apic, vector); kvm_ioapic_send_eoi(apic, vector); + kvm_clear_ipi_on_eoi(apic, vector); kvm_make_request(KVM_REQ_EVENT, apic->vcpu); } EXPORT_SYMBOL_FOR_KVM_INTERNAL(kvm_apic_set_eoi_accelerated); -- 2.43.0