From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570F9301719 for ; Fri, 12 Jun 2026 05:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781240746; cv=none; b=UuIFjC7t9uzO4ZxBUy0SAd9fNcGfm1S8V2dpEPX8cnyLyyFBvHV80Vyq8tmmHrNGoLt50LgeiayTx55U4I7jX7NWywXpgr65iNopeVeqwPsRxOEDOWZcIDQmgpcwttG9yqnZr1/spvw169b8LiVPVaBZUwWYGhX2P2L9Z2dVBCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781240746; c=relaxed/simple; bh=NAswpFxaVLzb6jZlxLKPH7YHkfqifFywsrm9UfGkfrA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e4rfRBQySCk71su4X030L7MgtZ5BEfC3giK1arP7ruInYcZDPFBHrcsJDKW3XPKzos/xyIp+jsTP29wFP+Z2kbwOxUdW/ih+9frk9WR6Kp+HcDtwOwYep3c2G0XUev09J41YdRHbi0nuebOPzhfkICvuv/hAAObIh8C7dJ3Jdu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JWx32Mcc; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JWx32Mcc" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-45f3cf907ceso251732f8f.2 for ; Thu, 11 Jun 2026 22:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781240744; x=1781845544; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DvzRkhttZNjitpCo77djJBtuvCtyFBax/t/zfhSNDLo=; b=JWx32MccNP3VfNjMmFaY/KzS49cjfGjdDgw/EIG+VCK4d8hoHAeHmDPbgwuYFydyKr J+Nj9I0HrCbcTRS8jRLO06/R0RPpqDHiT3V189ChfVd+PRV3cw4kiuCBdvXR4DeVixFv KqkV6hCBCxkp32eT4+Qib5beeri32CY+8CkrWEat2LR4e9HxCi7wvFtfQq8dSPkO44AY kJVhkw4rs7dBNSRLqRhGfqojKbVO87mczWkGIH7BZ8Jv5HzR/mFKxXjT2wjpQFCtxBn1 NFD+FaIRkeHZHZ3Xkju0JKqfgtcOh/Qjj2T3/iacSLI3OWRoHooTnhvdVOGlLOrfeXqp iohQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781240744; x=1781845544; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DvzRkhttZNjitpCo77djJBtuvCtyFBax/t/zfhSNDLo=; b=qUgZ8wYcrvm8aUvSUKkdnCTNA4tfaKoLlv28DlCENd22kno1FV4J5wkV0fR7RvDi3k nTd7oWZgjgV4aZOfAhNCIMPL6OEVCQFY+ouHKOhQobfqZlK+NLqUJjTe5j6nz0JTGhGI mnZFWvculDDgWjZJSu19t4CQheIeuQ6B10X/S+JrYByTafg+evGJclcD4GnGRKik+MpN DntsBuefyUn1mwg8k58Vs35C0TFb8vcdiUdgBOgwhJRpljOIHvhxsp6wT5g8rTvm73Lr zpCX8z2QLHrO17ePgJdn9DK9dsX86vdXZGF8A6XUn2vAiNqGhglNX5AF2zWIe7vXlKqX Kn2w== X-Forwarded-Encrypted: i=1; AFNElJ9gUGF//vBXiPVTCv25HcbETGwPkBUoC8iXwiNOVUf1TjLL+uRehBVT1vv55JkGcQFbfhD9K6cj29xKLno=@vger.kernel.org X-Gm-Message-State: AOJu0YxL52W7oHyHYAGqUoWuatDJdmr8tbmPr125g8NqZc4cNzWbrRX6 9zf5+tZtkj5f2sCeIlqjVKMkSZhd23tayxNZp5Q9JrqIklx47ZdaLkwk X-Gm-Gg: Acq92OGQbSEQeeI8YcYR3lHOSs0OpsipNKFt7W4OhkV34+6oKjDDYssXwHstNL4I9HJ bhwkYCfZcb9ffk5YaynUWjQecShyL4TDjBtR3yM3r45Nix5tlgfaJ9uQ+m7of3GDA/LOH+GCvaP b6CMtCiIvMlIMrb+u6G/mCxC3AqJYP+vBJFNaFEieXqPvGtjIw3x5sXYeFO4XPAiLfkhVAaFieU kEnlvbUjLUbqQEY5K1+4wex220QvJsQp+VmslrX/g/XcI3KN887JZWv83+MJtH6EchV0GA1FS+G Y0uO/9lbkPorR0dDjT0BolCXMdUijKC8vZQNmMxPOEGr/jEjB+bxTs1pbeF1/neJXlEY1j38cwh Bll+TIaI2Ohr83r5XpGoQJ0mB2+yEJdsBBwC7/f+imiqnmLiUtSDaw1N/JCbBpyE21u7P0WlkA6 L/ICrC/Q1iAhB4XvkLliVy4QOWxzNLKQvxKA8lg5gZ5xngGvYKr4586p5A4lvqQzuxF65oHPmNE 2LBLmfGNuE= X-Received: by 2002:a05:6000:2002:b0:452:65d:e108 with SMTP id ffacd0b85a97d-4606da5beedmr1558160f8f.3.1781240743610; Thu, 11 Jun 2026 22:05:43 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f2e6a8fsm2184809f8f.37.2026.06.11.22.05.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 22:05:43 -0700 (PDT) From: David Carlier To: akpm@linux-foundation.org Cc: syzbot+fd95a72470f5a44e464c@syzkaller.appspotmail.com, David Carlier , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Lu Baolu , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] mm: pgtable: protect lockless kernel page table walks with RCU Date: Fri, 12 Jun 2026 06:05:40 +0100 Message-ID: <20260612050540.31594-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ptdump walks the kernel page tables locklessly through walk_kernel_page_table_range_lockless(). It only holds the init_mm mmap lock and the memory hotplug lock, and neither excludes vmalloc/ioremap teardown from freeing kernel PTE pages via pmd_free_pte_page() -> pagetable_free_kernel(). syzbot hit a use-after-free in ptdump_pte_entry() reading a PTE page that was freed underneath the walk. Deferring the kernel page table free only batches the TLB flush; it does not wait for lockless walkers. Mirror the user page table walk, where pte_offset_map() already takes the RCU read lock: hold rcu_read_lock() across the lockless kernel walk and rcu-free the page tables in the kernel page table free worker, after the batched TLB flush. A walker then either observes the cleared PMD and skips the page, or keeps it alive until it drops the RCU read lock. Fixes: 5ba2f0a15564 ("mm: introduce deferred freeing for kernel page tables") Reported-by: syzbot+fd95a72470f5a44e464c@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/6a287988.39669fcc.33b062.00a0.GAE@google.com/T/ Assisted-by: Claude:claude-opus-4-8 Signed-off-by: David Carlier --- mm/pagewalk.c | 15 ++++++++++++++- mm/pgtable-generic.c | 16 +++++++++++++++- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/mm/pagewalk.c b/mm/pagewalk.c index 3ae2586ff45b..6d9f14f86784 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -655,13 +655,26 @@ int walk_kernel_page_table_range_lockless(unsigned long start, unsigned long end .private = private, .no_vma = true }; + int err; if (start >= end) return -EINVAL; if (!check_ops_safe(ops)) return -EINVAL; - return walk_pgd_range(start, end, &walk); + /* + * Kernel intermediate page tables can be freed concurrently by + * vmalloc/ioremap teardown (e.g. pmd_free_pte_page()), which routes + * the freed pages through pagetable_free_kernel(). That path defers + * the free past an RCU grace period, so hold the RCU read lock across + * the lockless walk to prevent a page table from being freed while we + * are still dereferencing it. + */ + rcu_read_lock(); + err = walk_pgd_range(start, end, &walk); + rcu_read_unlock(); + + return err; } /** diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c index b91b1a98029c..5b53e9a5b7f8 100644 --- a/mm/pgtable-generic.c +++ b/mm/pgtable-generic.c @@ -424,6 +424,13 @@ static struct { .work = __WORK_INITIALIZER(kernel_pgtable_work.work, kernel_pgtable_work_func), }; +static void kernel_pgtable_free_rcu(struct rcu_head *head) +{ + struct ptdesc *pt = container_of(head, struct ptdesc, pt_rcu_head); + + __pagetable_free(pt); +} + static void kernel_pgtable_work_func(struct work_struct *work) { struct ptdesc *pt, *next; @@ -434,8 +441,15 @@ static void kernel_pgtable_work_func(struct work_struct *work) spin_unlock(&kernel_pgtable_work.lock); iommu_sva_invalidate_kva_range(PAGE_OFFSET, TLB_FLUSH_ALL); + + /* + * Lockless kernel page table walkers (ptdump, and any other user of + * walk_kernel_page_table_range_lockless()) dereference these pages + * under rcu_read_lock(). Free them after a grace period so a walker + * cannot still be reading a page we release. + */ list_for_each_entry_safe(pt, next, &page_list, pt_list) - __pagetable_free(pt); + call_rcu(&pt->pt_rcu_head, kernel_pgtable_free_rcu); } void pagetable_free_kernel(struct ptdesc *pt) -- 2.53.0