From: Alex Williamson <alex.williamson@nvidia.com>
To: fengchengwen <fengchengwen@huawei.com>
Cc: kvm <kvm@vger.kernel.org>, Alex Williamson <alex@shazbot.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>,
<kanie@linux.alibaba.com>
Subject: Re: [PATCH v2 5/5] vfio/pci: Latch all module parameters per device
Date: Fri, 12 Jun 2026 08:11:24 -0600 [thread overview]
Message-ID: <20260612081124.6228fdb8@nvidia.com> (raw)
In-Reply-To: <06ade652-fc43-451e-a3ef-a8b6051e5c9a@huawei.com>
On Fri, 12 Jun 2026 16:40:37 +0800
fengchengwen <fengchengwen@huawei.com> wrote:
>
> Since nointxmask and disable_idle_d3 already have S_IWUSR and share the same
> "latch per device at init" behavior, it would be better to also add S_IWUSR
> to disable_vga for permission and behavior consistency.
>
> Runtime writes will only affect future devices, existing devices keep their
> latched value, so no extra risk.
The difference is that notintxmask and disable_idle_d3 are typically
diagnostic measures while disable_vga is a feature mask. disable_vga
has never supported runtime modification. So, while I agree it's
possible, this would expand the scope of this series from bug fixes and
behavior restoration into feature enablement, which should have some
actual use case in mind. Therefore I don't intend to pursue it in this
series. Thanks,
Alex
prev parent reply other threads:[~2026-06-12 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 21:35 [PATCH v2 0/5] vfio/pci: Latch module params, fix bitfield use and VGA unwind Alex Williamson
2026-06-11 21:35 ` [PATCH v2 1/5] vfio/pci: Latch disable_idle_d3 per device Alex Williamson
2026-06-11 21:35 ` [PATCH v2 2/5] vfio/pci: Release the VGA arbiter client on register_device() failure Alex Williamson
2026-06-11 21:35 ` [PATCH v2 3/5] vfio/pci: Fix racy bitfields and tighten struct layout Alex Williamson
2026-06-11 21:35 ` [PATCH v2 4/5] vfio/mlx5: " Alex Williamson
2026-06-11 21:35 ` [PATCH v2 5/5] vfio/pci: Latch all module parameters per device Alex Williamson
2026-06-12 6:25 ` Guixin Liu
2026-06-12 15:05 ` Alex Williamson
2026-06-12 8:40 ` fengchengwen
2026-06-12 14:11 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612081124.6228fdb8@nvidia.com \
--to=alex.williamson@nvidia.com \
--cc=alex@shazbot.org \
--cc=fengchengwen@huawei.com \
--cc=jgg@ziepe.ca \
--cc=kanie@linux.alibaba.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox