From: Jakub Kicinski <kuba@kernel.org>
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org, Marc Dionne <marc.dionne@auristor.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org,
Li Daming <d4n.for.sec@gmail.com>, Ren Wei <n05ec@lzu.edu.cn>,
Jeffrey Altman <jaltman@auristor.com>,
stable@kernel.org
Subject: Re: [PATCH net 4/5] afs: Fix netns teardown to cancel the preallocation charger
Date: Fri, 12 Jun 2026 16:48:43 -0700 [thread overview]
Message-ID: <20260612164843.20452d5a@kernel.org> (raw)
In-Reply-To: <20260609140911.838677-5-dhowells@redhat.com>
On Tue, 9 Jun 2026 15:09:08 +0100 David Howells wrote:
> Fix the teardown of an afs network namespace to make sure it cancels the
> work item that keeps the preallocated rxrpc call/conn/peer queue charged
> before incoming calls are disabled (i.e. listen 0).
>
> Also, if net->live is false because the afs netns is being deleted, make
> afs_charge_preallocation() skip charging and make afs_rx_new_call() avoid
> requeuing the charger.
>
> (This was found by AI review).
Both Sashikos think this patch is still racy FWIW but not a blocker IMO
next prev parent reply other threads:[~2026-06-12 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 14:09 [PATCH net 0/5] rxrpc: Miscellaneous fixes David Howells
2026-06-09 14:09 ` [PATCH net 1/5] rxrpc: rxrpc_verify_data ensure rx_dec_buffer alloc David Howells
2026-06-09 14:09 ` [PATCH net 2/5] rxrpc: Don't move a peeked OOB message onto the pending queue David Howells
2026-06-09 14:09 ` [PATCH net 3/5] rxrpc: Fix UAF in rxgk_issue_challenge() David Howells
2026-06-09 14:09 ` [PATCH net 4/5] afs: Fix netns teardown to cancel the preallocation charger David Howells
2026-06-12 23:48 ` Jakub Kicinski [this message]
2026-06-09 14:09 ` [PATCH net 5/5] rxrpc: serialize kernel accept preallocation with socket teardown David Howells
2026-06-13 0:00 ` [PATCH net 0/5] rxrpc: Miscellaneous fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612164843.20452d5a@kernel.org \
--to=kuba@kernel.org \
--cc=d4n.for.sec@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jaltman@auristor.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=n05ec@lzu.edu.cn \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox