From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9272225B083 for ; Fri, 12 Jun 2026 20:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781295417; cv=none; b=IjsUYLWIHmSgBLTbztDFmgx0qN5HQS5ne+NLbGD/FVxPCpgqMqPpw4/8PDbTAzcxS3h8sTjck33WXQoN1yWMFqi1wL91SLwSvS+IGIXH4wYOxLWGioaHbWZwqTnYvyOWjQMyv9/4d6aNnjdEI+uLnHHROGcnrLluzNHjJ//bfk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781295417; c=relaxed/simple; bh=Lqta/+TCAlU+KQiORLUZ7AwCWTzNKVq7JoXzTXVhstM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=drnJbhuVnZbAhoV/DEP8CL4BJbzuTM8p1/t57Tj34qCFEJKHVCqZX66jeH8tc0nGr62evJz1gobQEfkGbGAf0sYis3beOSlmC2mwi91ZY300nXa3Yfl4FKtB6Uvi7+FPhvwVcJ9PKnDO5/n/UzY5+kEsISho/PLR8xgzjJ67G/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jeXH64fm; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jeXH64fm" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-491b390f9e9so6830155e9.0 for ; Fri, 12 Jun 2026 13:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781295414; x=1781900214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1hhKOxDrDpBPPiZ/spcJOPLo0Mt9S9ZNTQUBBZDwMv0=; b=jeXH64fmvBOUWVnyQVCAJl01JFPr1Hhx/9S3Cwn3TZdIIXhhe/bXXoOY2LhMw0Q0ey pjYxJhcMWBHBs/HslFXGeOUditwsCWX+djiHY+b/36lcmERoGhXUzCRHaXTXFKaxBpYN PeV4aIa7gsRJ+mYAqABOLVexxIhSnXny5cZOFn3+q2K0myql2Q2EPeKssjHYGIfFH0DH vtyUf7ln+KFfHgSX07a5xT6v+vN7RtAkBpwqSNp1EBKEDQm6VjQTckm3cKaVFTkYIZa9 dCCa/aBrCm+LOhMsuPlaS4VXYxAeAvIm/2bNxjIDojAqCEkvlJ5czfbSdkee3XzhJu06 vn4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781295414; x=1781900214; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1hhKOxDrDpBPPiZ/spcJOPLo0Mt9S9ZNTQUBBZDwMv0=; b=nH7eeMLjgGUs+YtTUTTX3pOrX2DnE0RY0FFMaW34a+dxHBwz9spmwjftbcpb6QUsqL Qx3XONx4bjlVrZ3CtwY+SnpyORuo7/vBz/U6WgbVR+Tc/2O0J3tnilhUBm3JICFe3lOa DtKC92M4UOLEvCjqfH/1HwYypscTFx9w28UsO1z/w3ix1LQT+XTTRiDfomEwwjtaF0tT 6QJraPF8i1ZR6HohqjmBY4DJAjkiLYaZkTjzL+IuJs5b1p8N2CQoVVVhAX2ZUJxlclbf amLdTCYFDr3NaN8Cb99+ZuIs3vrFsqlyhJ1LXSEGLdqMFLxudJVFIzEQJb+vv4lj/7cm CGTA== X-Forwarded-Encrypted: i=1; AFNElJ8Ch8ilSw6FiH7U0FXTjEPRBUBSSDhGFIp5qXvyxEQCR6I49Vo50TYr2APS2YRB2p+ZIh8ZoEYoRXB+Hnc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7w/F0A2mdDvX7qJG8J7E9d4C/sIuG43wOloO5bF/GWYxgNSiY lQRfL5PAcCwHraaGEn14o1eJfV+wBKR7+Z8d510KmUm6vbjnR9mXa2/U X-Gm-Gg: Acq92OEJPTp/3Oi1aEJgqN/6/2wXzPRtGk/g3ydfhkg93h783dr532NVE1QGNAzmGjr xAY9peTeov+Rgyu0C8NozPjbgLSwu3AdXfCwxHJxn3pWIJO6O471Z8k/JjkAjtfj91bS5kCVaKB Byre2rQ/oqdjg/hXl76AadFj9QeqmbNDI5m0MQIwCZwhMzvdDRPsSCi4WdbsF0J2ZIuBhgakbAn UffH/khwV2mNGAyw8lnHTzTCCG24PmWn+KpIJj6vo455uWsl+bx6Mh+R4MDlGO4ajcb1p3nb6O2 X9c3TQBIVQeDw2XmA7p8AFNDjsJnFr5KCH5mbI0MNSkNMJQWe1sptwkjS6Z938Pjoea83VgmU5H NwdOVPHRVhXg/H0kdSnEW8SvT97Cs66IKTDpJYDt1DOJ7JW3XXlQOguT2MAGqOaPqHDdJSI2/Qp mk7lMmgQToHNbLSxEP0RrOcFPC7WNlbc989xvHMVRniQkA02xnSITWaoSz+PJO8KW4LARXwA09F QE2umCzSGxwX8QLpwDy7/WyjB5/FQ== X-Received: by 2002:a05:600c:820c:b0:490:5cd8:d213 with SMTP id 5b1f17b1804b1-490ec4d3407mr55575625e9.15.1781295413834; Fri, 12 Jun 2026 13:16:53 -0700 (PDT) Received: from workstation.speedport.ip (p200300d507395ea0832fc1eee9dc144a.dip0.t-ipconnect.de. [2003:d5:739:5ea0:832f:c1ee:e9dc:144a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4606f26393asm8925902f8f.5.2026.06.12.13.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 13:16:53 -0700 (PDT) From: Mert Seftali To: Lee Jones , Pavel Machek Cc: Steffen Trumtrar , Dan Carpenter , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Mert Seftali , kernel test robot Subject: [PATCH] leds: lp5860: Return an error for an out-of-range 'reg' property Date: Fri, 12 Jun 2026 22:16:37 +0200 Message-ID: <20260612201637.197608-1-mertsftl@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When fwnode_property_read_u32() succeeds but the channel number exceeds LP5860_MAX_LED, ret is 0. The error path then passes 0 to dev_err_probe() and returns 0, so an out-of-range "reg" value is silently treated as success instead of being rejected. Set ret to -EINVAL in that case so the invalid channel is reported and propagated as an error. Fixes: 3daf2c4ef82b ("leds: Add support for TI LP5860 LED driver chip") Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202605210624.3gcr3prk-lkp@intel.com/ Signed-off-by: Mert Seftali --- drivers/leds/rgb/leds-lp5860-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/leds/rgb/leds-lp5860-core.c b/drivers/leds/rgb/leds-lp5860-core.c index fd0e2f6e6e0f..9eeb01b3e56a 100644 --- a/drivers/leds/rgb/leds-lp5860-core.c +++ b/drivers/leds/rgb/leds-lp5860-core.c @@ -115,6 +115,8 @@ static int lp5860_iterate_subleds(struct lp5860_led *led, struct led_init_data * ret = fwnode_property_read_u32(led_node, "reg", &channel); if (ret < 0 || channel > LP5860_MAX_LED) { + if (ret >= 0) + ret = -EINVAL; dev_err_probe(led->chip->dev, ret, "%pfwP: 'reg' property is missing. Skipping.\n", led_node); fwnode_handle_put(led_node); -- 2.54.0