From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB8C114AD20 for ; Sat, 13 Jun 2026 01:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781315405; cv=none; b=VOFyhBJ8Knt3hnVSzktbhoAf9YXx3cjmNnGbHTgJta+0bzVqtZR3HK0nX1/ftpaoHbkjnJaCCVzR+ckD6I78ebN3RxuahafH/a2n7TlxaE3YOx3GG2FVrVe+QTTlAF6efCRVNnfioH5aFNp7fe9AluxT9zkevSH72NIE3gxO4u8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781315405; c=relaxed/simple; bh=2Woh6FChjTfvhDIM77iBJMo9iKET98W88YfAX52Le1k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VtDEVDzk8rmoGgtxT/KPznxJ77vijm0yt9+iDPsqO4zIejnluiSGIeYugF3aT2vtWBipsAyh+Irf/U9i6kI7awQ3SkYnocl1n8MAWIM2WEAISBUrKRsZmuQM6fe6iYAaGMp0nVtu/cV0crHeV5cp/YBOU34kwh1MjRRM/3zwCYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZswazNxJ; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZswazNxJ" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-842cd900ee0so739563b3a.2 for ; Fri, 12 Jun 2026 18:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781315403; x=1781920203; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t37aJaEtFHDIlL04HCphJkfdvq0+XVtQ1GXGJFYW14U=; b=ZswazNxJtc5sfkY+aOKRdjNE6eZn+tkz1I440jkveVPyfkHYbLHyKToW/2y0xy2Gj8 5X4JckRl/nbXeSk+JQbvuQPxtkMG7AifQ4hohOAlCYSBqutWgnNApehIW/fZoHR9SDNe o+1aqru7QBmL7rjmKgcSVM+f2Dv+YSBfKXGf/JZb4fLOPei+VF2NbukkGbkws47lq9bZ Kglniq68OT1/CUTWO3rDugFOTgDFCidfCQW7nTT2gD5D3Ua/aljRinxFMr6ONdugDG2H G00E7nZ8P0jROOmaS8wRo7M7rOw2Bf3vV2qCqUBVZh3R+qMSPcKRJGGfLApToQbejXg5 e2Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781315403; x=1781920203; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t37aJaEtFHDIlL04HCphJkfdvq0+XVtQ1GXGJFYW14U=; b=XS2BEWCAgKaeKqD0rvPvQesVkBzBrgHOH2+KvE3LH+apubl9GgKP/UhW8ly3EDddOq uUUsMhpIqVEkfaDrAgtGNpIqvlq6qv12u7+CjYogvLMEj8d+R0Tj4t6ARu13xiHlxZD9 ccANgKOMAQE3/25KxxZFHaxT2bDoHdez41m5nfFOD48+LJ4yaVa5xfxnwpvQAAci1KQ5 hXX8FireCq8mTfRpftTTazxRV4TDHt457rxTy8pXmoL8sPQvqK7MazwEzSaDR0WDPNDK O73cFYNtu1J2OwB6BTld2pqVE7NZ8wuJghkxxzetvoHmjfjswRSTcFqxVg3Fe7Q8Ud3k k4/Q== X-Forwarded-Encrypted: i=1; AFNElJ+g/0ubrV6Qy0lADfYbLZ+EedxC0FkqK3+Czj+SoPyE8Sz6JJ83R7P9SeiCWhaKLM6qjkGx4bpYOyzTzVU=@vger.kernel.org X-Gm-Message-State: AOJu0YywRoQZDCJAiIsg2Ez8gnyomoTv7LuMgayruwHRwhoi96mDaF9c 0BnK2CCnkMQDBmqCfOStJBsYMLK0zlGSdCH4whG55vRN2J+UHgQ/TJ6aGyOCgaMPnjk= X-Gm-Gg: Acq92OFI7JJNpphuXqMlwXTXQYKrfFi/8tKMCOa1SVucJuvaQ9P2sojQFYvGKP2wdiv KRygUHHmiv4sQW8Tp2DYxwlQpekU/Sz3eebZ2MxadEkuF/HepwKbFDLawIRXkPfvfr4b7wXf22l OHo4Us8a7UthslzZadS/gl79DAP/jdfpC9WcWQjhS8q9v0GU+eM/g/4Gm2lB1qULcwdjEXI4b71 8oPdfO78HHzgBnghALcX0F9s0DafZ5nVuuToWfqgLweJ9AGcT0zptCT5GWUnM67AXsEObDB8+Eu IyxPK82aEHIb4qmjlzpZZWI44uEB3nvPR1E91HIGmFpV5CicOStBrGSiyG2N04OpYZQcNPsuwW0 2//MxVEvOs5vjwNHR4aAWqPQkIZQameAl3iG1EDU2ojhsRrb+N6Rns2oEOt4c6hL6GRw06j2oPT jn9+IxEJxllnpKnINgRvwuWOrMYA== X-Received: by 2002:a05:6a00:39a9:b0:836:3f6a:3e7a with SMTP id d2e1a72fcca58-8434d07b973mr5705482b3a.26.1781315403315; Fri, 12 Jun 2026 18:50:03 -0700 (PDT) Received: from localhost.localdomain ([2604:3d08:2474:4800::857b]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8434acf23a7sm3336210b3a.22.2026.06.12.18.50.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 18:50:02 -0700 (PDT) From: Brock Haftner To: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , outreachy@lists.linux.dev Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Brock Haftner Subject: [PATCH] staging: greybus: audio: add missing newline to sysfs_emit formats Date: Fri, 12 Jun 2026 18:49:05 -0700 Message-ID: <20260613014905.48458-1-brockhaftner@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sysfs_emit() function is used to format strings that are returned to userspace. According to the sysfs documentation, these outputs should include a newline character for visual clarity. Fix the checkpatch.pl warnings by adding the missing '\n' to the sysfs_emit() format strings inside several functions. Signed-off-by: Brock Haftner --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute = static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute = static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute = @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } static struct gb_audio_manager_module_attribute -- 2.54.0