From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 439493537FB; Sat, 13 Jun 2026 07:20:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781335223; cv=none; b=tllJIR26N2L5baLhpjLF3WW5o8zO+LuO/fyDJ3vUkY3P9saN0LHFX3SIx336yHa6nZuJoiho39YfOZwnMTr1reh7oOKPUJ/POBm9x8bx7uOEUP/DB1c6bmIujd87otB1IXGVF24/EAdakjZzjyhwgz8uBLFMrNL1+TcQG3fGH9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781335223; c=relaxed/simple; bh=000EMMK7WLb3OkYXRa/zDtdHVW8z+EQTEhVnpyjicq4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=akXk6XP4R/lCsOXNxqSaO1gFD7iNmt+LM5n453HVVM+VcqM1Rv7mPK5V9CTPvr8H2qM256LHntfpKUJlNiTMe+bmCQWC0IBz7P+4sWaX19NvRGXpFSsxqXeKFLxKlnREIiwmLEHEy86uvoncdaY53oGzCG1CXM1PkWDKV6JXf+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FLpxwiUK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FLpxwiUK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC4D41F000E9; Sat, 13 Jun 2026 07:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781335222; bh=mLUE4ceu8NuY6XaMIMUV6+2WUrhjPHcDpzVZyXgXFV8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=FLpxwiUKk/oYLyU3rqIc1Llmd5Yhu+Jz36wOA1E7he8vtkbdm+KjUynPQ4d4ByXAx kEArUQK5H2wGUalhz638zcpGuLCwcYkf11XHxooa+AK0LT0xad3u7u8b67UkX7lVO+ jaI5kmgIqjXBshv0+LIb2G5ywupXEsrYMftMAU90ZcQ07GyJzWTfe33A0intcorq/t P600GQZobNSwGsj5Tcex/MFcBYmNWsUEUz/wIj37kIgsaLB1rmcF6GVEAQu1mmpZEL B9ztjTnn40pvnokW8kBViRtagsnysoZSaT7JxRRJ2O8CIcHQUC2ywrGdO75NIF9wsl Cqaff6j80cewQ== Date: Sat, 13 Jun 2026 08:20:16 +0100 From: Simon Horman To: Runyu Xiao Cc: netdev@vger.kernel.org, sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, bbhushan2@marvell.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, amakarov@marvell.com, tduszynski@marvell.com, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn Subject: Re: [PATCH net 0/2] octeontx2: quiesce stale mailbox IRQ state before request_irq() Message-ID: <20260613072016.GA712698@horms.kernel.org> References: <20260611160014.3202224-1-runyu.xiao@seu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260611160014.3202224-1-runyu.xiao@seu.edu.cn> On Fri, Jun 12, 2026 at 12:00:12AM +0800, Runyu Xiao wrote: > Both OTX2 mailbox registration paths currently install their IRQ > handlers before clearing stale local mailbox interrupt state, even > though the code comments already say that the clear is needed first to > avoid spurious interrupts. > > This issue was found by our static analysis tool and manually audited on > Linux v6.18.21. Directed QEMU no-device validation further showed that > the real PF and VF mailbox handlers are already reachable in that > pre-clear window and can touch the same mailbox and workqueue carrier > before local quiesce has completed. > > This series keeps the change minimal: > > - clear stale mailbox interrupt state before request_irq() > - keep interrupt enabling after the handler is installed > > That closes the early-IRQ window without introducing a new > enable-before-handler window. > > Patch 1 fixes the PF mailbox registration path. > Patch 2 fixes the VF mailbox registration path. > > Build-tested by compiling otx2_pf.o and otx2_vf.o. > > No OTX2 hardware was available for end-to-end runtime testing. > > Runyu Xiao (2): > octeontx2-pf: clear stale mailbox IRQ state before request_irq() > octeontx2-vf: clear stale mailbox IRQ state before request_irq() For the series: Reviewed-by: Simon Horman