From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14BEE3932D4 for ; Sat, 13 Jun 2026 08:48:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781340538; cv=none; b=ku6K+3RUpMTSBo5p2B5oyLxqzxMiWo22vaES+vvRziI3w4n1fBm5YuYrZGOrkUB3wayHoM4DoOpJmKx3GztYHpD35Fs9qwZUEHRoUMV4+tZPwWnDExPdOVJ4lAyRX/PWT7RAJNCxgoOC3B/dvZM1u8viuOy1WzFEkKTUmh+VoqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781340538; c=relaxed/simple; bh=8+o1I4G8ULxbA6lUSE6pN4G224uukrV5uZVJHW6LIPY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kdnSVGgL/TFZSiAO+AjRjtwj1E7jJiBCxWFTP6YTsS2LC3jiGVHXg4VFNUrr7Ru+fudspqx8GmXELaypE1DFRAUo+x8XKwWr2Jv1Gg8M5x5TeALtxrQuKZSOKz/eynh/hvxzpBPx+WDZhvIvrWo6j+GQeewZSBZOJjNcoSzSZDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bo6NeL0t; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bo6NeL0t" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-36da151a152so1343231a91.1 for ; Sat, 13 Jun 2026 01:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781340535; x=1781945335; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1BMHqx2xIWQxY0wMImf+3ynOsFtiUDlF0vRJd2haY0I=; b=bo6NeL0tDKRkeMOmzwokYUxxCr7ww7L3rCIjRyUMt2w5BoExLpGJ5MzLaO+3AuC8na ku4LvZnbXHpAHGReeYv3vdb3PW24rWWqN2IsjNymthZEA5U+uqljfiEauEZtOdkslLQQ Rr3r6QdW81SF7bdYaDJakDJvy+31KD4X5Gcbk0hXwFrgut5UbiaN+qOdSj/yAFZErmpL +Oshcw5fN/ZfNqCaBfdnCa/7kjcO5XGByjDDhPFguBLWpczO7LEulbDOKqIZFtLAu5YS 6QgH+tsXvyoUlGnzLv8VmnNTbcA9drQcj/cnn9vJxNH78C/Fh3mNCZPN1KhahS3LIjpZ FNnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781340535; x=1781945335; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1BMHqx2xIWQxY0wMImf+3ynOsFtiUDlF0vRJd2haY0I=; b=o0XjnwQ8jQ1LE+XD4o/kpGP0xO46XiHtOEvfwVWCZmWEJQLO6713zRhkWirjxViW8e Xe0KCYT+6BVN8XdQBcUVivJD2sL/AcvCw3oJQod/Vl1CWR7nsHmTvq3oswq/Ll8FU++U +JTLQW9dBfmg76QLyLpNKJ83i7uCfRFXtN+T3+2Zgo9/QSycYkEfcngd0FSlU9U8oa66 ityM2laKYX84S8R9tVy0nHNyfMCRSmzeLyfXVx8qrl9uWbHLe3Q6OgZOjFPOGE4CDHlG ojl9sPaWCnhNhgESaSOguuKA9Aa4FBbzL5hJky13jcnzA9oXWFFucgmt8ysjywNnlXsz ymfA== X-Forwarded-Encrypted: i=1; AFNElJ9yN8H87f5h3QnMdnTr+1evJmsfTk4Oi4odZlRuvkLvvibS21Jy6QIO4HS2AG0EMGGHmN3g6V+mC0PxTHI=@vger.kernel.org X-Gm-Message-State: AOJu0YzV0WYl9KDMJmpNNMX5X/CsGIJcGHK8SMzJzW4FIzDPJ8Hz/iG9 cIDs2yRi8i7q+QMKayc8xu1BGm0jTiuVwRyTZ7bfjywyG827c7dBQtVN X-Gm-Gg: Acq92OGKmEMk0/HIbOUObvonrQeU/yaTtrG6nrQ3INCn4h9wuw3piNxkVcW7ZbGRuCf DxixfN4ob1Q8Qw9jsw9lwauykgaEkJ9Dxl6hrg6ek5Q3JqNkeIaJaxTnC/bi8lFoTxGNM8h3U86 puSwabddohzjWYcgVmWvfNBKm9fnyslVAqnYfLD1V5oCMEw/+tSic/czknqYG0iu4YMdCN6+1BM ZbBJkh7AQwqtTdxTgVlCs5gY+H3Nb8Bues8lBSAPoWzna1mKGZm6jHuilJh5V8/uG6mTfM8LdYH vdQShPmZIxExChwR1cXzBjdZe/gWSfURkFTbp9tWD5tUEn5pwJj3lOo0GGOieaBOxN0SsjEFefM CwCDUgPWUhVvi6OwdLsRwkIdmdCk6BunMg6EUw1JYkdLhMGRqg0FrmAd3rBcBstyta/KQ+6shQL 2YtJ0eORBNbVnu4G7RfpIOBwYzxC4ESPjCPpcV6dkwIfiwlt+QduwX X-Received: by 2002:a17:90b:53cb:b0:36d:8e49:d8 with SMTP id 98e67ed59e1d1-37c2bcefb0amr2674183a91.15.1781340535292; Sat, 13 Jun 2026 01:48:55 -0700 (PDT) Received: from localhost.localdomain ([49.207.217.37]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37a210ad64esm4242512a91.0.2026.06.13.01.48.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 13 Jun 2026 01:48:54 -0700 (PDT) From: Biren Pandya To: linux-media@vger.kernel.org Cc: laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, mchehab@kernel.org, linux-kernel@vger.kernel.org, Biren Pandya Subject: [PATCH] media: i2c: mt9p031: fix endpoint parsing use-after-free Date: Sat, 13 Jun 2026 14:18:49 +0530 Message-ID: <20260613084849.57897-1-birenpandya@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The mt9p031_probe() function calls fwnode_handle_put(np) immediately after parsing the endpoint. However, it subsequently calls fwnode_property_read_u32() twice using the same 'np' handle, leading to a potential use-after-free. Fix this by moving fwnode_handle_put(np) to the end of the endpoint property reading block, and adding it to the error path of v4l2_fwnode_endpoint_parse(). Signed-off-by: Biren Pandya --- drivers/media/i2c/mt9p031.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index ea5d43d..04c17cb 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -1075,15 +1075,18 @@ static int mt9p031_parse_properties(struct mt9p031 *mt9p031, struct device *dev) return dev_err_probe(dev, -EINVAL, "endpoint node not found\n"); ret = v4l2_fwnode_endpoint_parse(np, &endpoint); - fwnode_handle_put(np); - if (ret) + if (ret) { + fwnode_handle_put(np); return dev_err_probe(dev, -EINVAL, "could not parse endpoint\n"); + } fwnode_property_read_u32(np, "input-clock-frequency", &mt9p031->ext_freq); fwnode_property_read_u32(np, "pixel-clock-frequency", &mt9p031->target_freq); + fwnode_handle_put(np); + mt9p031->pixclk_pol = !!(endpoint.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_RISING); -- 2.50.1 (Apple Git-155)